From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7182FC77B71 for ; Sat, 15 Apr 2023 03:49:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E70EF900004; Fri, 14 Apr 2023 23:49:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E213B900002; Fri, 14 Apr 2023 23:49:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0FBA900004; Fri, 14 Apr 2023 23:49:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BE1F1900002 for ; Fri, 14 Apr 2023 23:49:51 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 82F9D1A055A for ; Sat, 15 Apr 2023 03:49:51 +0000 (UTC) X-FDA: 80682246582.28.6F92105 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 9A4A8180009 for ; Sat, 15 Apr 2023 03:49:49 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cMWckj9b; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681530589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tj9FMMSSs+zbNutNJhDAMnGvzM0c1XlAU1yQHGHsxu4=; b=DS/XaIL6QjTj2dRx4492D4MQ6ATsEwCm29RNV17zk91I3pyJvdbObdvb5ZLxDE0KsvP+bc MnvcPlGGD4t7KYnp2dp98B19bYJlBVVMMJ2Vdo6HrV9pk999DDc3YPIZuBRieTMIifZn3R zgw2i9qSQzqoYBj71In+8LY+T+yuBvQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cMWckj9b; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681530589; a=rsa-sha256; cv=none; b=CC0U/Nhzdfk+6tshKYB1GkM/jggx4IJvbEfHOvQW30YLRWUphsN4ryBlwNvu+/XQxgcOku WLhXHDXgONwEbpv2IOQrr2QicFt2/gGiNdjHOEf8um9myuJk0iaFvcpxDlmzJopLMJa9ei RIoeq75sJsfICTKVG34xA2Iy8j2Hu9k= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Tj9FMMSSs+zbNutNJhDAMnGvzM0c1XlAU1yQHGHsxu4=; b=cMWckj9bkdAY1/LRDkH51APSpK gypvKgs2sJ8+8A6WllOijcrzhsZXMw9GB8tZjo2GLc+GzNHudVgRXP1WaC3VC/LcZ8BfhU+a2TP3p AxkZFaXN2thVbXc0L16Y9Dbi6AAW1MKWnl+16fiVp6yJAzRlWv+XghjC3nOly9adcQ4Gk8cLYl+Bw TARE8+mKyPsVIAc1NDzzYe192eZCHY9bs9RJQt5IcGS95lIjetNqg3raRMv7H4QsJ7VlpMkp3sPGQ miG/zj1mR7LXLkEldYyD7A1iklef8WOPAFRotvlX16ssC7VIer+BBSU88skLX65U09Av0/Epb2uCR oWfaArrw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pnWv2-009KXJ-1p; Sat, 15 Apr 2023 03:49:44 +0000 Date: Sat, 15 Apr 2023 04:49:44 +0100 From: Matthew Wilcox To: SeongJae Park Cc: akpm@linux-foundation.org, vbabka@suse.cz, paulmck@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] mm/slab: break up RCU readers on SLAB_TYPESAFE_BY_RCU example code Message-ID: References: <20230415033159.4249-1-sj@kernel.org> <20230415033159.4249-3-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230415033159.4249-3-sj@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: az4w8a3xppu5c8ody4kswphx5dp8whhe X-Rspamd-Queue-Id: 9A4A8180009 X-HE-Tag: 1681530589-465320 X-HE-Meta: U2FsdGVkX1/6IopqfPJH59ZhwQugUwHGJkDAUC1xEEDJKfLh/W/zdPEeo5HRcRaZGK+0q1HkzFASCtFhWTM1tWnXjwe3kDmlZPrdSz4gCh9g8GYCnCukK0J1TBNUXdPAh30JxoOw8VeHsUKIwYm8a9eGSdeCScCsCFChyE3LidXihhrE3ANV9Xk2hyRSQnadUgUkkzogap/je58z+JGzaLhapiSkEBkMJ9ZPfRaN/sr9szA4h+VsDsw5Z4l6bQJml0eiKSeX7917RSuiPH+Z6TKHBWImVXfsTlh/yQOS1QuoegZSNBgwgadWm3CjBjzoyzAmzVoecA5DL9AZRgKtEfdVh3Y87beyMk0t62LohZ1gidiU3XZEoRrs6vzGCyzJ7Cgf626fcO2Rz9Iz9keeZvQgNwmaOCBrRJpAIWugBoI8BBVvJ3WG7gTCpwYh33KOa1BmsvTTMi8jmk/xpHjxXM67m5omja68yTFvfl4hd59s8y2CZteTsFqGluCDVh08LP2sk46sBs5ho/Qp8Els5Cd9nxTLsNAb7ROhG/kbetv+bX73iyF0ZChKj5+cTjj5c4eVBxoJmrm5I4OPvfMS2qwKWyc8y7TZogsi0wC5V3PqKJDNxohpunogJR9MkNyFYh1tecMLWHJW2qP5l2B3O2lwSCsXhqOW+5pMbQ2rWwzGezpF9ms2lHkD1Mr/aCDfBHEB5qPFxSGQl+rVone4qQ35QLsZXK9QBVHM3qno5IhwHf8KniQKwinN6Ir4a7914CeLXOIxn7hWJ+yI2NFTINANa/JNOYzm/Jf0B7n8J4nmdq4ckdJkM7ls68DK+U6Fnz4wwT2NmLRWEfHuc2pClcvKqPwIVJH/7+1tBZzA0AMyP2pmqr2+wMUqgx+ePwoO5JV/w9/dW63N1qbEjxXt4kICu/VJ2K8GzbVBl3cjSj/SDdu5SxqwRXXC8H0+lbu6WkkUV/SMJrYwm/PZ9pO gUMhwT0s OJX2fTfxTBoh1cO6iIItc691RqBep6GN+kXcY5iM/IuhIj9Ew7GDFWjiqSFvkaVBhgbJ8YylAC9rswHiu9jlByQHdnIQGQqWdf64bT1mnU9B5j+2cm00LNkWK9KUOULFPYMG0Pe2JKzfIcRmpKWYxfCTJhhdGZgdiFgZIbZ6daPQ56jUSJ4WWcbPAcjDloiZ2oMmwCz+sq7BxKh4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 15, 2023 at 03:31:59AM +0000, SeongJae Park wrote: > The SLAB_TYPESAFE_BY_RCU example code snippet is having not tiny RCU > read-side critical section. 'Documentation/RCU/rculist_nulls.rst' has > similar example code snippet, and commit da82af04352b ("doc: Update and > wordsmith rculist_nulls.rst") has broken it. Apply the change to > SLAB_TYPESAFE_BY_RCU example code snippet, too. so the page cache (eg find_get_entry()) does not follow this "split the RCU critical section" pattern. Should it? What's the benefit?