From: Matthew Wilcox <willy@infradead.org>
To: SeongJae Park <sj@kernel.org>
Cc: akpm@linux-foundation.org, vbabka@suse.cz, paulmck@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mm/slab: break up RCU readers on SLAB_TYPESAFE_BY_RCU example code
Date: Sat, 15 Apr 2023 04:49:44 +0100 [thread overview]
Message-ID: <ZDoe2K7mMu31/6Lb@casper.infradead.org> (raw)
In-Reply-To: <20230415033159.4249-3-sj@kernel.org>
On Sat, Apr 15, 2023 at 03:31:59AM +0000, SeongJae Park wrote:
> The SLAB_TYPESAFE_BY_RCU example code snippet is having not tiny RCU
> read-side critical section. 'Documentation/RCU/rculist_nulls.rst' has
> similar example code snippet, and commit da82af04352b ("doc: Update and
> wordsmith rculist_nulls.rst") has broken it. Apply the change to
> SLAB_TYPESAFE_BY_RCU example code snippet, too.
so the page cache (eg find_get_entry()) does not follow this "split
the RCU critical section" pattern. Should it? What's the benefit?
next prev parent reply other threads:[~2023-04-15 3:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-15 3:31 [PATCH v2 0/2] mm/slab: trivial fixup for SLAB_TYPESAFE_BY_RCU example code snippet SeongJae Park
2023-04-15 3:31 ` [PATCH v2 1/2] mm/slab: add a missing semicolon on SLAB_TYPESAFE_BY_RCU example code SeongJae Park
2023-04-24 17:43 ` Paul E. McKenney
2023-04-24 18:27 ` Vlastimil Babka
2023-04-24 18:35 ` Paul E. McKenney
2023-04-15 3:31 ` [PATCH v2 2/2] mm/slab: break up RCU readers " SeongJae Park
2023-04-15 3:49 ` Matthew Wilcox [this message]
2023-04-15 16:27 ` SeongJae Park
2023-04-17 11:05 ` Vlastimil Babka
2023-04-17 17:26 ` SeongJae Park
2023-04-17 17:53 ` Matthew Wilcox
2023-04-17 19:01 ` SeongJae Park
2023-04-17 19:02 ` Vlastimil Babka
2023-04-17 19:08 ` SeongJae Park
2023-04-17 19:31 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDoe2K7mMu31/6Lb@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paulmck@kernel.org \
--cc=sj@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox