From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A59DC77B7A for ; Sat, 15 Apr 2023 05:27:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96C19900004; Sat, 15 Apr 2023 01:27:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91C11900002; Sat, 15 Apr 2023 01:27:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80B72900004; Sat, 15 Apr 2023 01:27:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6D73A900002 for ; Sat, 15 Apr 2023 01:27:42 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 39F47ABE66 for ; Sat, 15 Apr 2023 05:27:42 +0000 (UTC) X-FDA: 80682493164.07.B12EA30 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 7796A14000E for ; Sat, 15 Apr 2023 05:27:39 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=tgzqhriU; spf=pass (imf09.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681536459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CG3j3Emrq0ILtwn9+zAYJUCdUuL1CFkKfYUUa27fHAE=; b=CF3Ge8vxX31HaP/edzn+YPbilXqTDhXC/VAeZS3Y+X4gAX1XsYlB/79pEt/DGEkaWOYi1m PLH3MvXEUO5NlWt1Ow6iBgf+VBND23fEnh9pRkP44+/wlmQ/s8SAXWo/K/OcCaJX3sOd/f quxCRwvPiyOIUekWxO6F57qFgbcyjes= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=tgzqhriU; spf=pass (imf09.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681536459; a=rsa-sha256; cv=none; b=KbUTmDZhW39qR6+KjnFfjaV70WS25rcGwMd14wxFRjqWRFBBLfJ3Eg6gq9GyYulQjh24ei EUesnk+yqzVt1roMcHq1z/gXaetESafURLRNFS2nWAO9Jg9du3yi/YbBjLnCqEfhJ4U8LB viZrkxwtkZeb63CDR/Q98orOs42GmIw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 46480601E3; Sat, 15 Apr 2023 05:27:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F3E2C433D2; Sat, 15 Apr 2023 05:27:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1681536457; bh=kZR8ns5F4Bcc2fBZdAJkdaZdvVij/HL8fonVpVxmF5o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tgzqhriUxI6WynT+M/ainvFueDAIE9XMhjUOpMUhaLqWyQ20KH4aBkrNQuS7emj8c Fsou7e2+b2D1W4taJQ8/uY1y/D6oLiBtxcOmIMBypROx5BrQgUyq+ZzEZM/YooxQXg rEEG9EQqNAPRQU/N7UGXUF+we+3k6HkxqotYRyuE= Date: Sat, 15 Apr 2023 07:27:34 +0200 From: Greg Kroah-Hartman To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Matthew Wilcox , David Hildenbrand , x86@kernel.org, linux-sgx@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Jarkko Sakkinen , "H . Peter Anvin" , Xinhui Pan , David Airlie , Daniel Vetter , Dimitri Sivanich , Arnd Bergmann , Paolo Bonzini Subject: Re: [PATCH 1/7] mm/gup: remove unused vmas parameter from get_user_pages() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 7796A14000E X-Stat-Signature: uaig4on9q9marj1cbt1gpa3mr5fidsn7 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681536459-442559 X-HE-Meta: U2FsdGVkX1/GOgdd8nGh9QvTutxehJZDjjf/Lj19M31QpOwbMRCj6ki6+KGL5IF8rE/iS9xdgzaZlZoi27bVkRxngpZSLjrIixEgTaHmF41d4wNKmyJXvRc4v6lpjTHQF/oYX0KRIZvQS2ge/JjOj7EEfPMNMa+JCZAe2rwfmQKiSnhfIPU6R6y/Ka8owH9c2rigdkreOKbAhf/2FF9cKYHgtKWh1pJgUusCTDzxS6EShWlah/zRgXWzDqlZ9fJKZulo4qO5Lchmv2NGUVIGJB8lJ/uJGHWxuiu9hnQCVZ4LAlq1SZYj1OUS2c+2JgQvUZBHfVCZCxkqe4NEvahFjNYs1xmChjMHzgdLTm0o+21T5JsbaI95fxQtItw5Iu+WbxiADcGDuEhEi3jhbnwUqxyVnN6XO45L6RzgYyZKg4HJNqMlDrChb4TPbGa+m0cJXIrFU6G97CYBHCym5jJLFPKXGKgywkMlpY58Y8m6Cbq6d3hM9DunupiLKyMQ6H6kCjDfHuKJ0Gi3SnxS1iEwaWjjMes76NswyOsaEv9UPLReLG9RSTTvxczQeqzcw8es/O9b9GLRVAQa7CfCZ/4osp67b1Bb1os0lftQcUKt9wBEOWjzE7pdJd+RHsl2F1va0zZuvwTJtreESFv9enJ3K0YTcSICW0ouPFg8JVgkXZ2C5aXrot7JXrnp1acAvtXM6cJanAN4SqoM54hvhOPIi0eZ5QbMQcdCVor4UylCotrXAKy6L9r9Y6XJ6CCTOFAG/daUVZbRklBfqUODxfHOiZls+bfRaJ5g/zTvbowWj5mRMjhmn7EcG+O+Kgh6tZ98gLW3zORr+ejrofLnE/z8VzGOm2mlUdPY7ERl/hoU+/HtH3DQr1xems8tzjvt8t6xl4cpq8NBVkquIIFih+uuc63qDLMxg09Llkl7rTIkjO4oJS5LPeUr3mb5o/Guh/xd4PNJ5tiwxsooIZtURH7 Jqn+lvzF LOdYc4ZGyIxsb0+MG+0INWBLNVbBLI0wOO0KKQsrjb7wRIth8pwFG8nGxoG9zIPIpsFbXGUoI4d9+L1Bywfq6HV/26XUvAjZ417ZFU7HqCGAUVAtfiISklStwByPShGzi4fnzYofNSWP+8v/+q1++AdbRgbCyQRd5O1W3xn4dUAVE0kkMROOLAMpMqAEW5jsmtVBa1bFuZjMMNXWd5b/P32jx0QyAFvrF/OBtavLrAQqkZcyapq7s7flUSEEO8oUBWgohD6MSbIVusLRq07fYcxpni4Kr6xYFYpxKZzAml1a2ZFHodudxe+0keWq+/Gx+QTu1cH5PrVzu0i2tAntKiI27m1Gud6McMBvJlzFGK9z+ZH/qEA/LHQEVrYyQfRMkcPixXRJMpY2FNucBw4TD9X7lG4lCactWLjy4AtO+7i8Xyx3K05kDpnUdPPVbDvQn16D/s1Csem13GRnIIu5IBmoK/yeqFWCQ8SVW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 15, 2023 at 12:27:13AM +0100, Lorenzo Stoakes wrote: > No invocation of get_user_pages() uses the vmas parameter, so remove > it. > > The GUP API is confusing and caveated. Recent changes have done much to > improve that, however there is more we can do. Exporting vmas is a prime > target as the caller has to be extremely careful to preclude their use > after the mmap_lock has expired or otherwise be left with dangling > pointers. > > Removing the vmas parameter focuses the GUP functions upon their primary > purpose - pinning (and outputting) pages as well as performing the actions > implied by the input flags. > > This is part of a patch series aiming to remove the vmas parameter > altogether. > > Signed-off-by: Lorenzo Stoakes > Suggested-by: Matthew Wilcox (Oracle) Acked-by: Greg Kroah-Hartman