From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C69AC77B72 for ; Fri, 14 Apr 2023 13:56:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D5CF900003; Fri, 14 Apr 2023 09:56:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48527900002; Fri, 14 Apr 2023 09:56:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34CF6900003; Fri, 14 Apr 2023 09:56:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 25C82900002 for ; Fri, 14 Apr 2023 09:56:17 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DB39E1602C2 for ; Fri, 14 Apr 2023 13:56:16 +0000 (UTC) X-FDA: 80680145952.08.0288A53 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id C5BE718000F for ; Fri, 14 Apr 2023 13:56:13 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BzIoWAeP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681480574; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8yn9oGKAtbnMyVx5qmj+QwSOhdyTGUCXsEIfV/06ERs=; b=jC7pZgLF2I1iu+O1Br3JfLazSf5W/z7Fr2bBe7X7+/aO6LWWeU1bdWSU4i7AQmm1bdLaID 8nZwOCAdFrnmMToqBWUNyog7ZJMZqAXEj4LPv4L6djSkC66IGp4RrJG09+H/LuXDshm0h/ YkmGbA1X7a39Re1MVpTp95WsoFMcYJA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BzIoWAeP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681480574; a=rsa-sha256; cv=none; b=gjB3GFn/FPCJEYlxwaXY8sEIZ0womssbSlSc/giqi2nEavGOh9GYSiqUgstBWWezMub6S6 waZiBIQzKLSy9Cq0zwnHknQLRcLtZj0NYrDePB1uaJdq62T50BmuSIhdr044rGfoL3X6lY cgLEqcx8utQPHIbjUTTv7S6LaZC8yz0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681480573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8yn9oGKAtbnMyVx5qmj+QwSOhdyTGUCXsEIfV/06ERs=; b=BzIoWAePGL2S8ZvpqbKR2oJDFBK31o+OXxd5gv6aJkYEZ/LlS0B9bPFyuO9iYYVQR21ttm hoLCqJ/0GAHO5fHyCuT4S6BXre9tO8Mm2Q8qD2vvw4avmIWSRFVWzq5HEzOt3v+pCkCCVE RPgKzOwRzDaqsYn6KAhvkCHKeyRwfB8= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-374-iCMe_DOxOjGbW7O4LjCSEw-1; Fri, 14 Apr 2023 09:56:12 -0400 X-MC-Unique: iCMe_DOxOjGbW7O4LjCSEw-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-3eab4df3ef0so1904781cf.0 for ; Fri, 14 Apr 2023 06:56:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681480570; x=1684072570; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8yn9oGKAtbnMyVx5qmj+QwSOhdyTGUCXsEIfV/06ERs=; b=Hzgb5Vf5hnc3l+l/KAe1NcOI1ArmXkvZsIZEfVm/rsw7LqevyAkUVYV57LM03v/cF5 aXfOrEyWvMFHHG70Nhze3xvUQr3HY+gpuPLdRju4Rqr2Lwg00xZHGkiFH7iZzRPEXuvZ xXk6aIKvOIQKVGYtY0mr74uXR2bFi7apjpZykZRFYtzdWQg8E9nzuBoU3WdB8HzOQrPj LiI5ZpqfFk8MUq7YbUgqBIqlP91KIXU7d5InGismJVSKQEREJ86GYeV/tcdwllp956CW BQH1Z6xK+uOTDi9mI5TW3VxhE+o7pPklG9GgTCr40d/uHxIamUF5qe4DvrWQbjHxzoCg /kTg== X-Gm-Message-State: AAQBX9eIDg9JLtahf/ZZgDDLgeC/sNwFRU4MgYi/P0sLa159xcmZOIvD oEYwy7X8i4YUNVE35VklPJ5/TUyuYQeaGwbqrsrRVYILWbpSfjbmFzhZZP1JwYaoRt2Yipc6gZ+ ZolzSYC8isjk= X-Received: by 2002:a05:6214:518c:b0:5e9:2bad:c920 with SMTP id kl12-20020a056214518c00b005e92badc920mr3648615qvb.5.1681480569712; Fri, 14 Apr 2023 06:56:09 -0700 (PDT) X-Google-Smtp-Source: AKy350Y6jSBHPtk3IeCHhEIAEgf1fn1u4H0MiWLW2uD7te0NluZlZxk71Oq4NrecPTy5dpOduS7tJg== X-Received: by 2002:a05:6214:518c:b0:5e9:2bad:c920 with SMTP id kl12-20020a056214518c00b005e92badc920mr3648582qvb.5.1681480569211; Fri, 14 Apr 2023 06:56:09 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id z11-20020a0cfecb000000b005ef5e68b4a0sm92193qvs.90.2023.04.14.06.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Apr 2023 06:56:08 -0700 (PDT) Date: Fri, 14 Apr 2023 09:56:07 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Axel Rasmussen , Andrew Morton , Mike Kravetz , Nadav Amit , Andrea Arcangeli Subject: Re: [PATCH 5/6] selftests/mm: Rename COW_EXTRA_LIBS to IOURING_EXTRA_LIBS Message-ID: References: <20230413231120.544685-1-peterx@redhat.com> <20230413231120.544685-6-peterx@redhat.com> <1a2544eb-7d42-eda3-fafa-9bed1377841d@redhat.com> MIME-Version: 1.0 In-Reply-To: <1a2544eb-7d42-eda3-fafa-9bed1377841d@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C5BE718000F X-Stat-Signature: n1f7mhbk1ddxe9qcggy67dky8g7uh4es X-HE-Tag: 1681480573-5763 X-HE-Meta: U2FsdGVkX1/smYTklZDoOfNaXNH892nbFDHJhDaDX+r5uYqjFHNqicWtEcHSdrJkH3AQKJEQCdOFi4QGhfer3OPpkQ9h2Bltg2YMOcQeL3uVscZG5d5w0wE5qnJYhNrG52+qlKupzcktQXhUMq0bJ5tSfXxGJnFmfIpVH1oKYIccc9sEjCd6HGaJ1O5RwMEHsbwqKwZAmvdPIigGC6oWWtikNjmCFbtvhZKBvYgGfAQgJiKdrsfLxsn8mv4esYwxX13oo/ZM9r6pK7xgMAy7PGTF/BFfOw3tuU3uRfu7BWZtMtZtNbUOCI+ZwPrZ9owNjGxcVQVIdQxEQAAUYV9rEPg79Un1ZTqSNGgxH50TiQ3FRdCl9lA5G36rOzfzgvLsR4fEBHLDPK4Zh8W0IrEZoCu+8M43H3umxfeY24S7TeVQ/3Bp/chnISTeZV+ErT4IQzNLo+PGusZwc3UZWdekzau8zG/szpSu5txWSK73caCiO0Ha4u7UAsW+hTY4PtLxdkQlNuPkLVH3yD/XB/elD5JTXHM4CSXGB1uBtCy83p/yyQTaAh0X5qiHNDAWlE77v8semS+vAnyXOaLAkP41wBy8XDleDOa7Xb+u2R+ueOYCFRrXFTobbRJ6/7CTXG7XDH/MRW8kytUOrGxTYH5zaMXvwK3I9/amBlTqKlT2qyj/rUtAOIAkrkLRRA94Ex7xG2e1ghsT4S/2djmvJ7UhMcyky+WcL0jSiRbhu29NyMbtUTiIa8QiyaWfoaZG3LrAtMN2NACCai6qEINSWYucsEpY86jtEJ0u5cl9uG97gkzjPRlPDJ8AQP86hmwLXREY8pobdfQgCdY20ocOyFdHQHm8TvNkhThADR+vk+b4RrqFfuJaACUd6RvPJv2qnEzicWq8HBvyvMOQ06F0ZpGWOYbUikcimH/DA4HpITn6DPTffTld5C0EBCemE24EF9Zv7X3V/totMwRqRFrKCSI FxgbFTv0 N6z5cYKrsq2RxBaX1HCRLHBlkfwiVzWdkXumY3/rx4/5AbnzJY5A3a0U3SI2c3Qib9M0L3zcpIlVe0pemvv6tfGcSHqzHfA0izy8nIEtNW/3wyB03LTnZ9gOlkfPNF6/KfFwONBXzeGJxncn/rwGWHN3ZcZ3ejAdQcPrhsCihN4Ng70aPGmm7+myehPzh37ruhhI9/Dl674kVHx7eTxaZr07yLA8uXVmbnMhCDvEW7NKyRbAU64PDvqPgbIla2NhqVBctfV5rzpRBEQmcAsQ490zvwqvDdfMpdlgYEvFRD8FaHUzf/qCULD7ddPO5/amSdz1CGQTc0Epy7YqIxMmw1iXezHzNjwoM1UaVe2osqwpkc1lCR5PtuMdVNrTIKhLfIgL7IO/GQgPtjqzJKC+hILmT8O3xK6yRk3B0thPDi1RC+KjuSWmcjPFhOt7bs4ldfJAo+i5wG34zprVhgXbwGfYz0ZopjZHhW5zH1st5+8HuvaygHBKiLjLJmIGd2ZyCO8rbmtYQQkxWp3w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 14, 2023 at 11:52:40AM +0200, David Hildenbrand wrote: > On 14.04.23 01:11, Peter Xu wrote: > > The macro and facility can be reused in other tests too. Make it general. > > > > Signed-off-by: Peter Xu > > --- > > tools/testing/selftests/mm/Makefile | 8 ++++---- > > tools/testing/selftests/mm/check_config.sh | 4 ++-- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > > index 5a3434419403..9ffce175d5e6 100644 > > --- a/tools/testing/selftests/mm/Makefile > > +++ b/tools/testing/selftests/mm/Makefile > > @@ -161,8 +161,8 @@ warn_32bit_failure: > > endif > > endif > > -# cow_EXTRA_LIBS may get set in local_config.mk, or it may be left empty. > > -$(OUTPUT)/cow: LDLIBS += $(COW_EXTRA_LIBS) > > +# IOURING_EXTRA_LIBS may get set in local_config.mk, or it may be left empty. > > +$(OUTPUT)/cow: LDLIBS += $(IOURING_EXTRA_LIBS) > > $(OUTPUT)/mlock-random-test $(OUTPUT)/memfd_secret: LDLIBS += -lcap > > @@ -175,11 +175,11 @@ local_config.mk local_config.h: check_config.sh > > EXTRA_CLEAN += local_config.mk local_config.h > > -ifeq ($(COW_EXTRA_LIBS),) > > +ifeq ($(IOURING_EXTRA_LIBS),) > > all: warn_missing_liburing > > warn_missing_liburing: > > @echo ; \ > > - echo "Warning: missing liburing support. Some COW tests will be skipped." ; \ > > + echo "Warning: missing liburing support. Some tests will be skipped." ; \ > > echo > > endif > > diff --git a/tools/testing/selftests/mm/check_config.sh b/tools/testing/selftests/mm/check_config.sh > > index bcba3af0acea..3954f4746161 100644 > > --- a/tools/testing/selftests/mm/check_config.sh > > +++ b/tools/testing/selftests/mm/check_config.sh > > @@ -21,11 +21,11 @@ $CC -c $tmpfile_c -o $tmpfile_o >/dev/null 2>&1 > > if [ -f $tmpfile_o ]; then > > echo "#define LOCAL_CONFIG_HAVE_LIBURING 1" > $OUTPUT_H_FILE > > - echo "COW_EXTRA_LIBS = -luring" > $OUTPUT_MKFILE > > + echo "IOURING_EXTRA_LIBS = -luring" > $OUTPUT_MKFILE > > else > > echo "// No liburing support found" > $OUTPUT_H_FILE > > echo "# No liburing support found, so:" > $OUTPUT_MKFILE > > - echo "COW_EXTRA_LIBS = " >> $OUTPUT_MKFILE > > + echo "IOURING_EXTRA_LIBS = " >> $OUTPUT_MKFILE > > fi > > rm ${tmpname}.* > > Reviewed-by: David Hildenbrand Oops, I planned to drop this patch but I forgot.. I was planning to use iouring but only later found that it cannot take RO pins so switched to gup_test per your cow test. Hence this patch is not needed anymore. But since it's already there and looks like still good to have.. let me keep it around with your R-b then. Thanks, -- Peter Xu