From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67895C77B6E for ; Fri, 14 Apr 2023 10:19:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B69196B0078; Fri, 14 Apr 2023 06:19:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B199E6B007B; Fri, 14 Apr 2023 06:19:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A07A1900002; Fri, 14 Apr 2023 06:19:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 909986B0078 for ; Fri, 14 Apr 2023 06:19:03 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 692874021C for ; Fri, 14 Apr 2023 10:19:03 +0000 (UTC) X-FDA: 80679598566.30.1526424 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id CDE6580005 for ; Fri, 14 Apr 2023 10:19:01 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf30.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681467541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yzZFV0fOuAVbmpX9ius/VX3GJ0mpcAwb4zJYj2UnoWw=; b=5iWV3mp23EImPI2I2+AAtat1gaHgdeI3Z1VmNvetotTR5BskFQ2x9k+Dbohn28qO8ApRy0 vjx+io4dL+lT0/Db12BsgHrhFqO8Us+8GwMa3oi3dGwaWBzKIIqqwrV/DrNMCURez4Log1 AEJ6aKr/3LPSmpgQ9XcNEdZeJXT2v/w= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf30.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681467541; a=rsa-sha256; cv=none; b=7Z/FSI6o8MOFxitKyd7jqkGrDcDri8elZLFxXE56AWYX3Vyg+qSex/bea30SzmuEv9zTR4 zSD/AG82tmgPXo0UB53mRTTB/tPkGAXBeW4VuAgYpa1AiJas53VYNkvBMcJf9fT8I9ibfT q5kPKGjySBl8Q7ZaGSPBD6hNA8AhqQ0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C991B60B59; Fri, 14 Apr 2023 10:19:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4066AC433EF; Fri, 14 Apr 2023 10:18:56 +0000 (UTC) Date: Fri, 14 Apr 2023 11:18:53 +0100 From: Catalin Marinas To: Luis Chamberlain Cc: david@redhat.com, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, petr.pavlu@suse.com, prarit@redhat.com, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, rafael@kernel.org, christophe.leroy@csgroup.eu, tglx@linutronix.de, peterz@infradead.org, song@kernel.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, jbaron@akamai.com, rick.p.edgecombe@intel.com Subject: Re: [PATCH v3 1/4] module: fix kmemleak annotations for non init ELF sections Message-ID: References: <20230414050836.1984746-1-mcgrof@kernel.org> <20230414050836.1984746-2-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230414050836.1984746-2-mcgrof@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CDE6580005 X-Stat-Signature: wj3orsafsznehbsu9usryui4dh5x1cje X-HE-Tag: 1681467541-561951 X-HE-Meta: U2FsdGVkX1+mb1k6WL7ub5MkoGZNMy6H3u2jE6GOJpVXMjg1UK0MbhVrn6Y7Gbx8y44vHCUVR8h0nZJcrFF1uvu2w71L/SfhtDHez2bQag7Llm6/xCLBQU/mKCUyBVIJF37QHeLlB6Zcpg1jdKDd2Kr9MX+pD/eXfmVEmCtUJgN0zo6QBiJFS+so9XdXIy97igzCa8OuJ5RmyrN+2mbYQ3fYxAN7mj3TeNkc5oFMmbzoyf55eRy8KeVSz9UH+oFFa3vJ/9oTCE4XwOZ9TnxCHfU3iTKGjc3a81xse0pi6/DhT6JCJJvsWgdibLorT8Gdf1sSomCdrgbhyVXn2S7NF8im9RcisRbctRHnVUDSDpX2UfEEK7OjbSmOkDiz6qb1qVqpPX8vJfPYss+1yUVk5HoZOuOQx9rTE6DFwM4fc9OQLh9HZoce0or2qg1zEXKOGWK0qtkHaO/lpI98gt9MJ+EYgnkNYGlNRC1OgHxO2rV55on2NakiCB6r3ePGHj+6Hgv27RtvMlbbp5C2tRH9h49mlAYKX1IPvBeaYANiFAqhgk+E0v4b5j9ZIykePYaOH5vI2PcHBbaHUli1s84/4Qhe9WcHmlMWbem0QkQIF7Y6cqoItl0bTxxiE3Pcsac4uPmazBWqb4qqMcY1dJVOEO1D/JMow6mhMHqVB0y9HbH5eYQ4ewPfsBPycpA6dSYZxjba0GDoXcD3Hs3UvE+bhuATNzl2JHPnELQ/lD9Y2hbE2HILtsOIyurG2XHB6Onh8qzDdBNaJd8ncz9Q4GwO79RVFvwHM8dNu1kOLji26ClXBUofvxAVpY9V1835knBPWacm/H8WD33dnIjbbN7NiQqlE3epaqh17Peh2BoSoLaOVhKqd2i0UM/iJW0g7RfXqXU7NBZJGSDD/MPX39Ga7pyMNh3ebYpFBWrdn9dofMvNfqzwKChiNqRO+2aLogkdfNbrmdXuDf4k8m5H9Vc keO7Ilvu 0QcSOzGVwZO+t48gk3GbJBzwJRBOEybJdUgIb4VV0e68Q84IaTtavdjT0lbTMoWbyiOOVg0RaIqn2yzHNLGftS+ZOXOF96zqmIBDd9xVJpBZjYN8HZc2tmo6pCG+d9sytbLIYRyllfmxA8fHHMnl9NnIBlDWr4PRGd7VXn8Sh2NwF3IO0PtslGx8Xhu1mrk507JuAuFhp/hZntVnzQOsSAwoX/AJUouT0OFEQcUCtg3KC/gbfuPPYgHjCgV0xoMJ1nXH3e8TNCtifaFz0eD0+7zYI4AgLE9aD7upXpRprUor/Cgc1SITkQyYYnCUS3QGCiCgjiC7thhV1EaNjb1f2GMLUhxQ5xxmF16erofi/xI/FY8Bcl9MRoZy1eLVACQo/5OOuuqVu47DAd0UEZdZ4bPje9R5bf2oSUr/PbxrJWr+5GwZ5nVnWtzO49R9c6vFZog0kcELT7mkbzDKZOV5SLM/T9GWA99ubpiZv9hgX1aVmbXgffqRzecR2JrA9padLxpyR7vSZfX/L/TDdoTTffvmCvvgg8gm4nFlnE9w8q6uYBPzug8OhRPTTgMC6FKMXCq4sQRkt//U4GuT7iTA1XmbyDYkMVT7nktb9MduJ0Ne7X0Ruo86N0DvZ/Wq6XV+OTEU9i63Q09/E1hs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 13, 2023 at 10:08:33PM -0700, Luis Chamberlain wrote: > Commit ac3b43283923 ("module: replace module_layout with module_memory") > reworked the way to handle memory allocations to make it clearer. But it > lost in translation how we handled kmemleak_ignore() or kmemleak_not_leak() > for different ELF sections. > > Fix this and clarify the comments a bit more. Contrary to the old way > of using kmemleak_ignore() for init.* ELF sections we stick now only to > kmemleak_not_leak() as per suggestion by Catalin Marinas so to avoid > any false positives and simplify the code. > > Fixes: ac3b43283923 ("module: replace module_layout with module_memory") > Reported-by: Jim Cromie > Acked-by: Song Liu > Suggested-by: Catalin Marinas > Signed-off-by: Luis Chamberlain Reviewed-by: Catalin Marinas