From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16115C77B6E for ; Fri, 14 Apr 2023 08:18:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 922A96B0072; Fri, 14 Apr 2023 04:18:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AC5F6B0075; Fri, 14 Apr 2023 04:18:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74BFC6B0078; Fri, 14 Apr 2023 04:18:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 60E686B0072 for ; Fri, 14 Apr 2023 04:18:25 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 338EEAAFED for ; Fri, 14 Apr 2023 08:18:25 +0000 (UTC) X-FDA: 80679294570.11.568E236 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf28.hostedemail.com (Postfix) with ESMTP id 6C089C0002 for ; Fri, 14 Apr 2023 08:18:23 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=G57bipcI; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681460303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w/B9WAykUhqtQERmWAVFwFjJ06AW3T330rZwJKMeXcU=; b=SjJB+1N3eHiztAuJmy/PIFUWQHnCtvsn9V1AHfSm1WGqLoRgJlxhRy6pQKokdnSp1QogwU DQoWRB/s+KTSeCI8QoW6McD+hmXx/oK0gA4ZYtfQX2/G4i2Rh0yclSiO05O/qgdGQUS4MB YUEogTYTBVOa59OegsKPlxy+Wbb4m3g= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=G57bipcI; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681460303; a=rsa-sha256; cv=none; b=HJatTgi5knLdrZk79JwVW4p2iMRRVhApQA563B+ClWIUwtHTC4dJeDeQ9DSOnb3vWOmSGL My2KX5p3k8PumxVilSwQKvOQlluBPUSOZGpOx3owdVlQQFziXtHK2Nwkp9XnmBFcFY37Z8 J3f0ZrjIw5pGaWv+eYQ8Dgv1iDgGPXQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 064131FD95; Fri, 14 Apr 2023 08:18:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1681460302; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w/B9WAykUhqtQERmWAVFwFjJ06AW3T330rZwJKMeXcU=; b=G57bipcII+Kcb1q489f/nDfnJopWEYGW9tFRQPr2xS51mPKO8t0gfoiMFB9cbBqrV/VP4L GQjhWrz7Lkx7gZUmJLDbala2k9t5YJNDCUFm4bVwmlRUVIYbjDiJB+pKm9Nz+qcv/cy3ST qQvYC8kHNowQKvp+URpi84Um104m3p0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DC183139FC; Fri, 14 Apr 2023 08:18:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YsoOM00MOWQMZAAAMHmgww (envelope-from ); Fri, 14 Apr 2023 08:18:21 +0000 Date: Fri, 14 Apr 2023 10:18:19 +0200 From: Michal Hocko To: Yosry Ahmed Cc: Andrew Morton , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , David Hildenbrand , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Yu Zhao , Dave Chinner , Tim Chen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 3/3] mm: vmscan: refactor updating current->reclaim_state Message-ID: References: <20230413104034.1086717-1-yosryahmed@google.com> <20230413104034.1086717-4-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230413104034.1086717-4-yosryahmed@google.com> X-Rspamd-Queue-Id: 6C089C0002 X-Stat-Signature: qskewq1yn4o61oz3chnacdhe4oqnwpju X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681460303-931726 X-HE-Meta: U2FsdGVkX18YRO2ERJXa83/c8ld6QSgpXsTW0a/UZtDRq9QqRWdattoIleNrWe/gygZmoI+SM93gvNrp/CF6sbVo1evndPs5KZtvW3cj2uRpjVxPxjf/EKE/oNxHl9we5j/hPSObtoj2GXYSZDHAq0UdVPCWaspYNjz84jM9+VkEYRbWwvwdBBP4zzYuJDs9C08JRhEfIMPrwQThwEGfXVPUJiHqyKuGZJHcZDLUmOJuSe/eMD5TTvpQzO9AuAQZRB2SnhVVmOgm52qtl4V8dmdyyuZElZ/j/mTH62OR29KA3vfgNDeaOyetviYlZ0v6avyHuqHzshNz+8ZdibgRSoSQ0gUtJj07JaaPeufiBauPiTy2r3D/ou69S6uMhcMWN+izjFgWqO0jT562DtD6otf7J7WHFilf9K2i0vIHnWox1d/n6ZHweaME13dqdzgd1NzRGMa8F1Z/WzutiOcMrdMsuMA76zVv5U1Z9gbv0A8uUFgTFEkLDulEmyLu/vBrhxNAb8aSh2zYwf/yTEm3YCDBy5s21BfITA+z4bhLgwGFpeNZmKA3bViYJZcJOo9znMyw+uoHr2//WdxxbSNG4FbYjxVXbT6i6Nu3clNFecfsWeN4jxC80wET0Zd+XxPh/bIArS4Jqqk+OKCMvXNUaWAUzC25sr7UMNaVfwF23mZMES7a2xocC51Qbs8jHS5XPrt4+0NtcuLWib3NH/6QQGVoRYDBCayMpj9YGBvi+AVLBzxAKLEqopT1ZYPSFdu4bxLtMhad67+0LGB/6SfmkmFj5kq/B/xOcJTfPyQDHX9Tyzx8c9cNBczOv/bSwb3TPMEbcrtU7N5mjYam/6Tya0OHnKb4paNzcM2wVPdlyqi0XecA3nL/tyOiyuRp8XF5/nOY9UipspKg+Nq0zxr3xlHRdfEkZiJFfi1EAuWWOjcBNdnP/w2v4KmTW/H+AdgQ87tB+gBzd25RgfKdRMz JNDBuAPp Lw0UM21xNLrJAYRMyRXJaBBr32goojeUsU8xzF1jCaTdwa5qUuLXsXV4RacxsPhsOTIWqTs4pcxHQFcBdU2TVWYLc7irCI9Xt5UD68NW39BTL7hj/sK71Teqetn/LQSXXOCF6O6NJ4lKsmyb2KwPHEgapZx2Ulcwu8e7AURts4UhigJZICEcrsbhcgxjQffiDXjGoEYcYXcMdrhqy4IxuIJ+L8u3RNX5FusB4lEcZ2xTuShIdS8yZRuWyqZSbOeVkPA2zE8yMP01bnfOfGVINtLR+erKK6hl+K7NZXX47npndCqM17WS/6raM9x0vW58CQNwEgQtKoBd759HgnHSabtLycMuis0FpphQpJ2Q/NwaPspQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 13-04-23 10:40:34, Yosry Ahmed wrote: > During reclaim, we keep track of pages reclaimed from other means than > LRU-based reclaim through scan_control->reclaim_state->reclaimed_slab, > which we stash a pointer to in current task_struct. > > However, we keep track of more than just reclaimed slab pages through > this. We also use it for clean file pages dropped through pruned inodes, > and xfs buffer pages freed. Rename reclaimed_slab to reclaimed, and add > a helper function that wraps updating it through current, so that future > changes to this logic are contained within include/linux/swap.h. > > Signed-off-by: Yosry Ahmed Acked-by: Michal Hocko -- Michal Hocko SUSE Labs