From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 280C6C77B70 for ; Fri, 14 Apr 2023 08:16:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B2B36B0072; Fri, 14 Apr 2023 04:16:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6624C900002; Fri, 14 Apr 2023 04:16:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52BBD6B0078; Fri, 14 Apr 2023 04:16:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 447156B0072 for ; Fri, 14 Apr 2023 04:16:14 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1ADE98019F for ; Fri, 14 Apr 2023 08:16:14 +0000 (UTC) X-FDA: 80679289068.01.4DB079E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf04.hostedemail.com (Postfix) with ESMTP id 434284000F for ; Fri, 14 Apr 2023 08:16:11 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=cSbVGACM; spf=pass (imf04.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681460172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AcyGnHXf1H55h8xNhp8GjpAGA7SaHNrd2EolJsHcuyg=; b=AOjqyTVj1jluZT5qWMvuZZ8gjxFW8FkSj+grWK7LlBV7Q9nRnE9+5Mvk8Lma+hxWMBLs/h UMXtxjgV7sYEMM4G/KOFJu+Bj1DQjlmYoNxVy/2Ig+Fhqn52cMM/m0kx3O4bB4lOZqZp2W vtGICIbfhwL39JhljZnEWujI2NEU/yU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=cSbVGACM; spf=pass (imf04.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681460172; a=rsa-sha256; cv=none; b=DXWPqoidDpGJzIWF7Y5KK7+bLqPXuDo3K+C7SJ5nk2uvakQ1zkG32PJDCY1+Zvvkunwq0x 8DfxBkrxvjqJHW53mWjnG+e2B1rmuAWfxgGrb/kZygqs06PlpkjwUJYiVeRJyfojUazVHJ i4S1fB++yJJXXmqAwKc+umZ66YB11lM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 06A211FD93; Fri, 14 Apr 2023 08:16:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1681460171; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AcyGnHXf1H55h8xNhp8GjpAGA7SaHNrd2EolJsHcuyg=; b=cSbVGACM8ZaPvQjq6uwolfJvnBYOFaHNzFjpdiTFjrV73eAX32W+zTksofPpahr0D05PJW 0+Em3r5KZQdq7pJX6XekpPMEemB6a6s+gxGFJK4WA9nVmSf6L1g228aGHsc7gbpfS2dxF2 rkRaldFuAbbzp0jy++YxPJZNaJUZTF4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DEDEC139FC; Fri, 14 Apr 2023 08:16:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ODQSNMoLOWQVYwAAMHmgww (envelope-from ); Fri, 14 Apr 2023 08:16:10 +0000 Date: Fri, 14 Apr 2023 10:16:07 +0200 From: Michal Hocko To: Yosry Ahmed Cc: Andrew Morton , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , David Hildenbrand , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Yu Zhao , Dave Chinner , Tim Chen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 2/3] mm: vmscan: move set_task_reclaim_state() near flush_reclaim_state() Message-ID: References: <20230413104034.1086717-1-yosryahmed@google.com> <20230413104034.1086717-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230413104034.1086717-3-yosryahmed@google.com> X-Stat-Signature: k6ruoeo898izys4jttkg1hmgsma4xurj X-Rspam-User: X-Rspamd-Queue-Id: 434284000F X-Rspamd-Server: rspam06 X-HE-Tag: 1681460171-179167 X-HE-Meta: U2FsdGVkX1+VrbT1SpY3bvdMb3XT2sbMP0jrDVGnkjOm8c6RtJ9YrKJ2H5Q+Rl89uLv2GtOEtpn0jmzQiy3r+kKW0Y2zBqArXKtVpiWKnavoS7if7LO2oVerWvfWgW79LhkAcYBkbJEByKR+sDXMJU35sqDMjE4us5M0LrmaT0kwHKjD1FtuKoJ8i+1uBx2Exew0NvGG9zjZ5Qe23pZ9vUwkRzA7E3tHzzDejBzqx4HTOKC45gVJ60RZni++5oxl65zhUoDfGbG9+DawjsEhgoAHcHrvA9yXVmuFvUZIunszY9EOWHxMKHE+JXSqne/PHfEWIH/OE1fFpfM1U5GqVfZ/wSF1t4j9/tf9xWg8qJ9Bi61Wl1O7p0wp+7IabFTokuYYHgKuvz93eSLi3BZu9b+fmFx2GUWfdpXWUM5p52/tagI26tiBOtOPxnkQNKGMNxlsCKhK7emvSkjbfXi0xeJXUNAU/4WrhF2cEj3xT3KRdsGW9+kZRSV1DvkzyG0vz/X+jaVLBtOIP0hKfAhL3VFSZb3dUnWkofgEkXlS7M6KLiIQNN7xHOF6lg5xFl345q/0GRr7FYUZum2kJtaCdG3c9JOsP8l6tDM+pMmYEWZUkQjjxU9rt2zdccK8klWJK1KiLpEkdqOiLbt+Rzkz3J1+sp2ys1P8HWts/FvNjQCEDx+gKcWOaS/x/OX40OIidRLG0PdzGE71uxfWhNkgfbvzvof6j5L9oqBrMiqL5JC3arPjC3aEe/hVH8qz62My5vb6FbSBNhhKgAhgJnZ0FOO7CpKmkjq3WT2lCw1z7QxH0vPHJvWh8BUg2DY3wA3guuD6T8ZLJ7exUwT4VmANFUXvmowrZ1WvRWrAQOE/VrLip/oJBDVorguUIc3O21Fc4x5k7bCllGRVanQFU6e4gt4lgO8JNVwXIeC02nEjAv0nXQZRdlhi9TcqEU87BMzadhY6KEYNy9cKPpnQl/A /9VKSAp9 MOeuYnpssAN0O1i+LvaGUc45jQARPMXXQbpsx9UJ85Dt2j4ZXm5TSJGjaQV7PfQI+0kJQH4I4FuWGeZpaML5pWOZGhsUrlzxlbjLQD/k74plsPYXm2TtnI9ga98cqGd3z1pm/tcjsogfKxtHbJoCE5Gb3fgsPXHZuzszx1u2uZCYWzopOOpMDvk21/v4wEhejHniYkTKccGymh69smT4jl20nPO2sinQxPzhTa+ZjzOw9g1hf+VYUmjk/J46tRGjanHGIN3ugpQwBvmTJgusjKMD0JgJWnXDB1D5LRXamOJpfudv0XHhwNQITw7zx/D92gi15mSif854mJj8rsm6uiLZulPKkpDLohHVNms3uB+yHt0o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 13-04-23 10:40:33, Yosry Ahmed wrote: > Move set_task_reclaim_state() near flush_reclaim_state() so that all > helpers manipulating reclaim_state are in close proximity. > > Signed-off-by: Yosry Ahmed Acked-by: Michal Hocko -- Michal Hocko SUSE Labs