From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 752E0C77B6E for ; Fri, 14 Apr 2023 06:36:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB54B6B0072; Fri, 14 Apr 2023 02:36:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D6513900002; Fri, 14 Apr 2023 02:36:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2C9B6B0078; Fri, 14 Apr 2023 02:36:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B0F346B0072 for ; Fri, 14 Apr 2023 02:36:01 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 75BBCC0165 for ; Fri, 14 Apr 2023 06:36:01 +0000 (UTC) X-FDA: 80679036522.03.EA09EBC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id B32CC1C000B for ; Fri, 14 Apr 2023 06:35:59 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=uqnmZUG7; spf=pass (imf20.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681454159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J+VBt64EBgHQFpSeF0i/IGkW8Oe0jEP58d9M7HrD+Ug=; b=lfQu6W7Z/3aKdshOGkEAaHCajQTOdfoa7zGf8z21QnzGxQKHCiuD6Xoyr1mgE1etWVgxqh fiYfSkBC9J6UCLV9P7jLzBwyfJsqbb5u3dnJupsOLtpX174nRaDEbgA4jSG5KqTzWySkNV B3zYyoQqSMtl/EAbmaU68IwLoiH8WMg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=uqnmZUG7; spf=pass (imf20.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681454159; a=rsa-sha256; cv=none; b=jN5hET0jwqwHZaMm2Z/2JRCZEMhLuF9AXfHXc14opQzLZgvOOIEkTTC3Ti6RIPy4TaKSiR pVBPwK2ib5YHmQfWcBXBjE1ceqqahRggAsAIT9zdcBNnMm3ov4go8afsDIiJ0da6+5NRgU pVH/4Xocigw/FQhVZGtXIdbONXciyVw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9D2906449C; Fri, 14 Apr 2023 06:35:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61DEFC433EF; Fri, 14 Apr 2023 06:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1681454157; bh=+Yp7RZWfuDeZqFhwRrrTAzpa2PNfsGknk0RMVV2+zIg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uqnmZUG7Zox6U9sbFwAS1zMLed9wKPDZRUtXGdg2a24IJWiqmlO3aKqrvU8oYgfAd pdT3hmHcCPq1rH6MOidIq8tFOB1mYepA9j00Ascyd1Xt3K3nz5YNQcYRRJPst5N5vH puDsuKpLBUBrG4T4ZOeisfXrR9qmBdkZuO4HRtPA= Date: Fri, 14 Apr 2023 08:35:53 +0200 From: Greg KH To: Luis Chamberlain Cc: david@redhat.com, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, petr.pavlu@suse.com, prarit@redhat.com, torvalds@linux-foundation.org, rafael@kernel.org, christophe.leroy@csgroup.eu, tglx@linutronix.de, peterz@infradead.org, song@kernel.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com Subject: Re: [RFC 2/2] kread: avoid duplicates Message-ID: References: <20230414052840.1994456-1-mcgrof@kernel.org> <20230414052840.1994456-3-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230414052840.1994456-3-mcgrof@kernel.org> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B32CC1C000B X-Rspam-User: X-Stat-Signature: ueop77k1qdhph6j4t6qdjjw9in98eqpr X-HE-Tag: 1681454159-279570 X-HE-Meta: U2FsdGVkX1/Smu1dzat2wwDWanOs4gLG87A6OHmQz7I5YAfOllxfa70MwkzvUucKsgnsxeVdAsN6Uu8CUAEJAZ2p3iRlvXkZyXNdX9CEKsY2DV1kY3almpTnuENJpX+yGVMmRBCc1IEG6O0V9vHIxldjevumMrEKp4uzdHqASWqkteMreO710DbExYs/GTJVeAS884YkcH0Qx4mAuq8MB/FSa2UvTio9KvJZIUw0RnUpUX0gmEqGsdeb3mvtmVtBQihDaxzHaDREOasyIVQvGc7cxFCb6lpeD8Q0FRzabFCVtP6swzHVJ6mKW970yP/d3naoUAU34ZwD3bvS6xur2HcnP0TXV2jPU4nHN0zng+fNKOJlaNm/g/ZL34/tg8ifIEhC6lp3m0VNb3H6GtBj0qKMBO6UFQcIv5EjAk+FXEbTexNElXgCFug6oNP6r3pgM5ePm3MbSySUlx1CytA3MNjoG7vkkXCG0gqKWFXhz2u40RPom4BQRGDW1PLIkQFfQe72LoMA+1eyPni/9HEz3648wGwurtIH3K3SFAbUQbfAogfNQs8as5C/F1Hk426XAsXBxi5034IxP7C/I1BeStYQjkdNgr3oRIcNIxbl99Ld8QjXfHiHvpLWy4FlDIHEHiIcaTPCal+yI6F0gYr1T8khkoFP6/Ya5eNyXbDe/k/Gj4qMNW6oPWgyZr2UT/kipop/ChCwAmugP2kpwor7SDg6y2czBP/uqENivDWygXUuJ23A5ff/i3g1RoVm32rL90F48y+SlTNxMf1TX4HNFKLeCdO8Wmku1Hwwb5VIatwJjX7HIbdityKqRt4SEH9fPMggp1pgghrbLwKyi8Sf3RbEGJTXgBJg6R8VotEsfMi8a+d6dbPZNmQTFdTgxy0tBpbgiis8AwqD/OCprMvyONwIorGAzTEuHQQcTQE8Kj7XwsM5rrzNOLTTk208veqO6vFhLmHG2svUn763ppL IwsqN38c NeS57C9eWGzS9zv3SNMkfJcHQoaVMNPW3cLgdQYR0pZwuyfS5RpQYx77kCgy58VXXNTeDpc5TK6XoLTdqQqlSiR03er62/OJkjnPBzrtCtKp61QhlrZFDPqfTC2gOsEURnV7wEK2tKLr7s59NnYr2/LlwRafHhGV0IWopGPYkvnqfkCQXDpQaSU0R02k3L/gtmiA1uySOSJXJ2Y3g1V/uHyLD9j8qvT96+nmhYwjEosUkUskZWk3UB9YNB3ympHLw1oRodB6+zNqz5chsNPdgrkb4GULpy1f7mL8/BxQ41G0yju/1Sf8D8OecIb4fI2QEfdhTr7P4M8rn1/h53qIGQI1iaBkvFjVMrkMgHAUMA7ijS94= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 13, 2023 at 10:28:40PM -0700, Luis Chamberlain wrote: > With this we run into 0 wasted virtual memory bytes. This changelog does not make any sense at all, sorry. What are you doing here and why? > > Signed-off-by: Luis Chamberlain > --- > fs/kernel_read_file.c | 150 ++++++++++++++++++++++++++++++++++++++++++ > kernel/module/main.c | 6 +- > 2 files changed, 154 insertions(+), 2 deletions(-) > > diff --git a/fs/kernel_read_file.c b/fs/kernel_read_file.c > index 5d826274570c..209c56764442 100644 > --- a/fs/kernel_read_file.c > +++ b/fs/kernel_read_file.c > @@ -4,6 +4,7 @@ > #include > #include > #include > +#include > > /** > * kernel_read_file() - read file contents into a kernel buffer > @@ -171,17 +172,166 @@ ssize_t kernel_read_file_from_path_initns(const char *path, loff_t offset, > } > EXPORT_SYMBOL_GPL(kernel_read_file_from_path_initns); > > +DEFINE_MUTEX(kread_dup_mutex); static? I stopped reading here :) thanks, greg k-h