From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC35C77B78 for ; Thu, 13 Apr 2023 14:14:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F01476B0072; Thu, 13 Apr 2023 10:14:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED967900003; Thu, 13 Apr 2023 10:14:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D79C6900002; Thu, 13 Apr 2023 10:14:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C63EB6B0072 for ; Thu, 13 Apr 2023 10:14:47 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6412D1C5B3B for ; Thu, 13 Apr 2023 14:14:47 +0000 (UTC) X-FDA: 80676563814.15.C3B5908 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 6D4E1A0017 for ; Thu, 13 Apr 2023 14:14:43 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf15.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681395283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K8Xp8/10Q92bDICwHbvc86vpZdIufpZjmPKC79E8wAE=; b=MgoRGBjz1wCplSqcYamU9ZTCscr/OEtVUVGeTHAy02gIGYnpMTvdGSgXeL6kekyNgEQCmF 5JP4j0U0++19/ZOqp00eNJZfRrF+pmfaZr9wMye4jwSBXa3/M9K9SKEycwe7/Vc3H3RMJ3 lJv5L9dFvqAN92tAcHCgsmdrI9vFNt0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf15.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681395283; a=rsa-sha256; cv=none; b=EHrw+UqPKcKXrtEGYAB1hKoFLqdec2GxuXiRID00lO8efcplWorhXXkifklN8FsKToYhRV PsGutN/hEi3poclpe6O5jRjIXRR2/KhtLOmUzefPasIcji0+gS0Kzjb5mJwBMG8k7SEuKR MHTRpYWaLLGqcaQtfjFnsc1m1WL1q+o= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 652DD63EE0; Thu, 13 Apr 2023 14:14:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76A3DC433EF; Thu, 13 Apr 2023 14:14:37 +0000 (UTC) Date: Thu, 13 Apr 2023 15:14:34 +0100 From: Catalin Marinas To: Marco Elver Cc: Andrew Morton , Peter Zijlstra , Jakub Jelinek , linux-toolchains@vger.kernel.org, Alexander Potapenko , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Kees Cook , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kbuild@vger.kernel.org, linux-hardening@vger.kernel.org, Linux Kernel Functional Testing , Naresh Kamboju Subject: Re: [PATCH v5 1/4] kasan: Emit different calls for instrumentable memintrinsics Message-ID: References: <20230224085942.1791837-1-elver@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230224085942.1791837-1-elver@google.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6D4E1A0017 X-Stat-Signature: cgt66nxxyzf3oi46ra9ci5srdb9ofydj X-Rspam-User: X-HE-Tag: 1681395283-507205 X-HE-Meta: U2FsdGVkX19Q2IlHBW15IUyshS0uLgjXL5Hsou5vaQU2+PYL0zwCtLBtKklkxTP8pVAWxO7yac3D2JdCcXCj1hmc3kSMibLuqiu5QavQAnh/QfKQJpV14/ejUSrK6eJWmzS4nd0ZhHyL2hOjypD/9NX+OMGLj/pQ/KeIF886aGSu8RD1znaKdKgczXa3sWjVMw9nL6fKCT1Xrheg/sVC1qzpLF9JnNkcNfvKjnFbvtxSNJUwr9O06uM+SoHkrEhtblHiJBnP+ZHdkqaEtN6kxwZrLKXtpPKo2Ozx7vk4Cow3FmZ4+HoJT+M/nyeZ+93em9tw4DYxSr2iDUxd/RUNFe5kJjOh55kxbj3HbHlz8OcMqiTxRo/fs+7/HnemVtnpIRZs41pD68jdqpaiPZO223DodVteQP8pOtDNqygVeoPthIBb6cvUEj7hbGKlSFjcBUOq639e1CyDkUSpVxlTNW16/OEDH1KXg4E9bK9DgnEhVWOLYQfoipbI1BFpCMYuYYN9H5Q2zyzHwAAxIs0YKHFx1pngGrvvqZn//mH2f77X4RmOODSVqqIlmkF5IFfe5373wOnpZcVFnjG0zY/9kQ3Pe9grUvQ/BAPpzQ1pl1Hs2I/j0F3SveUVQNRn2vmdnvw9t/VIf7JpUBEPlOhunLfc9yd/Ygl8lPvB0tcd/Ynv1RzdWtP5VNn77M9Hu4I4+PKCWPQfme5gRt6XoIF074BkUplERj0y5W5pUY/8rkN1DC63vFUQLF3y+m4t7dYQVbC3gChq+pF3uceroXsCSK6o+FCWjxtAXzrtei5O9DS2UGPXTCN0yyhciRzCQeUOA1Aypgk2XxmH5jCRQJiNsngBojmNWsTI/GHYhgWviQDugW9lMAi77oGS1grcJikiNFBTppT1SAm4D3w9HWAmF8Gbh2mXoMIpP25X4YZf0/KPrlEahdbd4IrP1Sgj2WbWuj3SUGhvSf+gj1PbhHP KsP8PXv4 rhBg8AZTQuDHJbfhCb5uEiYXY6ZO51eV06S1hqBuVN5WzmAbouUM0NsFla0bytwcf+khrysEwUOfLhSNmZxaV40E7T4rgukS0GkcCPi9omMmyBi+RibQ/WyNh3caWbQCmeHVnW3YG4KuCymA0hiv/UKsrRuQrcDu1dbe0qSgBGQXOextm6LwbkcRb2ftHiee4szKHDDgb5TbuLhRtm4836j903qGJeP+e/n522wJiV3Tc6tfbXAvCCQl6o08IrW1fNCvvL5/N19EJCGv1wGxLnxLWIbgib0Ro8orzjjab/Qz3CV9qOrysbyHu46RhP+ghoCQU4ga9gPe76rjVTtlKYUbVflkwSxx6Bdy12m07xsWqvoVxY+3wAfXNKGPs/G/i6iif/AcVMHqzAY3hlXeYhSRMVi0nJtGYiGhFAh1LrIDMa0eN2b7DwKQxrDCgxfGCnF4i8LhhzXY4lN7hvakC3x5U9bpx0a4PNvl7u7gjBE716J4fM3InV5oDWqAU7LxWh56l8UOI3KsLwyrAoINqjnv8ws72wS3D8iyZL3FQiBH+dl8NMHjOpKlvFDxFcg49bu2+H4Vd8fLEdfHo2fVbpmKAMxnvJykS5Up9HRU2TiFBj9OMDCn3JELKsqT/Vb/d1hVkk1l1isgtU8Yxz6eZZ05JiTOcBcNKwmqNjs7txdp9YL8+odd0Z6EeyR3x0cJ7xta3bgn8iy+ywMXOWt3NacutPF+Sb9MQB0pNId1rTcd04PEw8jkdlSZ2+vJFmvlMz4gfmgO9lDq4sOVFzKl9qHn3elti1bVHplNz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Marco, On Fri, Feb 24, 2023 at 09:59:39AM +0100, Marco Elver wrote: > Clang 15 provides an option to prefix memcpy/memset/memmove calls with > __asan_/__hwasan_ in instrumented functions: https://reviews.llvm.org/D122724 > > GCC will add support in future: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108777 > > Use it to regain KASAN instrumentation of memcpy/memset/memmove on > architectures that require noinstr to be really free from instrumented > mem*() functions (all GENERIC_ENTRY architectures). > > Fixes: 69d4c0d32186 ("entry, kasan, x86: Disallow overriding mem*() functions") > Signed-off-by: Marco Elver > Acked-by: Peter Zijlstra (Intel) > Reviewed-by: Andrey Konovalov > Tested-by: Linux Kernel Functional Testing > Tested-by: Naresh Kamboju [...] > diff --git a/scripts/Makefile.kasan b/scripts/Makefile.kasan > index b9e94c5e7097..fa9f836f8039 100644 > --- a/scripts/Makefile.kasan > +++ b/scripts/Makefile.kasan > @@ -38,6 +38,11 @@ endif > > CFLAGS_KASAN += $(call cc-param,asan-stack=$(stack_enable)) > > +# Instrument memcpy/memset/memmove calls by using instrumented __asan_mem*() > +# instead. With compilers that don't support this option, compiler-inserted > +# memintrinsics won't be checked by KASAN on GENERIC_ENTRY architectures. > +CFLAGS_KASAN += $(call cc-param,asan-kernel-mem-intrinsic-prefix=1) > + > endif # CONFIG_KASAN_GENERIC > > ifdef CONFIG_KASAN_SW_TAGS > @@ -54,6 +59,9 @@ CFLAGS_KASAN := -fsanitize=kernel-hwaddress \ > $(call cc-param,hwasan-inline-all-checks=0) \ > $(instrumentation_flags) > > +# Instrument memcpy/memset/memmove calls by using instrumented __hwasan_mem*(). > +CFLAGS_KASAN += $(call cc-param,hwasan-kernel-mem-intrinsic-prefix=1) This patch breaks the arm64 kernel builds with KASAN_SW_TAGS enabled and clang prior to version 15. Those prior clang versions don't like the '-mllvm -hwasan-kernel-mem-intrinsic-prefix=1' option, end up printing the help text instead of generating the object. Do we need some combination of cc-option and cc-param? Or at least disable this instrumentation if earlier clang versions are used. It's already in mainline as commit 51287dcb00cc715c27bf6a6b4dbd431621c5b65a. Thanks. -- Catalin