From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB8F5C77B6E for ; Wed, 12 Apr 2023 11:51:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19C1E900002; Wed, 12 Apr 2023 07:51:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 128906B0075; Wed, 12 Apr 2023 07:51:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0906900002; Wed, 12 Apr 2023 07:51:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DC8C96B0074 for ; Wed, 12 Apr 2023 07:51:17 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8E38216012E for ; Wed, 12 Apr 2023 11:51:17 +0000 (UTC) X-FDA: 80672573394.12.8A9E57E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf21.hostedemail.com (Postfix) with ESMTP id BC1091C0008 for ; Wed, 12 Apr 2023 11:51:14 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=tj9RiEfF; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681300275; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1Ja8WfyqHG8SWsn6zQcE3DA6xHw8zgmqdkFLfVd1nao=; b=rpEuYr76Ez6WP4QKUsnH9sCNQMXIcSpCdzqV/AmrfpRxCw/hoXnLl7WnyY5eubxP0giE2x pCbdy69dmia8uHYWGG99/Nov9V4EYet+JglvbhH9vmN/CYbgXZ7NbtUDpFUJw9DHZ15+PA u4Wvh/Hi7+exfwGvN7+/kyPl6bMUe18= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=tj9RiEfF; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681300275; a=rsa-sha256; cv=none; b=tSKwODdqmG2xWByHppSWF6DSv47T24bNuy/V/TQ0O+jelomctYg5O6yPf2BP7RNtkdEPWI LoJcaz/2R9rvfkiEExd3V30B4efYRm4L/Wi24AyITXXEjEaGn63FJj7xGrUDyne6OSKajf a9BmVnObG4W7yJbK59w33s8uXDrYuaM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2090C1F890; Wed, 12 Apr 2023 11:51:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1681300273; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1Ja8WfyqHG8SWsn6zQcE3DA6xHw8zgmqdkFLfVd1nao=; b=tj9RiEfFRgbjaA9JmzsqO4x/V60MF6VLKzGIqS6XajSnbTsXJ7c2z4Pk0jpEXOl0YnupOS nq7LTOrycoLteJejYRhoTbuGnpE0IluZkIG6IV9JG/OWBOCC7JbMoK/QRVcLLn6lO1HoAI 4s21ECcJc0DO47X+sQklSGnIwO1o/BE= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F27FC13498; Wed, 12 Apr 2023 11:51:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /I5NODCbNmQ8QwAAMHmgww (envelope-from ); Wed, 12 Apr 2023 11:51:12 +0000 Date: Wed, 12 Apr 2023 13:51:12 +0200 From: Michal Hocko To: Jaewon Kim Cc: "jstultz@google.com" , "tjmercier@google.com" , "sumit.semwal@linaro.org" , "daniel.vetter@ffwll.ch" , "akpm@linux-foundation.org" , "hannes@cmpxchg.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "jaewon31.kim@gmail.com" Subject: Re: [PATCH v3] dma-buf/heaps: system_heap: avoid too much allocation Message-ID: References: <20230410073228.23043-1-jaewon31.kim@samsung.com> <20230412085726epcms1p7d2bec2526e47bd10a3b6ea6a113c9cc3@epcms1p7> <20230412094440epcms1p445319579ead0d0576bb616ebb07501b4@epcms1p4> <20230412113759epcms1p8cb15b54e3a96c7616419cb030d16f804@epcms1p8> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230412113759epcms1p8cb15b54e3a96c7616419cb030d16f804@epcms1p8> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BC1091C0008 X-Rspam-User: X-Stat-Signature: tdh6emp3onou8mryfcqmhpcb4eaem4oe X-HE-Tag: 1681300274-760306 X-HE-Meta: U2FsdGVkX1+diQBdCRuigzro3vB+ZNVzjKxf+Nj8Fo9Uo0/nMDnd9teELTfCuGhnIpshu5N29fAZK45viJDESNqsF6oVX2e6bQjKNt5vJG9knRvYZ+ck6qjTmX8VxKcSPdf5Z9rtYbq1wh5FIq/HUtYyQ74pKR6xnV98CCI/XcNcDtUsc3Fy1zzJENZnroABEnU62YT3i76t9c41KpAMGsZvE2MiB2U3OhUbx/32SkvTMzLMrcSYT7fWA3lPxmUoHUGDTfLiYns720t0KXH9cRdXqXW6UG+7oipl3MkLRxIHJwT3cHF/kqQMiKQYCpMRle4OnCMLKQEoKra1LibDtUDuneLFXKtb8mmLY084wYlCdKtD06eSPZuTxK/Asv93GrpNw0FS5LPC6leDsTUr5+X4CUG5g3rDGRleiKNcbO/OEoyjK3S9iZHwx3jbYdUDvOn0pcj4Y0LvuMMYoSlJRjOYg4PbEUj7/T51wbpJO5T+q98Rm0kBe6s3mY6fjrDklKCKliNve/5hWNVqeXDxm7ss7VMbQZ5U/O/acJeQ4ZJrU6UHUWtwCEsCxbM/8I/0OF4FUH9a3G8dDF+kPXxLTB+2qLzKQCeejyJRi+30W9fCtca+JT1rPDIkhaGX8pbQsE0VmP7cTSPLBo3amnWnivtWzKUreXhXfjq5usFz6MOaL0OU8ccPysV5kF8KuVrtKYjxdxXl8QeneD23soC6Zh1wfVrAaBlYFTVD1OdFD4cp8Jperm4UnYcBAVERBiPWN0V58xJkjzV4+s3DPJmfPFBT4a1zPGGF5KzteTfQg0OJGe9BhG1euL3B9DLU2Jvpv8Kt4NlP+P6v368+GgU1XM1nbOnrqF7DZz/fvqqcljZYaDN+hSb53CC7B2YVaiMNUIwHnI4+2qRQ3l8m9ul3F3YwYMD/CHekLzvV080NKSarreo2uzdmg1IHnSZDJf4/ITSYAzMUYr1313BavcZ cfJFAyte YVdnt9PKXjL4H+2/92r9/suT4sMIzImvrYPxHQEHdnB5Cc/XdZQxKLfHLnBjphj6n1uxcMpjvomVlp5ZyUXLhYHeXQLkihtmpLzPx95iHX2dKuUHhrC2hORVLRo/ACvE7YLyez3EMFChq+MNvZ0haxafUsF8w46tHmMmJ8RGgPYz166CrTFywVRNkwA8wwTJ1/llrBOp92xQ49qDd3UgVu+617btOaBvXso4ps4m8UJgnAft2LrTZBGQ3VnCmQwRzxUzJFgvPja3PiZ+nV1DkovX3GAvF216VSphJVMTyy2XeydrG4yI1NzGCbb+sNSL5PRw+Pt8A3XjrOGs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 12-04-23 20:37:59, Jaewon Kim wrote: > Limiting dmabuf memory may be required. But I think there > is no nice and reasonable way so far. If that is really the way then the patch doesn't really add a big benefit. It doesn't really prevent OOMs (or panics due to OOM) as the allocator still allows to consume arbitrary amount of memory. The provided check is not able to tell between buggy and legit calls. -- Michal Hocko SUSE Labs