From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4218DC7619A for ; Tue, 11 Apr 2023 22:35:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73197900004; Tue, 11 Apr 2023 18:35:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E1B4900002; Tue, 11 Apr 2023 18:35:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D0A7900004; Tue, 11 Apr 2023 18:35:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4C768900002 for ; Tue, 11 Apr 2023 18:35:21 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1B8DDA0C7A for ; Tue, 11 Apr 2023 22:35:21 +0000 (UTC) X-FDA: 80670567642.16.D322575 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 5EE4C2000F for ; Tue, 11 Apr 2023 22:35:17 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=trljD5An; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681252519; a=rsa-sha256; cv=none; b=VhNa0me+njC5W0F/UNmUAc8ZAPnrfP0R7vTcHnYWfBBwpkpLe4LUTjUFd17yDdRMypNnIJ BNVivLSouV3CX+7mYys0imrF63DzgesT1wm+Z8kQN4f88vam1CR6AZfFBmXxXT9iY/0kWk MeFeeCRgQu2oEB2R0zVQ1d1O6r2w500= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=trljD5An; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681252519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mOKj0sEUbMW81iFF7BRNN9qJS2IsOHAMM37QMSPbQxY=; b=ybB3E+kHSsISRkx7hIqInhxBBJpVuICdb0S+aagoPRDmDkVzPR4afXSztwEHxGgNpGuuKD nCdLsKY96hpV7JlwY/3LowGMujIGJ8mDGfHdogZ2yhsr+0sTn4Rhzi7OJhr+bsFD7ua/wz 8qUCBUwHccI1SeJk7fX6SlyAmlMiC68= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mOKj0sEUbMW81iFF7BRNN9qJS2IsOHAMM37QMSPbQxY=; b=trljD5An7/m416tJi0yAZXbq8z zjJMpYJVtqv4fZBIASEZly7rmCqIDeC6XfO6JHesXL53KE9rpV7wcq5/J8T8gRpgbiC0z0XKYPtA6 X5GJTKvRT0y8MMyeBIIVwg2791RwuLvPIwn2+eG0Zjqa0B+814VQ/ZpgwH1Zl3yKke2yW6KZz8W47 QwB63ZwCIo+D1+bnNnJ5xif2IB0Id9EyDZwV+2/0uGoKtxbESj+jIv3xdGeXTRj4LS9UEl37Q131L KevgMrv+RAKWlpvZb9rU0hO1VSqT2bLfrACJRVKNZcyKqYxoJt4XFzstQ2/ZEZT3AQDiwF4MseLiw 09sL4pSA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pmMZv-006JZh-QU; Tue, 11 Apr 2023 22:35:07 +0000 Date: Tue, 11 Apr 2023 23:35:07 +0100 From: Matthew Wilcox To: Stefan Roesch Cc: kernel-team@fb.com, linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, david@redhat.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org, Bagas Sanjaya Subject: Re: [PATCH v5 1/3] mm: add new api to enable ksm per process Message-ID: References: <20230406165339.1017597-1-shr@devkernel.io> <20230406165339.1017597-2-shr@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230406165339.1017597-2-shr@devkernel.io> X-Rspam-User: X-Rspamd-Queue-Id: 5EE4C2000F X-Rspamd-Server: rspam01 X-Stat-Signature: jojem67eorecx8bjxn7c1ow1a6e6rrhe X-HE-Tag: 1681252517-782610 X-HE-Meta: U2FsdGVkX18G66WJ8DHPU3+5+/Bc8NymE3e7xnhLFQ5QzseMQ7VRJnNRvddeSLcgLdbkE+tMJ1QnXLeKM7fxqCv2cUpLXBgE2r+a5PRGb0FVgVLuzerKHMuXIBVq+9jwFJlkXebWX8hjqbKGKiGm+qn2PYurmvmnKreFbSbW39X1BPxBPJSthK8CMz9c/PmaFdw3rec4yLEe/Ede3oieoMlMtQ6qjlC8OaxpyS0h3xpl3EZ1pf7jLcAzI4bHZQwXZS7dR2+qUYj0wTTZRrCW6ujUVW2q2uSpI002g612WPcAUao5NX9bbZ48JtDUWbcVl3WhJzdF3TBhmKE8bFwSoIIAaDZzepQDSywzfjVt9k0wGnXvSO2NIwHa7Zc5CYVFyRjievNsmnnhrP1Ss4yE54CvPksJ/sBUNYjV8pNEPllNCfpVxgEKo09GGFoLmaM6uOKH3tXxINBDcjHX7AD0LB1H6Qfnn3IXzuiWKxl5rUqgwSHV/gqDjVE5Qa2WrkNpBSZubW5dJiYbxvJbt11nGteg8zVktzHEDarVqwMwkz8ucQlZzWF5J4ioxm16xZ4GA78b4/kjG9OoK1ITT0N8s1FYJFB+t+4PuEwE8BBaWMDD3llsilotLjnt2g7Jf8LLlzyqtGBzMSA91+l+WUfPzRQQK4r8QYnNY9Ga1yXIk9vyKWdNtwdk+t7HmSmeyNAHprRuAkJiXvHAiXuSmQtSxZ0pCyUVjUOR3rfNGvuNIeqPaVLnxe3E5W8BVZNzVj4ek3fgt1veOZjE7pNzisKI0lWRTsK6QpPUP7ZaUhAhCnD43szwBT7neItfF24D7QhsH11DLP4RLODqge381sr+oIx/GtcRhU3Avo981OkQq6a9/G8BPUP/gmf8nH87Zid/r3stPaivXF7kiECz5PFSTYun566NZqTbojbj6GgD6oFE8Tz8TYNNqxqexRO3IV1YSQnrDSkvdb+JbX2UyOj TDMG74Dh +5U/CvdLJ58srkPB18+2zpEiheeKJP8JNpVR+FFf/eixuPbEK/lxa/iyxiyrYJa4JEkD/hyKV8bLJjMPeHeil0nZGv0xXaiJCUp8T1t/5+VGVvKP3UBAxt5wLzuiqFlCPFEZmFUNrx/VBEuHpBSNG9synfg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 06, 2023 at 09:53:37AM -0700, Stefan Roesch wrote: > + case PR_SET_MEMORY_MERGE: > + if (mmap_write_lock_killable(me->mm)) > + return -EINTR; > + > + if (arg2) { > + int err = ksm_add_mm(me->mm); > + if (err) > + return err; You'll return to userspace with the mutex held, no?