From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1BCFC76196 for ; Tue, 11 Apr 2023 19:36:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37CDF6B0075; Tue, 11 Apr 2023 15:36:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32CCD900004; Tue, 11 Apr 2023 15:36:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F458900003; Tue, 11 Apr 2023 15:36:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1175E6B0075 for ; Tue, 11 Apr 2023 15:36:53 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D1DC91A0DD1 for ; Tue, 11 Apr 2023 19:36:52 +0000 (UTC) X-FDA: 80670117864.10.DDA2F9C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id BD3F6140011 for ; Tue, 11 Apr 2023 19:36:50 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=S4uv2OKB; spf=pass (imf09.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681241810; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2iLylKyf9CWd+Ko8Fo82kxeTfBeJkxjxQ+kN++CquoQ=; b=a/sEhrfiYtbBIbK1vwrYRA+FkUhQ91Yatxz6SekoRIpAxFq5zuK2pJWFpQsFIlS1ZCAOx5 DUffg+Xqfvu5ftgj1H6R90PQfOFojl1C3WfTv2Q4sqoab0Sfil8Ccagp8ohmIfiziM++2N YlxkY1sdNctX+P3rjMeWjlSzCqRFCyc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=S4uv2OKB; spf=pass (imf09.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681241810; a=rsa-sha256; cv=none; b=0cVgxYjKVLoltWDw9ADzRAVVhBrw8NiHw+8TyZVcjvhEwBQ9NjQ1nRPQX5Z7MK3SjrGay9 qNjhnARJFcTUiRWSw+jNBejxaIwi/ZetyCcSwtLTW4iyVWJAiaX4p8Seem1+ycyoZzFLCI EEqKIaeEIP7+NYGTuH4cyfTw7F96hE8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681241809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2iLylKyf9CWd+Ko8Fo82kxeTfBeJkxjxQ+kN++CquoQ=; b=S4uv2OKB5wFufh1EQvYiCBomrjQ4ACTIeYGoPqKeOHL8yBxumW1S7Ij542Ah/BfCm74z65 JwckX7YA4WtQQBLApv4/JMSGyNxfsDYQa0SGq8pp5lQQTvK2x0GcWwXPS2XHkjUYU7p9dR wEHvdhFphP8NFLRZ5fMnQuxZznSIT0A= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-4uVoPb4gMTmZR7ZLwZ4qQQ-1; Tue, 11 Apr 2023 15:36:48 -0400 X-MC-Unique: 4uVoPb4gMTmZR7ZLwZ4qQQ-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-3e676b50f90so3974521cf.1 for ; Tue, 11 Apr 2023 12:36:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681241808; x=1683833808; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2iLylKyf9CWd+Ko8Fo82kxeTfBeJkxjxQ+kN++CquoQ=; b=AeiHXlUs7/CJz/9BRljrci3LJkAiKxk/a1Wp5BUQUPsEhO37O0MmfEpLlw3Z26WCuK DuKLmfKSQvxkoi2x7E5VLykNHXWhZeXp7SEhWPsEzr3MgA+QECZPMS8I9bxw5xvLSGAS SmGIDlalcCY94tjMWT0T+Moxy8kn5Uz+eEP5cWFfk7T25TW0TTnBlDg/CtsTWOSrdifR wmqXkddvsJm6aSHXA72VtDqZMdcgSebb16jFAUJV6t5+0vbcrfxwaBlTajz4C3yMZ2Q2 V6crlGH8ikvoc0X3eL+cNp8KbqoVsSscsN6EwK2EGUbB9mt0F1qBPwGNxyWV/ekr/D/h 3a9w== X-Gm-Message-State: AAQBX9dW752YKh4q8COxAX7me2qiShDPN0t3tUfsDx1tSFgQi7ht7Hae qgcYA1TpGE4bT9aRihBLzn0yLcQvUHFfmFVgXTyN4CDE4fi+uyHXmUAVpgIfTeL295EuIJR0f5p gF35bGkAJmdE= X-Received: by 2002:ac8:5cc8:0:b0:3e6:707e:d3b1 with SMTP id s8-20020ac85cc8000000b003e6707ed3b1mr291610qta.0.1681241808263; Tue, 11 Apr 2023 12:36:48 -0700 (PDT) X-Google-Smtp-Source: AKy350bXJ+//63+GCuRoUpJa34Zp5n07IJmCf8T5KTS/fp15gAFqW94VPnIi+HqI9tyJrIUPd2e1Gw== X-Received: by 2002:ac8:5cc8:0:b0:3e6:707e:d3b1 with SMTP id s8-20020ac85cc8000000b003e6707ed3b1mr291576qta.0.1681241807906; Tue, 11 Apr 2023 12:36:47 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id o191-20020a3741c8000000b0074abe1e1457sm151734qka.76.2023.04.11.12.36.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Apr 2023 12:36:47 -0700 (PDT) Date: Tue, 11 Apr 2023 15:36:46 -0400 From: Peter Xu To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Kravetz , Mike Rapoport , Andrea Arcangeli , Leonardo Bras Soares Passos , Andrew Morton , David Hildenbrand , Axel Rasmussen , Nadav Amit Subject: Re: [PATCH 19/29] selftests/mm: Let uffd_handle_page_fault() takes wp parameter Message-ID: References: <20230330155707.3106228-1-peterx@redhat.com> <20230330160812.3107522-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BD3F6140011 X-Rspam-User: X-Stat-Signature: t88cx6jreh7aitsigr7a8t9q7zterqo4 X-HE-Tag: 1681241810-987295 X-HE-Meta: U2FsdGVkX1+Hst2EPUSQr8BLUSZL2TwYqrQBpeVbibcleiw9ShrqGR3xi47XyshcZny/L484uQjqYUjZhZ9060UgLcf3pHLJFuh/XoE79iEVYxkYvmgO4+ZuHOB05prkkadvl33vyD2DB2ntxT/51jqrBd81cg4MRcIJS4sQE9S7ab5FQPY38AWwRuoBC8o0ABfU2pg4jr0et6Leh02aqbpyYKkIV+lhq/YKcZdk31JFwNI4rt+eqlFg911MmHPrrRqPFKN0jux8yLS6gk5O6LDEqJyiknSzXQhA6nstmkkokGFotiC64+nzOH9KW7jVPfEug14ROI/5+wru228PtWa8fHREzMVrSOYy9EI95Fzqw82/6ewTVlA/qwUn7+3Lza3xelRJF4IOHvYnyBspayVwLwSjFFCq0k99aY7+XYfgByB9XGteYx7ZnibyxhrAa6TxNbtMvGUISYzsa/xljF5mcYo6Vi/h8JhXl5w//x/7QhsivmUTv/xuiZ5YdfKWP1j7YdyILl6ITlOcqnJzMTZKg3cG3fYs5Ekkl+fbDzwTBS8U9HoRXtCHp6Vyjm7pvfSVgJBFHp6G6a5NohsAti1XgiEwHhl9niGUflrTXlQRYIWZN6S1CvH72KPqszjnEVqb7oJv+GQiOkG8bbOAKHIX1KnMiTAxgka+iUxiMIxrVaEBy91q9qreI4V8DMPfaZeVp5v4C7ouVWL/OYZ4i92GBefJX4M1uIPviqZE/8LeYIX1UmVIseX7UWd9bTxaLeRgPnBARtfCsqMQBIDqAj4cGzD0jKdQO6Lgujitc9pymVx5W9cdWrFAhw+v8p7gJ7J/7tUh0RWY24wPa+y5DSzIxa06TjsaESfYN4HZ63pqPeRT5u2Jm+11BsHZe3ZrlCUVDMEc3UuMjDNQ/I6KcX5V+mIx4MeiDif1pkgBli0aBAp17T61tiPx6am+OcaGbcOGKoA+gZrtOAvschZ 1FzfclQG TU5UpMdlQjCYYxmsj4xeGtLDpeEyi/vl215i3R6yGR79WR+mo4mhVUffLGUDsbj58sPwOQp7xz/88Uh1ImWci7jTgRCRw2L16Y4Z7W3I6hsEY/lW31v/yuFPKU0fjJL9zDt+HzTsTJVX1zT1dUFCT0ibZfFGU8W2okvPIU3x9EkxA/qQcm1X9I/W0duUZDfxJzFIx9Pubt5jaioA4oTU+naj9aGGJBQXS/KFxscZgQ2qdoq+R0BljhjGAlJ5uu+QRL8hv3b1TN84cdj2awx5VvV/Yct7045caQ2BNs4G7Mn9WI/N9Bc+0rtUiBSLtOZnBbQZlzu+nslCi3GaTTpfvDijq1c/uY4dUhPHvDg6laEmOdrUYyywKjV/xu/bMIM1MFazP7EuyqzroJDRoUEoJcwwq5S6oZb7CYV6MO6eIcjzqoA4zIBB6QPfDJutMFTGxKF4PutLtoVqmMiI48k1qyxVThK9yPsoLjg/5n4JIhu4wWbjdjb2JY7U72A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001054, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 11, 2023 at 01:52:58PM +0300, Mike Rapoport wrote: > On Thu, Mar 30, 2023 at 12:08:12PM -0400, Peter Xu wrote: > > Subject: selftests/mm: Let uffd_handle_page_fault() takes wp parameter > > Nit: ^ take > > > Make the handler optionally apply WP bit when resolving page faults for > > either missing or minor page faults. This move towards removing global > > Nit: ^ moves Will fix. > > > test_uffdio_wp outside of the common code. > > > > For this, slightly abuse uffd_stats to keep one more parameter on whether > > we'd like to resolve page faults with WP bit set. Note that only the name > > is abused, it'll be better to be called uffd_args or similar but let's not > > bother for now. > > Maybe one of the first commits in the series should have been > s/uffd_stats/uffd_args/g, but I realize that it's PITA, so I won't insist. It's fine, I'll add one patch. The rebase does take some more minutes, but it's manageable. I'll drop this paragraph then. Thanks, -- Peter Xu