From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B466C7619A for ; Tue, 11 Apr 2023 20:09:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A734A6B0074; Tue, 11 Apr 2023 16:09:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A25A76B0075; Tue, 11 Apr 2023 16:09:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 912A9900002; Tue, 11 Apr 2023 16:09:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7DC726B0074 for ; Tue, 11 Apr 2023 16:09:26 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 542BCABCFA for ; Tue, 11 Apr 2023 20:09:26 +0000 (UTC) X-FDA: 80670199932.25.A49B9DA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 2D67D140019 for ; Tue, 11 Apr 2023 20:09:23 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FYiqk2sC; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681243764; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K45z4IfIS5W9aFNj1M79VvTcq0if3B4l0IQI1OCADJQ=; b=KlpVj1ohRLC+4Eer7EejZv6sFs6/DkE9os8sC8agjkgYf5MZQ4eVYQFCecIxEHKXNAtHc2 wwX/FhWtZ+/caAtnxwuxRC80d6WON5dEomv4GOjBUdv1CrMqej+S/DRxeOyVwDHKS2pLeB cb0E4GJH4ZyHG4WsUJmGCu3vmzGJkBU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FYiqk2sC; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681243764; a=rsa-sha256; cv=none; b=LQC8mpUNZ8n1MbcpdFC48jA8Vw2GAUkKIwADYLOu6ohVZVhGwYyN+0UR3SvKBqWHGANxqd G/aQQlZQnqwJTrzI6jFpE/t2fgPBJd4n3bUX8WxjIN+2hDid6Ty0BJXoPt+5NZXbwQ72Pt yrzYT1f+oK7aQ9yzuuy+1ShkGUmZsJU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681243763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K45z4IfIS5W9aFNj1M79VvTcq0if3B4l0IQI1OCADJQ=; b=FYiqk2sCBHF+5wc11gnS3r41tuDToEsB/cssDW8uY2UFHWuUjruZGhISkqdTA0UBpmR2w8 uB+omiB3aCiUSI8MtKcPKaN006rMU1hYb7QgJ44HAdEIBpjwTZyvDB7aLCc/34BZGRppmf aZ45mA2ZBcvGqIiTkzne7pGQTvOccno= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-538-Mu1ZGVoHPsego57VzNpxHQ-1; Tue, 11 Apr 2023 16:09:22 -0400 X-MC-Unique: Mu1ZGVoHPsego57VzNpxHQ-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-5ef3c877a1aso349486d6.0 for ; Tue, 11 Apr 2023 13:09:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681243762; x=1683835762; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K45z4IfIS5W9aFNj1M79VvTcq0if3B4l0IQI1OCADJQ=; b=U++th3k2lGjyRVSKY/FCEDTUuBmHMJ4MP6Fmb/vl2wVH91CHxUiLXNg9/M9CX/Y6AC 3UPfPXxDRxB0io0dJzCAg8fNwRnNCmVJ+Mww7li2Ult6vxvi9OBjCXE2tA7qzLCppu74 Wr7wZbqJW6T8T19RqakB603ranlrHeZcmGAV+dgV46xLJt3+bzU6OuiSyggLShBM6sym DvGPuKiL0pRQmBGGVfGbFNf7gOROylxgvYO3FCOgIKcfDNWxm8pSRiGBzPYgMPPz1b2k 6gxdp2KiPQF5fWChYkExXMV3kirG3XqH4LzVe/O3K4t7ybDkr5FAI0VJ77iS+zH3pcEi A1Wg== X-Gm-Message-State: AAQBX9e+p43sHdJ060KAt2gyJcUvpdMflvDdHIYduvC2eimvWeI2ee/M 1rEQljpWlxjr9awgFAoF7y7wvkypggzvM0QfMdjqHLFjvsOx3xIJ0FtMj0lCFIdlcEAzMQzRBdT 1xlpzkjiIZsY= X-Received: by 2002:a05:6214:5294:b0:5ad:cd4b:3765 with SMTP id kj20-20020a056214529400b005adcd4b3765mr666409qvb.1.1681243761902; Tue, 11 Apr 2023 13:09:21 -0700 (PDT) X-Google-Smtp-Source: AKy350ZCVgYw2bwsduB2+jIpza6191NF737UXdgYyngMJ9F5Jv++vn9ogCCGzim2cMadewXaMln8xA== X-Received: by 2002:a05:6214:5294:b0:5ad:cd4b:3765 with SMTP id kj20-20020a056214529400b005adcd4b3765mr666375qvb.1.1681243761561; Tue, 11 Apr 2023 13:09:21 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id me3-20020a0562145d0300b005dd8b9345aesm4365069qvb.70.2023.04.11.13.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Apr 2023 13:09:21 -0700 (PDT) Date: Tue, 11 Apr 2023 16:09:19 -0400 From: Peter Xu To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Kravetz , Mike Rapoport , Andrea Arcangeli , Leonardo Bras Soares Passos , Andrew Morton , David Hildenbrand , Axel Rasmussen , Nadav Amit Subject: Re: [PATCH 21/29] selftests/mm: Add framework for uffd-unit-test Message-ID: References: <20230330155707.3106228-1-peterx@redhat.com> <20230330160818.3107545-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2D67D140019 X-Stat-Signature: 6a65588y4ofpuqoj7kkb65gao3kifa7o X-Rspam-User: X-HE-Tag: 1681243763-387181 X-HE-Meta: U2FsdGVkX1/QyT/12Bbi9fXBvBP9qDfYG99t8MUgxMLxjAP+gFlnOvQxhhb2BOCJ1mdhKl8vUy/pTDTzeOSnVCX33O0Wa1f1M1wji9nrNXy8drE2vTNv980taRsAlMlJ6QNH8xnn2imEeOMEqMdu/4L0GsfUVXPHW7O16jNwmYJBqqw8KTGxVvoG1Hb85mKsiRdoV5xuehNI3z/21Z83QlVXFwUxCngaUmVLPaHWOEy2c6BaB8BVrzcFJ3NmeRPfHAbZRk/SPu7by49Wuu6N5BQa76cA72GOW1GvZJ+B9Zy1QkZtO7+TXI4gFmkTtahQu0rg5Nr+mMhOneNzYrwPTfVlZgkJ43uDhyZpng70MBBr1R+YO+AELB5rBm2s7hYf8r9paYizIJhUcvfnwpI2OKcMopv8540F1ygY6m+ccu1/xkOxlitL+wvgtP8uEfoidLT+4+l4mhsXXRtZj8BgkPjuHXP0QT2468RVvE9xwRP7gHLu26IBgIjoA+MSW4v4aYX5+uFd+jlhciFgBZnkfjRdCQg4kN+IbW9KZrPFuI4sGBRQkzFmvwgyo48MrEAjgdVM0BIsBmfbBTbbDPojxk6dm1ivq4L0TS2yeysRArgk9e/4+H2+0oVIXWwOe/YYm1CwzOmTcOF+PZ1UWGiDf80WzvgqkuJJnxfz3gIqzZdJ1Pm1hOo+yCYvsswHEgjkfAAjBaOJJH0EzGciy5jBM7gj2g30FsJufMmWhAzPIyQS3geVKc0NEhuI2VkZBDnOZzuqtKxNGtSK7VaGnZ2xEjBG+QO+DH8W0sHzLFnMuWfWWb5oviYEn1RzCwg5X1thbyBt6JSSx3QqSqF/+Lm9yXPALNg+oRonq9yMnytvYMqIZJJxQR6uJBsWpMceMchV2Y/57fDywY0/Jsz1JvoRkxTOtZKpZ4x4jsKU35oVEWehh6boypHiN98y17m5WEVCq090YB5rs0BV7qkMThk Zrm/wBKN OTIE29wp0XqTtEG/VXEUxxI5pQs+iWsJXjeb01S7ch8D/KipjtsCduTXTacmHeMGkRbZxdG5G/qGZ4eJi3HQS8uESf4isWqMX/aaG38dFLOGIqInhkkMsUVwWmnsCCXxHKe1ZqzxH/b4S5/uDsYAu6tXR8oIaSq8Gx57IqHnT/B9VNhu/sz7EgKAtO1oo+t8TfQ7zI2JJSRXLcRnu99UcAj05NRv1G+/RUfPbTlYE30s4W+VJ8/3pDIM91BQc19kPKy8OZLekqeQ2D3/KEfUQezc8rYoQdOH+uygP4nUQYirS+cLCPLLHtth69Tj1zbqNCmnpezqM1e6iOOvTGGy8y6usOAF/oaz3w3kQEhPGiy6CziZe5p4WdW2qntmAVi2qR/wrDl4jf5r8/IR6N7ZCa5MZBiaSrrFpjLyPucSGp+82zbPOwo2rDcZdCxtuIueMkXaF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 11, 2023 at 02:09:51PM +0300, Mike Rapoport wrote: > > @@ -119,7 +220,31 @@ int main(int argc, char *argv[]) > > printf("Userfaultfd not supported or unprivileged, skip all tests\n"); > > exit(KSFT_SKIP); > > } > > + > > + for (i = 0; i < n_tests; i++) { > > + test = &uffd_tests[i]; > > + for (j = 0; j < n_mems; j++) { > > + mem_type = &mem_types[j]; > > + if (!(test->mem_targets & mem_type->mem_flag)) > > + continue; > > + snprintf(test_name, sizeof(test_name), > > + "%s on %s", test->name, mem_type->name); > > + > > + uffd_test_start(test_name); > > + if (!uffd_feature_supported(test)) { > > + uffd_test_skip("feature missing"); > > + continue; > > + } > > + if (uffd_setup_environment(test, mem_type)) { > > + uffd_test_skip("memory allocation failed"); > > Maybe uffd_test_skip("environment setup failed")? Sure. Side note: the line will be changed after "selftests/mm: Allow uffd test to skip properly with no privilege" to contain an errmsg pointer instead, so it won't affect the last result after series applied. Thanks, -- Peter Xu