From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E675C77B61 for ; Mon, 10 Apr 2023 14:05:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF783280025; Mon, 10 Apr 2023 10:05:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA76B28001E; Mon, 10 Apr 2023 10:05:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B95F6280025; Mon, 10 Apr 2023 10:05:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A9B4028001E for ; Mon, 10 Apr 2023 10:05:19 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 53F25140820 for ; Mon, 10 Apr 2023 14:05:19 +0000 (UTC) X-FDA: 80665653558.30.3ACC683 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf02.hostedemail.com (Postfix) with ESMTP id 471DD80007 for ; Mon, 10 Apr 2023 14:05:17 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mRIFjiha; spf=pass (imf02.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681135517; a=rsa-sha256; cv=none; b=ITVDZLadzV+ES63AiGlEVydNcA+Ar9vnXPRxSm+0PH4h3LRqwo7mGmgsaUxEgPArUEuA97 OAgWFKkd5KX2YR7QlMhxFQC6DG9qsfTEG7gSC1HlndmwRo6OeTXYjOghMFvyXeo15G4+iT x7EClt7SO+pM53DHDtgmcOiQuwMxigY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mRIFjiha; spf=pass (imf02.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681135517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=35xefQR+/4cQOJ1FT6n3YMdHgJZzmvORO2uADg1HnAI=; b=xCtsq5fhCah+FwI3r4UYQxW1bLhpnCt6hcBrnSnqXIoX1E3CO6m2yNfeHrzqODvrHefyGP 350XdN8Dr7CVzSAWkpqN8Lx30n1nJjsifDL6YL//zToNSJDVntTjijq8GNtyEeE+vOc1yW CNAKmGgNoKJ1nFS7mQyOfX1MMsHNrjI= Received: by mail-pj1-f50.google.com with SMTP id h24-20020a17090a9c1800b002404be7920aso4492203pjp.5 for ; Mon, 10 Apr 2023 07:05:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681135516; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=35xefQR+/4cQOJ1FT6n3YMdHgJZzmvORO2uADg1HnAI=; b=mRIFjiham65mximqN7+B2rXd1Ce9jTLW3WR+VLNoLeamLaxoKQBmiZppw2YSzblFsS 0/rqbULuWhPnQ+soxejFdm2FzI6plMl6Vs3Qaei7ySArDyusyoL1dBpzVAXrauyKrBcm 6BPkyOReB1Ec/CVnL/MWUBWSHs9vbfP3DUUA8P28NiHcV9FWTsjriOAP8GNBSoBmus4U Nkr7ZUWbkCDuPD11BuJOYXXBMcsEpEuhK1fiD2QmBGgpe54HMGhfXQMnOwze/2WojsGn olSOuxXDkwyJIMFrtN/oXs8oOHISQC+fyVjDmZU5SkwGuXt/h2/vAEKLBInZjoxaD4fI t7pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681135516; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=35xefQR+/4cQOJ1FT6n3YMdHgJZzmvORO2uADg1HnAI=; b=LCLeoyHsRxr3iYI6KbJVPRqZx2HtjMC4GdctzoR7Oj/xRU5g2bRdl6DKJWIqGrPyMo Yy0nLC0IjIqoyjBvRmSzEpIunMOiZ0YczHt1nDbEHbo/3xzL6whsCSM4r1x5ya1PptSX w/Vz3vobeT9ej/MKkJdgvHP+PQkMcyFvnt0uK6mb+gWMV0prDLdPA2mSyRDFw6fPU2jh X4uOcQDArgqc8a2AQ+LxGoz8tkn2xnQCyPG0rPEeSKnCWZFm7QegiYjvyXIx+/J4G297 zzUGGp5YC446tSMKoVCQwIdQDLR3PQJbeqYgvh7ysd5s+wkV5aPGxaRpJAfXqL24ptZw Mq/w== X-Gm-Message-State: AAQBX9dJ//EQL/QPhJXKHj7651x10SEEUmWHSCCQ7CgWsH3linRzLEPn fIOY3KsuIyIKtzqffe2AwaKlvonJX8KJQw== X-Google-Smtp-Source: AKy350ZU0mA2B70AoP/XIJnlEfmhWjqbIKw/JmdLvLJqdkmqI1tXL59/vPRlgN4+op1M+rU4GSj/Jg== X-Received: by 2002:a17:902:c9d2:b0:1a0:422f:39d9 with SMTP id q18-20020a170902c9d200b001a0422f39d9mr7356137pld.39.1681135515345; Mon, 10 Apr 2023 07:05:15 -0700 (PDT) Received: from debian.me (subs02-180-214-232-20.three.co.id. [180.214.232.20]) by smtp.gmail.com with ESMTPSA id c24-20020a170902d91800b001a63a2efdf6sm2492807plz.273.2023.04.10.07.05.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 07:05:14 -0700 (PDT) Received: by debian.me (Postfix, from userid 1000) id 8F8F81067EC; Mon, 10 Apr 2023 21:05:11 +0700 (WIB) Date: Mon, 10 Apr 2023 21:05:11 +0700 From: Bagas Sanjaya To: zhaoxinchao Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Fixed incorrect comment for _kmem_cache_create function Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OndvnLYy0dRk1lRx" Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 471DD80007 X-Rspamd-Server: rspam01 X-Stat-Signature: ckf1a5iy3c4389ebz1ykx9rxu6xe5cdu X-HE-Tag: 1681135517-502482 X-HE-Meta: U2FsdGVkX18h7qc5mCzoKhfU0muWhM1OEEGFwVZkzAJetIcjcCBSeJGTUAS3IG8ExKFfXrwU0xAzSgT+24Tq8ahYNi1KSfOHT+nMHE/69Tb/zwn3uSyHIvRemLI/WV2+z31iWqefGWsT4lkJKzzIVXPZQO/JCn577m0wIkRFnmtptJqsOwEp+f5DPgik6prgyCfJOEMGI2IXYMyQydIcFjN0K9tocJ2pKmDp3Gw5ecWlIzMWr1DJ3b02dIYiI3+cqXZB3ch2sm5nL8qGR5ujkrq8BzWvL38JfTHUBCKAHlRvNg0MQP1b40WKnC1LWLzcIAKqabjN5i6QUfVdnjXKj9CFyOQ4VN54ojNdehPkPAVuYq7RpZ72p5dHxSepBUF2HgPn6J2//IEUe9qnSElBOjRUkxq5BxpAB6d8JllLVoegfG2b6MtW3ZQWGpP9i/CRuHXChdUxOjA+s6olC6JglT4B9SFGlmLYCP+XyrXtXY3vKTOn90MA3HWahfEXGGC2GDnkz0ezzbtD9pWJJ2sQJwp3Aur3L7jVmtmdQyvWp9qRfmhkMLJ30mNc/UIcimvvy8elXf/9jJKTxraQpqNBZzcfkD4mo4SSdvjzRZv4iVU7RMYEHXqphwfFnwTbN8f5hlO8XltuUfg3Lkgmwxytdd21miYFHn/MeNwwVNLVON5NScIRjqhOrzodfQTvb+3VKDmmv5O/u5674m/mTrJQ1gtSYSplGTdnanimN+fBqYf2E+F6g1R1XJISUcMHR0nToIRxKZ//D/8n/euDIuWOENcVptEhg4+Nx52cTs7wQ9+kLpS4inFf8yqK4W7IIUqVRfXKdqEtoSHhpOr6XOJjHdEfHvqCJjRmeWxB7VUiod3PHpLLhN9o77dCryJeglcw37L9L6p68xHWuTPjI6HvgiDXuSe9wPfsGQ3d+wWywpXfPbfj73wV2fXVB8QMewCOr7o+16VOeEvcXcFeDjT MW4pIO2f c3BVLkcy6kTjUU7nazhXspvKNB5+BJP1oMMGU9zbS6FTr1k2CWhpng8RT6IsBE6XdYS+7qXZz3dKI4hnlUJZNz2cDRQAjyAFVAD9443907CyD4sFq1uQP1jddHp6ki5rXOb6hAZ5GOAHNcF+DuVKZPbgn6BRWwhFq1q/Uz7HVr5Rp2oOLv9Ds6t1lJEgPHae8fpPxMj1kYG84WS7FJWWxxaURKlRjsBuXXXimdt9oiTM/bt8cjnXN8pdIWs0HyNuXXcyQNotW9GHw0puoos8uVb0enPI9fmuq73hlCL6A2sQi3oA6lp6r6Jq834wXTGL5ghwyP1g/QJsp/jsyNoKNjzKq+wBulsDFHKLpVOg5T1wo+TwbKDfZPIYuZJV9YP//P4B8/PdC97Zv3e8bRz7GnojOJ2nmcLyAfzvYc2Wq7DtWwigsq/dcxUJeRsyeuhaYJ16roxAvsDAsTavWeXvpxJ8cv/d83uXhuKJO05hWmLPndbEljdUDClcXYgH5H6hYx0HJ53RAPi3h9HrRepUrFgOJ0T1rGmfvvlSfj9XL/DrjkPBM+BegbJfnqOnlx7SKLEo/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.333139, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --OndvnLYy0dRk1lRx Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 10, 2023 at 05:01:42PM +0800, zhaoxinchao wrote: > - * Returns a ptr to the cache on success, NULL on failure. > + * Returns zero on success, others on failure. Can you explain what these other return values are? I have skimmed on __kmem_cache_create() kerneldoc and the function returns error in that case. --=20 An old man doll... just what I always wanted! - Clara --OndvnLYy0dRk1lRx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZDQXkgAKCRD2uYlJVVFO o1TOAQCaJ5kQeoVd3iUY7lCbY47Sv+S10MInRRx2fB65Cqdu7AD9HHLz7PtNCz44 Vea7Rp9WE9BlVptONwHR+f9BgzzMGgk= =liwK -----END PGP SIGNATURE----- --OndvnLYy0dRk1lRx--