From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0886C77B61 for ; Mon, 10 Apr 2023 13:52:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47048280023; Mon, 10 Apr 2023 09:52:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4210A28001E; Mon, 10 Apr 2023 09:52:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E900280023; Mon, 10 Apr 2023 09:52:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2021C28001E for ; Mon, 10 Apr 2023 09:52:02 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EF368AB381 for ; Mon, 10 Apr 2023 13:52:01 +0000 (UTC) X-FDA: 80665620042.06.5331D7D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 98D6A80027 for ; Mon, 10 Apr 2023 13:51:59 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LSDK9hfv; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681134720; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xJiy5asiUhmQxlHjXRXu9kHZp3LovZa44g8LjX7RzaE=; b=659GhHKMpgqnV9Ma5wG1ygtTU5OL4my+ucH/R0WNuKrapmvv3AZZI9WmxxhsBMvkc/DB7x Y6/3sG//5ubs3BwUrNcInEFSHZ+bU/7bDHdTIqnzgzYUhR+Mjz0orou/OQYWU1hKZjTVAG ksdil3qSsj8es25smcgrFA1a1YeQgMc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LSDK9hfv; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681134720; a=rsa-sha256; cv=none; b=fssZBWDKyZL7czX98lnTkNkZXgHBZ46JmdDJySHyeSY7RdegCk2Ac33/eB29jyOu3lpM0L GJJloryFLjgXIJ2PNLmCT2uvTBdU3el0wHdE3QBhf4r8yeKGMU7DBIYDXoTf8R6Hy55d2N 4d/rmf6ZI5paqf2Q/dd9x27FM0Ei2Vs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xJiy5asiUhmQxlHjXRXu9kHZp3LovZa44g8LjX7RzaE=; b=LSDK9hfvS470b8r0sjcgHolIMj fjCO4XrBHUI/jZPzk6H8Q4gmgsTnOtsF9aD/E+O4cU40BzunkQ2U69NHqeZlByju5NkjbZfN7VvW+ j5cfaeW+UKixZKr1urBwdEAaU+go2YbR8FWZlyZ/71SlUYqN73b3hzdnIY350Mtp+tFj+DYVNclxh M40l1YLgmdA2ThhJpXWz9CgSZz8XaeTUp6h1Xbhbei1VYLnUvwmZNa7ELmZ62x0RGWEerRI1X48IS CswZJETP5FiBxshp7iZsk0BbLSa63VfwK4zSxWZ79M89ko/LT2tzY0ErJzcD7zVrJ/FHTpNMMuQjB 0NF4pJQA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1plrvw-004E8M-AG; Mon, 10 Apr 2023 13:51:48 +0000 Date: Mon, 10 Apr 2023 14:51:48 +0100 From: Matthew Wilcox To: Peng Zhang Cc: Gang Li , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, David Binderman Subject: Re: [PATCH] maple_tree: Use correct variable type in sizeof Message-ID: References: <20230410091431.74961-1-zhangpeng.00@bytedance.com> <8b5af22d-1612-a2a0-02da-728f1fd57bf1@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 98D6A80027 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 3akb34gdrzcxqbu4i8qzew5hronndmsx X-HE-Tag: 1681134719-770849 X-HE-Meta: U2FsdGVkX18xzJPoe2tb//MZIyjnFIGWwU0JbQYWlFi7Nt4gAulKvuUoeS+0xbDY7udIYkfGPQZJ/ZM9wdgmWOT6I8NUAEL/GHbzC5snshP4Y419rljJUpgWFcWkKX7GB3tQLG5MN9ukDcsKsG4D1KEI2ckPYKk++ldnOlPrTPqZp8+L+8S2MTPU48HURK0kZTC5Y+uA/IE/NElwPXkHsMwwyBhJ9aFNtBAZE08HeUcC5pcxUC6XXL02HF8997/Q2tziItFx90uXt8tojlc5cH06sidb4fxVV8PChGU/GYF44hMVFuXNu9CmQf23SnnTYZqmp873xmlz67admE9cdWU3C12awFGWgBv16qwYuhAqTU7R9SrSzATV0nm623JXt98ucB1s4c4QWuWtf/Al30s/eVxNU/4cOQJFaIH2End9feUlq6q006jn/7LyrGrYb4FRhq/5iBmycJkAn31X4GohvNOPhNXTgRaolyfxPKBw9DiTt1cE0MfZZfvEhOCT7LULN2+sivcPmn9BCwDuO9VjN96p0HQu+ykGLkvB/3a2uo/vQZ04eejp0WArDFwyO6Go3sOCgse7HoMp+p6e+KaBEBcL3mFEbmksqPExEk2MYEYqKl8QXQ4AiSaSnr3Lwu/QYvkvtppQOfuzX3DTf3R5EQFi4GVmITjWVULnGAqxcZO0R4EneAAxiXoYJrgIRtSGOAdvbffqdin0Pco4dPUn9gD/xEANwkGRH/6HPMXSo2HoDOQiTFaju/PPOi6KC3I/b9FLxyGviMhzvJIFqw9z4RnUfEUD42FwMxSCTVhANAlXikZHU5tYfEke16FFtU82gau6Xfj/vHG9fzDQjpME8hJae3juok/2YFpKNSjVGvdb121vI5fmCji1qPfCUpG/+Vn9G6FjwQfCMvCWk4+Y/NxEnVEhmHvZziY34z8ICv+mVZelmtZEUWXojy2rcp7LaQk0eNHBns5i06e TkSK4gyP p0gCo47fcpfUeiL04U421y5xSH2/rE2qARpLT6MSnKpcehJY7PPxIZk5kumme8H9n3s4alSCiK9yDLx7PH5Vo/TA9BC6kM51IZauiQA5cEYqUBTFug8EXh8n691END704xF4GA+XwyZCnupsGbyWD+VlbQOb3MqPsO7aWk8mXGuEkq0cwB3YlSLZAts3HICGmAkaGLj5CQFDtGfo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 10, 2023 at 06:09:27PM +0800, Peng Zhang wrote: > Maybe sizeof(void *) is equal to sizeof(unsigned long) > in most architectures, so I don't know if it counts as a fix. This is actually required inside the Linux kernel. The only programming model I know where sizeof(void *) != sizeof(unsigned long) is Windows 64-bit userspace.