From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9206C77B61 for ; Mon, 10 Apr 2023 16:41:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5B07280030; Mon, 10 Apr 2023 12:41:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0B4228001E; Mon, 10 Apr 2023 12:41:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BABC7280030; Mon, 10 Apr 2023 12:41:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A7C5F28001E for ; Mon, 10 Apr 2023 12:41:12 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 789EC14037B for ; Mon, 10 Apr 2023 16:41:12 +0000 (UTC) X-FDA: 80666046384.07.3B9456B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id C23E7140003 for ; Mon, 10 Apr 2023 16:41:10 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="YQRgGe/H"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681144870; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WU7F3Jzwt+TbJ7lJ+Tjlo0gqLJdgsVMF+cfbew70I3w=; b=tAwoct0t+gtslJfemdEL12vyvxAl16VezxL4MWwjF6sKvHe17mPbQqCZuSR9rxsNOrugxN pDJzcEx0J4sHZXK+Kc7VLA6WnsUlyvAqJJ10OC4mqKdA/Hh1ApgIWBlFAKYQWWFalrqfYD bUKG9ArFD6nJECnMsOrgsOZJbj0ifIw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="YQRgGe/H"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681144870; a=rsa-sha256; cv=none; b=G1/v9Wff+Ck8CMiX5jx4CCvdo9PnE6WSw0YfYd6/7khlhVaGUWUXSLUrx6GurCYT+wWUdQ 75eDQKNla3pYntPoh54PEDxf8EsNErwzWsyXRSMZV59P0zqpN60aEhG6U2xpEKoA0B5fj1 HosXpG0WZXic8NPhP7uuWCq/VNqpxQ0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D148D61CC6; Mon, 10 Apr 2023 16:41:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EB39C433D2; Mon, 10 Apr 2023 16:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681144869; bh=zz8rVoloOKCPdCyFenJt8RAA9ls+uQJna7oAZHgsD9Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YQRgGe/HZZXRBjj3tFQYBBklu/9e3YmhJ1Pt1l/aornMes8Hx8Y11OfM6V6V6M6r/ drh+NIPlojIbSsPm7Sht1YpA22EF62hchPoGv6PJnmjyrruFwiT4KeSl7cIULX7MxS 30PuglPFIEacD4MIthT4vM5mZS2LAdvXdqMEOd4JH1o81eBCr57VWj7tiLGwd0vPA7 9YP+gWi90lW19MvExGBfE+I1sBz/rwVlfvHAeGCvlm5UBbUqrmP09OtPgoR2NW8ITi Ij3TDHVUbSdPCI8r0XxZ5DpuuckwxglXmol4JBUdrxW48cVL1KYEpnZIfSY0BFZ9nY RUIC98mkikC4Q== Date: Mon, 10 Apr 2023 19:40:54 +0300 From: Mike Rapoport To: Lucas Tanure Cc: Rob Herring , Frank Rowand , Andrew Morton , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, jbrunet@baylibre.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, martin.blumenstingl@googlemail.com, narmstrong@baylibre.com, stefan@agner.ch Subject: Re: [PATCH v2 1/1] of: fdt: Scan /memreserve/ last Message-ID: References: <20230410120017.41664-1-tanure@linux.com> <20230410120017.41664-2-tanure@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230410120017.41664-2-tanure@linux.com> X-Rspamd-Queue-Id: C23E7140003 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: i3pciy8uqsdsijbsqyt7et7rrdfu7br8 X-HE-Tag: 1681144870-253647 X-HE-Meta: U2FsdGVkX1/1oWdiViVI+RRtCALDashs+zUhPFbme3q18BlQX5Qs8NPE3OVGklJbOfgaLgCIGF/HSX+18pGVoBbSWNrxzZ6MWWdJk7Ne461H+E6O8mAG8OX4OyKwX3awcTxgC8lun7Sfrrc0xAJoimvQv3sI85kBzPnjPNKtHcBXc7nftgbzxXiAqk3W9OYjmjZ35l1DD7aRpfFKLBgf6gmRq77RGC1dulepV+sCKFVobHfwlSTBOr7jv0FhA2lZA2u+tpeTliGCs52WICu2++Gx2M60FuNnOxShUMZdBDH3V3zggJfYd2qKJIjd/7FlZPWx8TEjSXXHR4WXH/uu+QE9W/sz0JqzI+5VWMyA2q0IgL39Rnm1W8mFGLFEVfB3v8+rQrGLHdg4kYAsPBtNQ7TrcXGPmoJhudpxC+Db+62wC7C3Nan3Eel4sVEYHsYzg9/+AKMRAo5GMudCkNR4+7gvwMtGdUbHt0L92jN4xE++BssnRy2AMgdB6Mv1SH2ORL9QK9oyUAED5k9kiL62StWphoIFLupYbLXCY5y0WwNz1PlGWH5/O9c5y2liab+mb7OYcSEO2F/8Z41Je3BPycoML1AmsGxrtrhcri0Jxj9Mu7Mi9B3R9XWcP7BbRyFAtISk3x0apfF1wcag1OJMLgUeZEYM4WktWdNyDvJZna/rYojffiCRAmXn1k0dtw8ne8So1Oep/liU+auRVdEHyOrsw9em7pPmJBDDxqZzcXU7ZZdy1Sm3s19tCsCv190tmoOHmdi7Mr4hYiVF9hEa+HbupsI3is1TQN0WeUd7KUp0YpNV/XrPYVt9x2Gz8uiDrEfz8KnbVfGHDfUFD3cdl6q34Q9KCn4oeKoNi6x+7P4jhEfin7zLAMHeHlZSCAS3DVKlMKtV/mMNkmosibN0xFVxfnzzBkb+BLpUh99A3otyMF8HuHK198FYy6lStUzkdhBDoD50N87a5HsnmDD fDWfWDLl 89olFUCLK7gSSFamLDdo69+UxmUCFuojYRKlIIQkNkcs5aIJi+RTyZ/3x2ksTSEJhHHoq+/tl2SG1V9EzP6xmVKdi/JwOye7GC5HxYSMgJ15zSVFi8KQoOoqeRAb1LrRLE3JGubpN6cIQ983aJYQyN90+9Oe9OAQIcgzNNqGQz/K1FO5RNcaPbizZrv0DIWz8H+PjW8rJUzOR+xafsjNofdafhneJ1DgPGAvmcYLDaNqID7dHKNsCy2I3cfLufwQJodQQMQJk108nXfut+Ax0z8SrLFb+520XpsvCsjT9Lu0RucaWH2poaUvXs7UzcFI5NY8eGSd7pQbv23ZjmaPvZwJ+GgmdnWMMx0jodatLnik8QW4oNUbQBRuAjKEdAaMSopEmPJxaCJ8JBg0V7vLTm8NVlJt79JuVKMOrPfBAeUDN6P+dClaZO1aTfg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 10, 2023 at 08:00:17AM -0400, Lucas Tanure wrote: > Change the order of scanning /memreserve/ and /reserved-memory node. > /reserved-memory node should go first, as it has a more updated > description of the memory regions and it can apply flags, like nomap. > Also, /memreserve/ should avoid reserving regions described in > /reserved-memory node. > > Signed-off-by: Lucas Tanure > --- > drivers/of/fdt.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > index d1a68b6d03b3..26e608d8025d 100644 > --- a/drivers/of/fdt.c > +++ b/drivers/of/fdt.c > @@ -635,16 +635,21 @@ void __init early_init_fdt_scan_reserved_mem(void) > if (!initial_boot_params) > return; > > + fdt_scan_reserved_mem(); > + fdt_reserve_elfcorehdr(); > + > /* Process header /memreserve/ fields */ > for (n = 0; ; n++) { > fdt_get_mem_rsv(initial_boot_params, n, &base, &size); > if (!size) > break; > + if (memblock_overlaps_region(&memblock.memory, base, size) && > + memblock_is_region_reserved(base, size)) > + break; I don't think this is really needed, it's ok to reserve the same ranges multiple times. Both checks are not cheap, so it'll be better to just reserve everything both from performance and simplicity points of view. > + > memblock_reserve(base, size); > } > > - fdt_scan_reserved_mem(); > - fdt_reserve_elfcorehdr(); > fdt_init_reserved_mem(); > } > > -- > 2.40.0 > -- Sincerely yours, Mike.