From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C109AC6FD18 for ; Tue, 18 Apr 2023 23:38:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0942D8E0003; Tue, 18 Apr 2023 19:38:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 043D58E0001; Tue, 18 Apr 2023 19:38:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4DE98E0003; Tue, 18 Apr 2023 19:38:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D4AA88E0001 for ; Tue, 18 Apr 2023 19:38:15 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 867B880433 for ; Tue, 18 Apr 2023 23:38:15 +0000 (UTC) X-FDA: 80696127750.20.32C48C3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 3D4D9A000F for ; Tue, 18 Apr 2023 23:38:12 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Pl3So5w/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681861093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k5Bn3juE3fDshVkllxAzqw/tWdNFN8bQYVRW3fhsVrE=; b=YCNIJFbPu7zVLSSwUt/4chLHftGJkeDMu9MNKoEObXrq11rISFEB7skiadyPuRLs5ZY7gX 2a1+teriJjVzeKRqF0CFixXjyJsJyGc8SViAguJ/F5d4jeoWDxPvYkYh6LIMxRsP/vDUmz 3fdoCf0zcBiXFyaesGZvzmc+X4QPC3M= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Pl3So5w/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681861093; a=rsa-sha256; cv=none; b=z2A8JpdSHkETvlRxr3GfYWYzWCEM8OWraWE4dGNaCZEJPgM4kHZLYgMYfH9kDDeYEHT1+k 8qrEO6Vp+CptPBSsN07MznrqxTXm5jlNUf0wvCMS4ayWhqNcqyPzKcIlT9QUwqbIuCr/0c wVnoultzi1URkcjYVS+KSTO9Y+2hrr4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681861092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k5Bn3juE3fDshVkllxAzqw/tWdNFN8bQYVRW3fhsVrE=; b=Pl3So5w/l3jw5+YK1DOheSihKpYRsMguR7QtyyL2UrZWMfZWgW1euykZlhrb3DJpjjQpGJ W6oJTswNZvdVa1V9CPE7veWDQaA3ueyU/p4aNFetW5/xT5t92tGg0ixEjA4Ps7xJFVFEOI 3PXtvBNMxDQblYW/qzKLqTQXDaw6H4s= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-576-3ocKbCMHME2M4xKOm4XKfQ-1; Tue, 18 Apr 2023 19:38:10 -0400 X-MC-Unique: 3ocKbCMHME2M4xKOm4XKfQ-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-3ef2cb3bfbfso7795721cf.0 for ; Tue, 18 Apr 2023 16:38:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681861090; x=1684453090; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k5Bn3juE3fDshVkllxAzqw/tWdNFN8bQYVRW3fhsVrE=; b=aw3nmjj1qeGFWn8TQ7NxlgeMi5/2uVXVD9Mi+GNAVYNusUj8jUr+qCkYcMpgcmNco2 7cwEhlCiFbcHG544AJxedYVXvjUwtquiHIrq7Vol2S697gxsxQyWoVmxNzJjHuk1aHso seHPWECBkr98F3RlJfINwgugeJi07WJQ7NiM63bgbpKD4nHB9Y7kIvvQr66HiqVO01Zh BQsBH1SHKcEUF6h2c9jaLt82Lyszw/UOGORJ000lCM5eTV/X1UTrd0fYDYnxCFs4Ts5T Q4CU4NT0JUAbLe/ozLhkmMQwkHVEibXzJUNZrnoHlHY2pD39Sf18n+QF1jVJTByM2CuJ 6Awg== X-Gm-Message-State: AAQBX9cFpFyTYzCjPMAJ0OK7pOb+X5FgPzimUmtazZTjSbtCRH3ovs8n rXTtSgJQs/a55p25+KtM4OpJU3/V7j/pLs8RTZpEwmQtYie8BLpuCYNd4+TOgS1rba0h/mpO6uD zjQJwou1zgPE= X-Received: by 2002:ac8:5a84:0:b0:3ef:1642:c123 with SMTP id c4-20020ac85a84000000b003ef1642c123mr14027835qtc.3.1681861090238; Tue, 18 Apr 2023 16:38:10 -0700 (PDT) X-Google-Smtp-Source: AKy350bFSTC9+a3VzPZ5WT1HHb3h4712B+djlPByCXMkSRVkFwpmThKQ3P3ImCkavSgxNCk609F+OQ== X-Received: by 2002:ac8:5a84:0:b0:3ef:1642:c123 with SMTP id c4-20020ac85a84000000b003ef1642c123mr14027812qtc.3.1681861089946; Tue, 18 Apr 2023 16:38:09 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id de39-20020a05620a372700b0074ad4cc603dsm970121qkb.131.2023.04.18.16.38.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 16:38:09 -0700 (PDT) Date: Tue, 18 Apr 2023 19:38:07 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: Matthew Wilcox , akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 3D4D9A000F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: gmbftszubtd7wnnd1srx8wng3boh5u8y X-HE-Tag: 1681861092-432924 X-HE-Meta: U2FsdGVkX18cM+enc4arzaNhNz0aGiQuR5q5M4CM5KZcnBEWbhpCy9xOjvHQG103Pg84Ssl/qjeD4N5nrrLte65NTs/onmPc7L76KG57c2OqzPrGNRiprR9MO3FhAMW4krH6hB55VQ3iBU2+dnaBXD8+r0Gnrt/c6RQdaQg0ghH2Sb5v6SuQH/zSG9eTFs35QZJIKO6lmkLbreX1bzKCBuZzW9CdXdrrM6PXGWhkkXpIWjaxn7+YddaF01wQgrFVr5rBcv7d8R70z+4H0q2DvnrQZyDlS2l13YBTMCo27tgzuAAhVVdUtg9gFI6uC3m2iagXzylGQEaTsl4oVZUfJ0Sw2RtDnANfrNvsu3d4tz6ueyt4lX4y3GPBVpsRCQ0+VSLqg+zIkp0GzAixEqQimik+f1otQeHazc0VmMrKTJ7vmM7VwnnnE/zl1z8RLDpcTk60Yr5YPszWedEEXiagjrBdibfIyjbIRoi4KhlSH0psfgwvBApjNLfr1KL24qLd0evwCiYDDLsDoxfS56S35knij644xlyrL4EyhAUYVF9QrywKOgRLWpDNWEOdl9t0jDys4CD6Qe1fgxfXG/q9+MSOXA2faOvlTEKyAK77iV4I7cDJIj0FtS11QM/kjP190z5c42l2IxWIzeHGs3Ui+293e1dIHCJJ0+ICUCu5WgnMT+/31NR3vkFliF760xdXXsYoQT/yV3zPV3cPFUZMGiC37y6266MF0d3WfxkBZfJZ41O5jA2GgOwZ/Fmw77CK7eeYl7UNPqRb/yCWh7vSY08U6oqEXNa2KEFHpy6+IK51fw6Y9Qatzcq2xZavd46U/kROIBmpV0zzzrLaIGX+s2ZIx21ksz/QLH9c3YKIVICMvcnXD5iCB2+tlJRMqIRiPWp0znOVdOYvCdKegR8CJe2mKOL6qBrejk6keRrxDoG7XB6I9AI7AaoIglItNS22Sqcby2oJCO5OpB7vpTM pK3esouC NSxWjx6AjEuIbMQ4mebzY8DyeiN1JeAVjBjP/gp9xzVpWZ2gxupFEs0HSZ2Zuee1a5zqrQnnyQYXIlpZ4A2OuuVls61d1wFBWeC7JiLnm6zwZ3JKe5evTAPM+HtwqK4mzH5cD1I30taGFsOgqS/k2Dqu1B4gHol1Fyh/aH759MNVtCMpPZiiA6OmT7VcGB7io5c0TYoPe2FnLOHk43+Vt1aJGNafFoQU1KccH2jyBJWdlZRw1RBCQUe8Z+gOW/CqMzNRudDPhbODePQcC44OO+eQqrQpi0uBB8ihbb+IezWluTfLbo7BANseNFTVyw4W905Z1UphwBudKTmkf3iFTe4BM0g9dkWptX7mwPx/YUmOS1ZryNHGFQHoe9RavDz9VBaG0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000018, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 18, 2023 at 03:58:26PM -0700, Suren Baghdasaryan wrote: > Sure. How about replacing my prior "Register both successful and > failed faults in PGFAULT counters." comment with "To preserve the > behavior of older kernels, PGFAULT counters record both successful and > failed faults, as opposed to perf counters which ignore failed cases" Looks good here, thanks! -- Peter Xu