From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFBE4C6FD18 for ; Tue, 18 Apr 2023 21:49:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DFFE8E0002; Tue, 18 Apr 2023 17:49:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 267CF8E0001; Tue, 18 Apr 2023 17:49:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1094E8E0002; Tue, 18 Apr 2023 17:49:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F2F6F8E0001 for ; Tue, 18 Apr 2023 17:49:07 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9F2B0AC24D for ; Tue, 18 Apr 2023 21:49:07 +0000 (UTC) X-FDA: 80695852734.29.3897AFD Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id 7929F40014 for ; Tue, 18 Apr 2023 21:49:05 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NPvn3Y8P; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf12.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681854546; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JNM/PoaKdJVang9WqsbIURXjXnMB7kVw7Og7DK0+y/k=; b=LOcYKJKzEnbYBDPhzP4YLo8Sy+we+CfoGDBwv8sbnrHhelUaqtJZvBdZGFKE5PJeiy7nGb DDGhfx7g8GvxwdPtqCe4FKKsGnwaIjf7pVYOsueljQAEPSFD/cK7vMNX+bsWRWgPTNTz6X oxy23+czfuv+rcRxWIPNWXMd6XeE2TE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NPvn3Y8P; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf12.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681854546; a=rsa-sha256; cv=none; b=JHE/P2digkp+Ne97lB7dsmhNVw+7wWK05kYJoTdTct6MfUD64B/s9bnLLEScrGbsjVl9lA CiWUR58DI5gdRnnHv9a7ZsfzMu75IImKSNWbIni7YCOpu3mjCanprqEcnqGTHlrjOI9WdL 0fzvsN0x+4m2Piahss7G3aMO/M2YRAw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JNM/PoaKdJVang9WqsbIURXjXnMB7kVw7Og7DK0+y/k=; b=NPvn3Y8PNf9X253zeDEbvUCEMD gOA4qUsYzuP/RiqVYByAU8E1tcWRLyrDDPdWBL2v8THrJaQ+ArmYTwIZCrdc3rlybWppKyco44g27 QFkSMiHR1g8AawhfyR/Ml8/HpQFb0HmIsBORD9Zvl7rcHItkbCjppHyLtGMXUIFJOXlzxHZfJ7Wbz 1RU2UUvmvKQ1i6jgfcMJpZkfh+3gwGio3Rvb8cNGtgnT8dG4OUU9W1iFB+fPux3x5L8cyO8a+UcOK W7ipP9jQvBItWBIlWS9iv18T59zhMe832aQac7NWnsBI93CCWPVOgtyv+4h66HRM4t2N4eJ7Kt6yy zBFnjF+g==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1potC8-003RF5-25; Tue, 18 Apr 2023 21:49:00 +0000 Date: Tue, 18 Apr 2023 14:49:00 -0700 From: Luis Chamberlain To: Hugh Dickins Cc: akpm@linux-foundation.org, willy@infradead.org, brauner@kernel.org, linux-mm@kvack.org, p.raghav@samsung.com, da.gomez@samsung.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, David Hildenbrand Subject: Re: [PATCH v2 5/6] shmem: update documentation Message-ID: References: <20230309230545.2930737-1-mcgrof@kernel.org> <20230309230545.2930737-6-mcgrof@kernel.org> <6064b468-33fb-3693-54e-6f1f8d316f64@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6064b468-33fb-3693-54e-6f1f8d316f64@google.com> X-Rspamd-Queue-Id: 7929F40014 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 6yz4jam1xkymtatf4i691pw1cqmfzbbr X-HE-Tag: 1681854545-654249 X-HE-Meta: U2FsdGVkX1/rpR56rjrHIJv41SEZZpxkwhIoYq2+aK3XFcMUoPkmcTgfcH6vuEnv8vBRfJi80e+598uXLyG79LF0G/3UtKomn2qLc0ma0ALFWJ6mCDd8+Agn/ER6IZCHksbwCh/p6TDv+FsUTXUPxmQmMyq5XHtyDnlLyptBADL9f/mdN7U+UorcPnQqOVzYVSRh1EaRBZHD3aN4IYNtLm8fuJ2Rf05xDtmGkO4t/sLuaQLu6Wnx3rPBwN27LXHnM+tQiIVFgicNLnqcTHyIosYrImQ24DqQib/R+JP2qsPCw1geLlB72cNtvmm7QuYPPgQ5xAP8k0jzXtjoXkSZyzjMcq4Mr5k70jpYpQuld3eMM7F+3IpADQFdDcYo0bgBXikEaSZOMmqCBe5cECk/CFmw72Q9I5HN3KXUIBw+NUyyQ4yekkc6Ab3giVb7/uLytcRTTPw4/B/kNG3vp6SlMWiRX3NjLMXyfj5seLSZWZneez6jXozbrR9HBzqo5ihO1yeEPbnZfJrWXW1oMEAIAoOqktfZ3COoTkzg5QiMkcssMH4+o7RYVLDwJZkJwdViMsoOjc55tv7cRHCcvUFbpshnW+VEEMzl8P1mLt0ELFpylvUBoQHhQ33A1mIb1g5L9nquzw6wOo3uEo33SkLupG+fiJdfElBz0YIyLsiVsKHvHuzI34vNTIKMfgO3XH3IQ8PQ8B3/aOI/+AnuiQsElB7vI1wT4FC4UneFDoAKKCZ14xcCR16hBZB2x5C9khQm54b63XwEu82rAT18BxGMQu1MQaF03mesmH3JsxyjPJcafmLhomBbtN0uSLR+5gJa8t0dw2IYZjTkv2kx97pLH2hoEQGvPHKgnTzL7X7et9gK++kp1LCLpbhotkpjz+oeZH6gpbUTd2CD1lGOD1kLSMj/E01Sn45mpPS6GkIeuY8m8KqfRKdwE3OPUBt242k9afaNMP0qMD5KJFYwIWX 9Um43O07 fMY5XD2zXbxY7xt4ANBpMeCKlhI0GLMX6G6L9Km/r8Jzkbxr6YEdMYUXopj9vt3652p2M1jTZAi9t6Ifg8Q0oZfSmwwmPMRiX/4tuq1iIDnp8byH9QHsEkiktoPJmF/b/r5zEWdQRx6QlnPVQ52ylnsp2TMA0/S5FUGIT6uso7RuvS3+n4XHTJUuvjcoJqSBf1a1hQByYesdmrW5IDJMpfRASsiV3ONY/orpuTge7C3E0Y1sP12rUsFNI7echT53u96BCg7e5qS+5PvOnAF+hguLlcjrTP4PfxXtaXnMejnhE7YalWOu1MXNLmN82asL5Yyg3POzMUQdsRFs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 18, 2023 at 02:41:07PM -0700, Hugh Dickins wrote: > On Tue, 18 Apr 2023, Luis Chamberlain wrote: > > On Mon, Apr 17, 2023 at 10:29:59PM -0700, Hugh Dickins wrote: > > > On Thu, 9 Mar 2023, Luis Chamberlain wrote: > > > > > > > Update the docs to reflect a bit better why some folks prefer tmpfs > > > > over ramfs and clarify a bit more about the difference between brd > > > > ramdisks. > > > > > > > > While at it, add THP docs for tmpfs, both the mount options and the > > > > sysfs file. > > > > > > Okay: the original canonical reference for THP options on tmpfs has > > > been Documentation/admin-guide/mm/transhuge.rst. You're right that > > > they would be helpful here too: IIRC (but I might well be confusing > > > with our Google tree) we used to have them documented in both places, > > > but grew tired of keeping the two in synch. You're volunteering to > > > do so! so please check now that they tell the same story. > > > > Hehe. Sure, we should just make one point to the other. Which one should > > be the authoritive source? > > Documentation/admin-guide/mm/transhuge.rst has been the authoritative > source up until this patch, so I suggest it remain so; but good if you > point to it from this Doc - unless in reading it you find that actually > its account is wrong. (Haha, it refers to fadvise too, never mind that.) Yeah I'll make the tmpfs kdoc point to the transhuge.rst page. I think that's possible. > But the man page is more important than either, so it would be good to > point to that too. Sure I'll have the tmpfs kdoc also point to the tmpfs man page. > Mention the "huge=" option in this document, but > point to elsewhere for the detail of its values. Sounds good. Luis