From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB8E0C6FD18 for ; Tue, 18 Apr 2023 20:56:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 676508E0002; Tue, 18 Apr 2023 16:56:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 626898E0001; Tue, 18 Apr 2023 16:56:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 515A18E0002; Tue, 18 Apr 2023 16:56:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 41C7C8E0001 for ; Tue, 18 Apr 2023 16:56:07 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1BAC3402AE for ; Tue, 18 Apr 2023 20:56:07 +0000 (UTC) X-FDA: 80695719174.03.5BB9FA4 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 7A43E120008 for ; Tue, 18 Apr 2023 20:56:05 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="12T/Pu5s"; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf29.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681851365; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1gVMuS9EKtGcIRrRl/Odp4GU0naBD6jze+OHwpW6A+8=; b=GHcNm6c2y7QZC/Hb23O6o0byBZR+uEu0rhJck3nA8I0w/ls9p27fLSLukVxFuaq32EMmf9 x18Ia9kB2KkKQ4MCBNUVLBTTXceIKNkZ+ypML8U7+NCNkOramzj5yGfKxgBS8zTU4MtV1M e4gleaaEPVMyX6LLCmLycl11LhAXP3I= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="12T/Pu5s"; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf29.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681851365; a=rsa-sha256; cv=none; b=Nd9RyRzeFupFBJ0Eieqk0tNTSvNI7lF5diNHdOz3PkKxYICdtquqG6UsYVnLSKFfNZbeVB 5d2LjO7ERYaI8Il2TuX28i9G7aH9OcaXbj4ephHcEh7rHmZfQOKccmxC83qgS9FY7F6A/N lJcclZj/g0FsUZfqn4t302NR/gvTdM0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1gVMuS9EKtGcIRrRl/Odp4GU0naBD6jze+OHwpW6A+8=; b=12T/Pu5st14xkjhJxseP7HyJJC uAkjyI+P74hc0pziwUyn3cAHKkFtqsCiYzrMUrhyl3izViy2JyzRUAHK7xsJQ+2ASaSOcoqmxksgv EOGaDch53zorEiLXa1X2eY2BoaTQUd8mWYV2MXvPD3uMl5CZ2Fg+42Kdlzv9o9wNES7CmOtATM4Zl ZIkrwPlGz0kUg++EFgBS45SdSpX72eDWEZUzEEfz9uVJwdxDB6zDUHpZYpYg+WLrmKNYN6MiIH9N4 6E/oc2eXe0IqXgwv6YkzVMIcNkVNYkMpinIqHtNYSd9RnYwMDUG6G/QXm4BnNyxDNh9FibthM99up zjfedfNg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1posMo-003L56-0A; Tue, 18 Apr 2023 20:55:58 +0000 Date: Tue, 18 Apr 2023 13:55:58 -0700 From: Luis Chamberlain To: Hugh Dickins Cc: akpm@linux-foundation.org, willy@infradead.org, brauner@kernel.org, linux-mm@kvack.org, p.raghav@samsung.com, da.gomez@samsung.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/6] tmpfs: add the option to disable swap Message-ID: References: <20230309230545.2930737-1-mcgrof@kernel.org> <3382819f-4a4-8622-5642-78c03ecfb878@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3382819f-4a4-8622-5642-78c03ecfb878@google.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7A43E120008 X-Stat-Signature: sjiphu1dec7m7zwsk69agdqzashhoxss X-HE-Tag: 1681851365-277040 X-HE-Meta: U2FsdGVkX18rWqJGy0p2GX511iGR0xZo3+gvC6nVzH2CgpBPjvwt9ZloqRXBtLPcU98j6tbM7mjqdhER+E0X063UHksQ2mKtPRUnwKAoOWdLP5ROzPKxHPedw+3LnBXF+iA8b13G+q1qEcna4SLIIkTTLPXQEz/FqnTKqoAF17iyq3QtSMN/KiHYM4twywJPXkj9SB48Nzbbn3HcYJuxcJZYTHkAkUPtae8gi/4dJrWI0MAr3ei6g3dL536vUICms2tFHbPF2XJ2gFLtPRPWMTFBjp21LfAIB9Xt67DMEsLsPOzGFt2X6qNjiDNvRf7HzZJCWyBR7Yeu8MPEzsSBd0mLVCoo+idYhVEW4vjraKtYb5H2It5sYXTGs/oP3hRc/ugBpPHdylU06eXeTO0Z/GLaLH39mxGfUqEaZpmti/BGU6Fi8AGT+2Imi4ObdCY2ztNLvBnQc1d8MI8ZLV6sqcw6tvTs0lN7SIzvt6zZHH3FTgE9jv6Cj6HxHuBZbuFEDJ9aX7AFgxc5a04Y9jeztAdfZ+tnswFEPNrFMhEBS0u/MCMOva2C2EnoqYeU5ISSh+RDyxZqzHjOyT4DS7FwGt8PM4wI6TkNT3jhmWtoJj3BjFPxnf0xUoYG78860aRBUFmf8kg6r00zSL/8ED+KBOIXn+vsWuGshofJF2L2EcIurJ53EMMhLTVFliwf1FNUC2y2tYcEtvJhDSvRJC8/zx0gcpRe6JzXiO19uar0ImqxdLcFXXANsexWZXFRg7wPN/Ee7zSE13kymyjcXqzpOfFWUxmWf6YlqE5pM7WkN+G0YBVb7Oi7LxRP42MSZpyiQ4ubJ6VHWk/Tx0sAf7wBTw2Y8xDd8esBGn5Kk5ERIbRCsRW6CjssOssvYKcKLalNmOD7uYzkaXCIK+fyRi1MZ/d85AbLqKucHl+VpHqtcTSEDFuOOcGHVQzoMo9awBEYpHvyYyd3w75Z2HHeSnt 2sRWUlaR yq0pqUWAr++2gZ6vY/j2hM+zKetiiV/dfRPwrQ2jZLMFKVsvc3TLCnURFhyJFk9GQor7AtFv7otUXKBeffk8m0AjRARxljR5L/qiCrEfQSbUTLNJYpSPOrS6F9JLgG5w90z2pVe2dunhFWRSQkMnbRIeymBRgq3E4SUoXUE9xBJQypMVFyDx6oZlTWVxrw7F2ir1GCWHyTUddV91viJIu1KKjenezgL4x5LXBlfo4CDrfnn+lXZeGfp6ivMVZx7S1YPIr7HoNOZq/MnzzzjIIXhpL8vcyQHFil4SWvnUuQElpx/n6bhhMJGo/SugT34GHrVy7lK+Hn/9qnpI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002583, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 17, 2023 at 09:31:20PM -0700, Hugh Dickins wrote: > On Thu, 9 Mar 2023, Luis Chamberlain wrote: > > > I'm doing this work as part of future experimentation with tmpfs and the > > page cache, but given a common complaint found about tmpfs is the > > innability to work without the page cache I figured this might be useful > > to others. It turns out it is -- at least Christian Brauner indicates > > systemd uses ramfs for a few use-cases because they don't want to use > > swap and so having this option would let them move over to using tmpfs > > for those small use cases, see systemd-creds(1). > > Thanks for your thorough work on tmpfs "noswap": seems well-received > by quite a few others, that's good. > > I've just a few comments on later patches (I don't understand why you > went into those little rearrangements at the start of shmem_writepage(), > but they seem harmless so I don't object), Because the devil is in the details as you noted too! > but wanted to ask here: > > You say "a common complaint about tmpfs is the inability to work without > the page cache". Ehh? That was a mistake! s/page cache/swap. Luis