From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C7ECC6FD18 for ; Tue, 18 Apr 2023 20:19:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8E248E0003; Tue, 18 Apr 2023 16:19:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3D668E0001; Tue, 18 Apr 2023 16:19:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2BF48E0003; Tue, 18 Apr 2023 16:19:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 925218E0001 for ; Tue, 18 Apr 2023 16:19:17 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6E83B160320 for ; Tue, 18 Apr 2023 20:19:17 +0000 (UTC) X-FDA: 80695626354.09.F42C292 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id A07D6180017 for ; Tue, 18 Apr 2023 20:19:15 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VxSWuETw; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681849155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1d++sFtE7Oq9t/5+eFoUrAF5Lo6BArcFi0kLIZasLfw=; b=74WU/u3/4TFZXKNpznPAyvCkbFNl31ReaAnMrzZsm/iZE7LXcGCYDw6IBUtw8Bl2LqR7G5 w0+1mySLS7UWP+d/VFCdPMEyWNnLEcRwwjT2+ALkQ2PK5HogNWgKGwH6iF7+Y5zcaAuA6q zlRtrbV6EjaTOQWS3VaLDY97P9wNAJs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VxSWuETw; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681849155; a=rsa-sha256; cv=none; b=n4ZZf6Vo689rZx5lG72AikyXCZrW0dH7G5Lbf4MJ4yIibMifPxI3y3P2VdfJBeo7T7XSls n2awF3rHw007c3o32cHIPMTfA3U+6WhRjLLoWWxYijVIW+Lz2L5cKqPaNPnxIc9yPNJ59V AeFvUJbb74HeuJyaBjWIBOCHKE0JT0A= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BED3063579; Tue, 18 Apr 2023 20:19:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A15BC433D2; Tue, 18 Apr 2023 20:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681849154; bh=818LBOx4Bv0tTU4R6fF/F8RgUh8+pLOLseVWoDF04Mc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VxSWuETwBuSPN7KR5ksPL4CeNNoZaPHeQX9xFxsbjuYNY5Ibx/tYwBgIBdeXos4eL vPl28hymPjO/NUqY86TbVyQWGIB/CmkfSreKYBqT8iNF8khdSUiLIdE8IzNfimQcsq 0bN1VLPGn4Ep/JH8ndPdU71z/NImVpjwWdQxQrS2dcpLHVBLhQC4etDmwIIhNzJbQ8 84h3wrJ1IjbkrHmI0PAt62hXXRb9+VpGeAMGdVwz0tEiGK+g1l4rVbpCjKKNsh3cgD uyxfXEY+DqY0UpASqoouTKWRLY3yN2FsBocpC8eSkpukcgNyZQqcOc6cJresUq6vMu bMp6aAz/r716A== Date: Tue, 18 Apr 2023 23:18:58 +0300 From: Mike Rapoport To: Arnd Bergmann Cc: Andrew Morton , Arnd Bergmann , llvm@lists.linux.dev, Vineet Gupta , Nathan Chancellor , Nick Desaulniers , Tom Rix , David Hildenbrand , "Liam R. Howlett" , "Matthew Wilcox (Oracle)" , Suren Baghdasaryan , Naoya Horiguchi , linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] [v2] mm: make arch_has_descending_max_zone_pfns() static Message-ID: References: <20230415081904.969049-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230415081904.969049-1-arnd@kernel.org> X-Rspamd-Queue-Id: A07D6180017 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 11kbxidshwtp7fw1jfub65b5chukn8cj X-HE-Tag: 1681849155-830274 X-HE-Meta: U2FsdGVkX1+S1Sq8aT82W3MjzHzxFCmNiMJB85Kn24amo84AoQqLge+/KebtARIfVSCdBl9qPl7JCY6mEfvt13kce/4QqABFNkqSqGHdMyoVfENrWLil8WOsThkPD3cn+tWu+hbF18yJh8i3EZhq9I/PRFFD2vWa3wOGtzfIRhEosCfgixNCy2gOx8swR+2fppaEm/Cy99FA7FJAlA6b0Y8ABYSKjqTz669lgXQaBUCFvDnepk1zae1zrXdYD491fhk2yuy0nSbezGKLfxF9urKH8TTZUQOswYiI2GJomBRBzaMp+CVaqrPCRn/rxfkatvso/FiRz/2vvCNf8rt+1wnDW15MAuj+2kAKQdPl+0TPLj3+lsVlTdmpJr2DgxlqjvLtflikVwMct6JNT/90pkawai7CqGdDCjgpHaZo9aqgPWaeEdSRiILwOgHVOZAg2UIHLjWicRZX1jpZ+rzPpqEKSDNMFdTqBx4VKRkYByfOeCneafKXKhgMZdFg+zmBTwKThGTIujfbOk+TYukOYYe+cKsuQvlrjSktG+hknWeOW+7D5XL+ns9a4R1SvQIZi4cIYKHWDa++nj9QR805d3Vqgs1a9YRC9xxlSQoHq9sDd527fEd7TZvKa/Zj413EVAf45zAXaUs/44xxeFxtzhfEMj0+v3WbVufiu5h9vTkWjWw1W79JeisfnKYLpy3BAr393LtlDRnM0LXa9O9CWHqJK/Jy+HEyFZbK0X+RQ/u7S27AJf+Ylt75AL3LeCrdABkI+jZlmNSsnVAH2sseVWZAQnrugFEjed7KMg7oVb9d0Vodjb9+kxoAjz+cY16TbGXrJmejEITZbD9w71XwV3myJ0kGHo1klSSZf6o5YT6eXOf9bJZ3FUtjB217Id8m+jFKOTxLmaM5q5rCc7oECJEcn8AL94k/c6B6l5KVylu3eRY6fnwqh5tPlhTAm+UIqy2YBYTBHO+kQgooWEM Mk7YCznS ZbRz9cl8JUnmn9gIbz7/vIOHeiHlhxeELjakLU6j2/0NuVomR2HZGqMFj79/iAOXbRzm74YF+Qut4oe+ZkyHCLyp40D4kYgXwGyrfKH2XsMNwIACMtVe+mrgioTJhAyGGjkCK7BEHJFVOhl0vdQWlDRorqZoR2DRQ2OaepKWGFc5cVUoWF5Dd04CYmcFs+ybdzV/bfWMhFan1qm/iJFIufRach7k4p1ftVZwN/WdJ5iQRT8/05Ra71B55QgfLuFZNl2RSHsuwU979bzVmRvEPQeQOemLARXpkX+WCAAdsMNru1jKAI6LRUWrSGm8AacEWlfryw8YGJnXinoZgvzwNj3Ewo7Mm5KYpJoKO78HfK9PIirCGRLPzuS+fOPGyMWlObzhKMyNzFD6oBXROZXAKuVqFNArL3MPEnWc018umvKO/Cm+TPJrrV46CFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 15, 2023 at 10:18:20AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang produces a build failure on x86 for some randconfig builds > after a change that moves around code to mm/mm_init.c: > > Cannot find symbol for section 2: .text. > mm/mm_init.o: failed > > I have not been able to figure out why this happens, but the __weak > annotation on arch_has_descending_max_zone_pfns() is the trigger here. > > Removing the weak function in favor of an open-coded Kconfig option > check avoids the problem and becomes clearer as well as better to > optimize by the compiler. > > Fixes: 9420f89db2dd ("mm: move most of core MM initialization to mm/mm_init.c") > Cc: llvm@lists.linux.dev > Signed-off-by: Arnd Bergmann Acked-by: Mike Rapoport (IBM) > --- > v2: fix logic bug reported-by: kernel test robot , > see https://lore.kernel.org/oe-lkp/202304151422.5e4d380b-oliver.sang@intel.com > --- > arch/arc/mm/init.c | 5 ----- > include/linux/mm.h | 1 - > mm/mm_init.c | 4 ++-- > 3 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/arch/arc/mm/init.c b/arch/arc/mm/init.c > index ce4e939a7f07..2b89b6c53801 100644 > --- a/arch/arc/mm/init.c > +++ b/arch/arc/mm/init.c > @@ -74,11 +74,6 @@ void __init early_init_dt_add_memory_arch(u64 base, u64 size) > base, TO_MB(size), !in_use ? "Not used":""); > } > > -bool arch_has_descending_max_zone_pfns(void) > -{ > - return !IS_ENABLED(CONFIG_ARC_HAS_PAE40); > -} > - > /* > * First memory setup routine called from setup_arch() > * 1. setup swapper's mm @init_mm > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 63acf4a598fe..75d8adce0aee 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -3061,7 +3061,6 @@ extern void setup_per_cpu_pageset(void); > extern int min_free_kbytes; > extern int watermark_boost_factor; > extern int watermark_scale_factor; > -extern bool arch_has_descending_max_zone_pfns(void); > > /* nommu.c */ > extern atomic_long_t mmap_pages_allocated; > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 35302b7bca83..7f7f9c677854 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1754,9 +1754,9 @@ static void __init free_area_init_memoryless_node(int nid) > * Some architectures, e.g. ARC may have ZONE_HIGHMEM below ZONE_NORMAL. For > * such cases we allow max_zone_pfn sorted in the descending order > */ > -bool __weak arch_has_descending_max_zone_pfns(void) > +static bool arch_has_descending_max_zone_pfns(void) > { > - return false; > + return IS_ENABLED(CONFIG_ARC) && !IS_ENABLED(CONFIG_ARC_HAS_PAE40); > } > > /** > -- > 2.39.2 > -- Sincerely yours, Mike.