From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A26C77B75 for ; Tue, 18 Apr 2023 03:38:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8B0F6B0074; Mon, 17 Apr 2023 23:38:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3A926B0075; Mon, 17 Apr 2023 23:38:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D50848E0001; Mon, 17 Apr 2023 23:38:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C45FC6B0074 for ; Mon, 17 Apr 2023 23:38:49 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8EF9C40459 for ; Tue, 18 Apr 2023 03:38:49 +0000 (UTC) X-FDA: 80693105178.02.C67CA58 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 6D2BBA000A for ; Tue, 18 Apr 2023 03:38:47 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=b3nBOLBu; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681789128; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HhlSV7mwlecSkzDT1ht6NiuOggNho9wGWb49Qm4q5Uc=; b=B8ULTMDKXS71uIOiiA/lZgLc8dT0uuHk4jzn6P9qat9jSQ+um3qSb9XF0KtP2zeP7qtjYv la4fwhjOqI3ouccKpEUrH6r/RwH9oRfZ4cYNDjaTHhqNKwWTAm7VKw4+M8XA3X6262dMcj wzUVcwx/oudYktu1ujm8xTFM5TWS17U= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=b3nBOLBu; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681789128; a=rsa-sha256; cv=none; b=j0F5axkbuxizJW1G8TH2YpT64OKpsmhCurglOq1yoJp1yOxlQ+zbULWTf4k5isWv53LGtr YIgn/b7kDR+XUHCMCQa7tBuDdLgvLyfdS+p5tfu1Ypa92u6HBl2dHSYTQ039hcMHrRxJo4 qBv3OuCheHn3qVJBCrOylMddTRfkOSo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HhlSV7mwlecSkzDT1ht6NiuOggNho9wGWb49Qm4q5Uc=; b=b3nBOLBu3U2OnswmTGhD7y78cn njYxcT9bJC8E58gdiYUDpwiWjn6Swl7NwuIxeoy95MMxeY1w65jMh6W/BT2FZTX5vRBbnnb7Ytm/F 1VorRdyadHj+qadmUYVjf+qyOQU84SYCEM0um+cSEq+GkTUid/ygFXdKoZQ6QTdWZYCql9kt1VLaw oRrA3b8RBNarmlM7rgM48n7oRab6KU+JnDFMqjYIJhWhRTY8qPk4OkqW0zFAWa////CiyZOkLNqhw bGlzhMVpwZ8irdZKuFU6GFlubxEas5Bx4FzedOEtkWjR33zeAh6k1QOqFGDtrQH7fTEyojwcuhu3w IuoxQnOQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pocAi-00BvyK-OA; Tue, 18 Apr 2023 03:38:24 +0000 Date: Tue, 18 Apr 2023 04:38:24 +0100 From: Matthew Wilcox To: "zhaoyang.huang" Cc: Andrew Morton , Minchan Kim , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , ke.wang@unisoc.com Subject: Re: [PATCH] mm: fix printk format within cma Message-ID: References: <1681788789-19679-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1681788789-19679-1-git-send-email-zhaoyang.huang@unisoc.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: oemfcux35fr5b3rf71pyq6nkwj5ec8kn X-Rspamd-Queue-Id: 6D2BBA000A X-HE-Tag: 1681789127-676751 X-HE-Meta: U2FsdGVkX1+rhrTrqSS4wUcaxLISCWe21mPCvDQ02J72NaSyUNN/1kzN5Y+v0/bvZYNDUxkbCSbDH5uidzaD0gims9to5oqOGrO3P3tqt5t9CfPXEhNnho2TeffskAnh/4jtfC3kxj8BWUygZETOfqiLJrISGoCX6wNMw003aUu7Jmi2bNkdaxhGB+RBLza9ZgQXjxvc/xLiQKeb+sgL1ragZPhsQ2ZkWGmGQpYuFS49gQvI0VDDmwjfIKs7Cjvd17DGLzUuKsPYQzbihE+YT9j/ZOfw9T8a3if6HL37AJT4kFVtYpbKAyGE+ef9dd5G/t9/b/73VhP5HosYgJDM7/PoZjysOeq9LUHb9+bOnBnyk3BihJCnnbhE/GmJOD9J0TtCyVNwyo5/qVHee3/1yLABpESbhUu7iL41eLlPxmj6qKHePPu/cYHvzlbvOe1EShvJle6LyS34430HF5lXso2fyL6Yq8niwBMeFTfAnXCVFT64999FXP6UG7SdnGFB3VrQdkbe0Z9NmIXNT+dw6FHa01xS3gxwZ6oSPVKuMSMNJGhveDk1a54qtWhlehh+zmLp38FtI1Rrsl8HrRpYOsQzPGjTS6dEO/iJQcUUpAMg36CM/q6TAI8Bi6bbs8SuvzsKPf2MpruWVlvR6mfbSjJcNQ5hLu6W+fITZanWFNnEk5j6g2mxHyLxVwRrNM25iJS3SJSXTe88ld9B31YjJHF9xPKItxV0ETcuN9ooYN39MpYaOodCpnBWDITJRkY0l9qAc2Gty7Xgn8SDUmjtiUCLB9LhslGrLjKkL4rg1KJC3rOYAbAAX+hkMsnxGkRQAxcOQpx1JedZsuadII85mrm6TZ0J8bnC/qesEcZDXq2sVEnMjTYvDSmVCgZW74eJD3OHB96HMS5uIE9Pt8bOhHYRSn2ipsqiOPjmGxPp4pX2je1kKnWTcXNz0554rOQb6RI0IBXFSJbCqFEHdIG 1vtsXhbr XU8URvyrYMbEpr9eoOV4U/yLB3GlPyRTejlcff0Mk9Ezg5C1X3axi72OVrQMt6obfMco3g/VJqtw3HMAI0hbytDY+QV8/5EwSvtd22v7NDHOB0RcRGsfHVwqwQWiETUPf/KD7dMhaALXCoBOwmbqVcfpz0cfx0kRnnexuF6Hwx8i/hlf88lmVMBtt8m2h49cs074nqk2bD9MzdBUsYA1m6W3iGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 18, 2023 at 11:33:09AM +0800, zhaoyang.huang wrote: > cma and page pointer printed via %p are hash value which make debug to be hard. > change them to %px. Why does printing the page pointer make any sense at all? Surely the PFN makes much more sense. > [63321.482751] [c7] cma: cma_alloc(): memory range at 000000000b5e462c is busy, retrying > [63321.482786] [c7] cma: cma_alloc(): memory range at 000000000f7d6fae is busy, retrying > [63321.482823] [c7] cma: cma_alloc(): memory range at 00000000e653b59b is busy, retrying > [63322.378890] [c7] cma: cma_release(page 00000000dd53cf48) > [63322.378913] [c7] cma: cma_release(page 00000000315f703d) > [63322.378925] [c7] cma: cma_release(page 00000000791e3a5f) > > Signed-off-by: Zhaoyang Huang > --- > mm/cma.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/cma.c b/mm/cma.c > index 4a978e0..dfe9813 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -435,7 +435,7 @@ struct page *cma_alloc(struct cma *cma, unsigned long count, > if (!cma || !cma->count || !cma->bitmap) > goto out; > > - pr_debug("%s(cma %p, count %lu, align %d)\n", __func__, (void *)cma, > + pr_debug("%s(cma %px, count %lu, align %d)\n", __func__, (void *)cma, > count, align); > > if (!count) > @@ -534,7 +534,7 @@ bool cma_pages_valid(struct cma *cma, const struct page *pages, > pfn = page_to_pfn(pages); > > if (pfn < cma->base_pfn || pfn >= cma->base_pfn + cma->count) { > - pr_debug("%s(page %p, count %lu)\n", __func__, > + pr_debug("%s(page %px, count %lu)\n", __func__, > (void *)pages, count); > return false; > } > @@ -560,7 +560,7 @@ bool cma_release(struct cma *cma, const struct page *pages, > if (!cma_pages_valid(cma, pages, count)) > return false; > > - pr_debug("%s(page %p, count %lu)\n", __func__, (void *)pages, count); > + pr_debug("%s(page %px, count %lu)\n", __func__, (void *)pages, count); > > pfn = page_to_pfn(pages); > > -- > 1.9.1 > >