From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38516C77B76 for ; Mon, 17 Apr 2023 17:53:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A35988E0001; Mon, 17 Apr 2023 13:53:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E54E6B0072; Mon, 17 Apr 2023 13:53:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8ACDB8E0001; Mon, 17 Apr 2023 13:53:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7706D6B0071 for ; Mon, 17 Apr 2023 13:53:32 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2008BC01C0 for ; Mon, 17 Apr 2023 17:53:32 +0000 (UTC) X-FDA: 80691630264.15.A925B17 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 01E8220006 for ; Mon, 17 Apr 2023 17:53:29 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Z3UolhRn; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681754010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tAQseiBOvTaWYKwBOg/JW/PRr596E4na6qpBjVgO9oM=; b=29tupsR99RYY/EShKHo1ytqh/E66rmZ5kaBblm/gDl0V12ofpyYokhefD7Z1EL5IWExWyl tL54E4OMzQsG9bjd3bmj7AOD6NshCpYKAdm1B5ZZvDcUFyUdO7aWv9AL8r/aA8MtE3Jw10 ZqduDBvKZMO2CY09b8tZRLvvSx5YUw0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Z3UolhRn; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681754010; a=rsa-sha256; cv=none; b=3LHvKzElLI6mUhVg6kiu8n12tAq0RE4EtspXoA2gjJCXLUgE5ioE6JvcETkNsGkVUe8ZC6 CZjNTg0qTEmwf8V0DTBXkoQhJblGv0efrfHZMeE0NIpj3YIcTIX09t3JKqupDSPnYPRzW2 Y5Hy09wc3bvtfQ8Oqh1uBI3OGOoSOWs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tAQseiBOvTaWYKwBOg/JW/PRr596E4na6qpBjVgO9oM=; b=Z3UolhRnMkYgfJnzKd+YNFqAQw EXkALI6DwvdyOG6aOHbcymPWnBar+5oxelgEzJ8Lm05oGwDBCLrQmdr1z/rFeFAaWtiWSi92YyoWW xSqcERbHfTZJzneJQe9MaXUWh5onfj6kTmrJq+9O5x5Xct/T2n0LOU0c/xTok5HKQ9dPAkjBBeWVc HbwmXGBvi7xjFxrSX75ONtCuAHt6biksi4oSQ+q8VUch7w3iW7zTTQvCGe4Z3Fexea6qdSzggnYPk n+LqtzoTJJJjDeoNs2eCi1EpvDP+QymXgsLipkznldG8DYOzP4/SYA5/sBtTJqcBrz1nq7saCeva2 GZAZ9jgA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1poT2a-00BYN3-52; Mon, 17 Apr 2023 17:53:24 +0000 Date: Mon, 17 Apr 2023 18:53:24 +0100 From: Matthew Wilcox To: SeongJae Park Cc: Vlastimil Babka , akpm@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] mm/slab: break up RCU readers on SLAB_TYPESAFE_BY_RCU example code Message-ID: References: <20230417172657.21925-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230417172657.21925-1-sj@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: bxz9t5eak9f77scazogqqe46ztjsutyf X-Rspamd-Queue-Id: 01E8220006 X-HE-Tag: 1681754009-183416 X-HE-Meta: U2FsdGVkX196vK/r4CSaaoy41iWVafpqd+O3smsVxTwQ1WFToJkUUf8O9yLwqJtmaLMR8F8MSt3XgGIxh/SNLBSSjY53nk1HDMuBQLePSGZDq5//U9V03nNOMQK1nElp3qnzE3TCKv0G1W5y5KrPKPGi/1Uy954Bh8ikwqFHpF0YqeoLJlHXk1aG9ItAcU7mJCYiol+Dhoxp97udxRdvAx4XLYK97T65w+IPh/n2qtmRxmhDx1a89DHLGcW68I6ObXyIeDgEs6sS4TpfLyvuHH6nIq7WaUwx4eBxQfRiANZsPSZhs0mvg/HrN/emYQwAFK94LmadmivKw7igVnMeMOae6jiLHKt5PJdJO6+VqVZ/ebTs+n4SjRJ5KMWfJlwuOgFtRGw1do8zrdd6g742yeKZVQjUiiKQ9Cwhn6CVTzqu+c81tmmQc8ege/0cOk8s1MDbo4k1R3SmTsfg0cXmlYHPbuDM0m02+hi8Q0EnEKZcppGxzUZUBfIlF6cmFMxmvbLUuvAILEJQgvfmonu13H3t5T7C7vcGkrz62ZYq507EE6VZ9exQmaCkaeycBc2BlpLVzdoU2YWTxTRNbplKv1BA6ZQ8YTLR4vigHxSzIcv19Znt+HTUa+quy4FdveGdCTmFmBiJIDhemue2dPogdsZnYAeiqGJW8sIdI9THemoASRQX8oKrO599c29/PbLrkeHlibryJ8/KdmhtzsJwlBkjvLKvwnn8w+zRe00HBodtd5aiW6aJI7wh+usbt8851JBp4IO7XXdrLYp9D2mQOPgpXMIHv1Uk5qo7EdSrzb70vrWG9k7Lmrku84la48FLL5c4jZYeBqjRHIo9A50TKgueofIGwX7US9Ugea7V7Uafprejpan/X7VHnRu8HJKb44FOnLe7SjO+jBP++GjNPWKbTiUnQV219q0l9U18NhEEAOd6QpA4qkyVfPAMH9TgKK5pYVcc1v5nBuVsnRw rbXPtit0 guLUyKyxmLEgC80G0iRZNl42qsIcnJySnRRazErmM+fbjNGrqmSU8T8z1aCI6DoyUL912pWOuxfcAebhSVMjjCfX8O5R1X0B9hR0u1JUehiEke8cjZJzgHdM3gtHrJLT+sIrxv4w0l8YdwcU8kA1MBXomKX3S7U6S/xDnxNb8bxX6OxXeKnWHBI2F0bvgLwp7bRCNZURdppOp75c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 17, 2023 at 05:26:57PM +0000, SeongJae Park wrote: > Hi Vlastimil, > > On Mon, 17 Apr 2023 13:05:40 +0200 Vlastimil Babka wrote: > > > On 4/15/23 05:31, SeongJae Park wrote: > > > The SLAB_TYPESAFE_BY_RCU example code snippet is having not tiny RCU > > > > Since "tiny RCU" means something quite specific in the RCU world, it can be > > confusing to read it in this sense. We could say e.g. "... snippet uses a > > single RCU read-side critical section for retries"? > > Looks much better, thank you for this suggestion! > > > > > > read-side critical section. 'Documentation/RCU/rculist_nulls.rst' has > > > similar example code snippet, and commit da82af04352b ("doc: Update and > > > wordsmith rculist_nulls.rst") has broken it. > > > > "has broken it" has quite different meaning than "has broken it up" :) I > > guess we could just add the "up", unless someone has an even better wording. > > Good point, thank you for your suggestion! > > I will apply above suggestion on the next spin. For the last one, perhaps changing the tense would have more clarity: similar example code snippet, and commit da82af04352b ("doc: Update and wordsmith rculist_nulls.rst") broke it up.