From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A345CC77B76 for ; Mon, 17 Apr 2023 21:26:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15B108E0002; Mon, 17 Apr 2023 17:26:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10B3A8E0001; Mon, 17 Apr 2023 17:26:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3B848E0002; Mon, 17 Apr 2023 17:26:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E09058E0001 for ; Mon, 17 Apr 2023 17:26:11 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9DB311A046F for ; Mon, 17 Apr 2023 21:26:11 +0000 (UTC) X-FDA: 80692166142.08.AC2E53C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 8B10312000F for ; Mon, 17 Apr 2023 21:26:09 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BPKEmPTA; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681766769; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+iUdFnPPW5Cjo+Wv9uVErEgS8kkVkrl+5T7LT3zMOPQ=; b=1nGI69Q9mhAFETGq4+2C4cMEm3oyfIPUwwbmgx5WV7DgQCfNN769ulH1WVjV1og21FA8tf sPMeW8cbAIvIBThYeuGO+xlNQCuI+gv1c/7u5rQjWsvbS23X/Pp6GKZ8H7KHFcHhwnInYr fYVuaAq6vEqFTcgnswqmrawFUX7onfY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BPKEmPTA; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681766769; a=rsa-sha256; cv=none; b=QTWtJHotqDqmEuXQC+upEmth9jr26Z8qgACCDACXjPc4OOkPF3ZAD7UaRX9FI7wftySEhC hnluRiEWmZG7VwB7JpEaLB35iY7WiTRP0QX7TDAlZgdg0Sc/5XXRCaoh6ALn/qiarKyLSO 6ak86+7QmxM/6o95PU9qO4Wwf52G0bQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681766768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+iUdFnPPW5Cjo+Wv9uVErEgS8kkVkrl+5T7LT3zMOPQ=; b=BPKEmPTA6imjDbkb/AoPdNUrU+XLbfq7Lt/WM4E5HBo+3RR1GX5iCWN6ADAGKk2MCf368D HodOdxH1pTQgsXqYGYZ6wJkMdHXBW0WyiTh3G/UIxKPJBL2b1Y6OZrFL6tMrZNJ9dCAak0 fMYyOlW/Gf7pMaRPC3AmZO6hdgpptkk= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-151-gxycidWgPH2qF8ETRl_QxQ-1; Mon, 17 Apr 2023 17:26:07 -0400 X-MC-Unique: gxycidWgPH2qF8ETRl_QxQ-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-5ef5fbe2cfaso6172376d6.0 for ; Mon, 17 Apr 2023 14:26:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681766767; x=1684358767; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+iUdFnPPW5Cjo+Wv9uVErEgS8kkVkrl+5T7LT3zMOPQ=; b=S1euE7x7rreOajKzWaAGjADEs0WK7uS9uyR2etg7XgdFwcRs245ssnv5O+eiUudwHX CH+YzfAdK2ioka/pALRHMTL9n7mN5pdp1+jHyWib8pw0rVO91wWSaD/AHNgA/WCtzzk6 xYaituSDpcQm++m2Dn4FtLB1WQ9zezQMv16jURmp2cOnGhRtFy0hpiW+l/1vu2pmAsPR PS3VnsRtc6ou7KN+RuiIDb/DhHZ9Uxni4ofwCxLMZjC83TsCjqUVTiWQ1cqvF9J9Tx9g stxkPZNhHEt0N3a+LcO0F7KJQ4nqh0hEzHmzQhyl2MllnV9e+YIF7JCYwSj2lBTJ29tW zedA== X-Gm-Message-State: AAQBX9ctjKP1k5gqyn5PFtjLBw6fw+eeUYPoSY8m62R3ZRT+igGuDb7N r4bjA/iR80WYqpqdokjU4Zj3cZoZv6+zhXIKLV/dRVrC/HC4r9MF6gyoR+Oqb7kHs2To27SdB+Q cNNLHivg5bmI= X-Received: by 2002:a05:6214:4114:b0:5a9:ab44:5fdf with SMTP id kc20-20020a056214411400b005a9ab445fdfmr17548927qvb.0.1681766767257; Mon, 17 Apr 2023 14:26:07 -0700 (PDT) X-Google-Smtp-Source: AKy350bvmfyActz0XucL8uBTGsMXoULXM+Q4SGkObq+luJMUHRHs+pm3taS35Ybk4Jlndg31eEXu4A== X-Received: by 2002:a05:6214:4114:b0:5a9:ab44:5fdf with SMTP id kc20-20020a056214411400b005a9ab445fdfmr17548909qvb.0.1681766767032; Mon, 17 Apr 2023 14:26:07 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id dw17-20020a0562140a1100b005dd8b9345cesm3274332qvb.102.2023.04.17.14.26.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 14:26:06 -0700 (PDT) Date: Mon, 17 Apr 2023 17:26:04 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries Message-ID: References: <20230415000818.1955007-1-surenb@google.com> MIME-Version: 1.0 In-Reply-To: <20230415000818.1955007-1-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 8B10312000F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: z4q4og1s7x83idhrgdp15qz71qog9f5x X-HE-Tag: 1681766769-970346 X-HE-Meta: U2FsdGVkX1/CiUPBnJ4D9r9O2ug217cImYga+zP02LII5ptjvK64ocMoBUn7UVbn+daCYSy4IYKaVpqQpFVTBh8IZK7leIKtiDkrmDOrRWvT018QLKv8/2ggUvesgTshFmOQRhDsChEV0euz5+pc92mWGTG6HkSEBT/q7syHDPcywSJDyFsa9e8DxGXLcuAZvl3xxKPDsJhN3mE2SsgyUYP7hRORPvfYhjDUJpLSia8Ade06VwJG7zhA7Rn8rBZ9kL/DmuO3pQGWf6s2t0bIKByR84dX8e5cXsUTPwyNp3fhFXHnjTqK6eAEfYWGVTpogFU/1v8SAnWMfl5UeJvkT4ACvqEU4OJJKKibeEXB+K291XlEGoLOH3cdY1QBNxsSonDjWgPmN4rUdAgGTlFaNRKhdePatPIKbovFez3TLcyub97yGjFFrfmxMja+flc8/3XFzUJBzUtsWMFZk5ORgHgXEXak2NFgddc0L5xMahVXiaIKPTuR4WC8r0VwP9juDxXUedcVfz7sfuQQhkwbTXpYk3sar2DK6G2gsQkveqBRSJLyRAPFFSQgrH5LHzgbi2vGmpj2G3ldH+8HkxDO49s6DxHQs7QaYs5fYNwDu3Hd1dp5AJn9Wcs6lVb1d7OoKGcZmjpU/qOuGAHX0kHOFKyM288rtWd30aeqmhbhn6VXg+4uKRRF/XbpgVkJMrH0esTU7JrAK+5IeJrCh0m2NrlLdR9N3uIL8wGJX6n8yWLMevZSRZYZw9uDaW6mpwk0annIvJeKHu1clYUD5jDis6fJDpAZBhTwA75SNFxC1ntw2JFt8Ro+kNq8Cj+UEXVrGiAGBYoMWdyFM7T4B2ny6x72+6IGstKbqTGjNbKsaNNVskIVtCaXPnQw+x/vDNEzH3kHhM+WLrzQpA0RBgutfTWFLMrc7P5DZJVeLcy3lVrgdqJ/XGaBCdJMicMXLr2RGTv43q8nO83Sw40AENU H1/RCBip sgcfCUqWxa71hvAm8kPs9XjBBCYCuShGC01GxszXV3FTwNwu2uxPHYLiy6ZXGqawlpklZhcoVZ3CL1wmY7jtKyHF/LZXOFAbBiV8WeUjfqOoEYf/feXCqeq1+6uYlTm3CUjX6qJ6nbKhYPwSsVAe5yRqHS+5JPlcplrtcIRCeSUHAQXoQ60dsOtJvULHHPMvZFANIkpVsK7n4/lZ/JyoTk1a/NrliyfcZcLlm8/ToAAr1q+UhOuCmUut6Bm8fchXuEOpixOLZvd4LNdg3IV1eboYQa4hpXtHR8OnELcMb6ZAaEv95uyWOcga5UU4qe00RYwsQjCGlJWAgdiBb+NfDNqlzR2uoRwJxM4CxYQEBWpYEeHr9imfg2a3F4Ie6GXoBEoZ4JXCd11v2nIfw8RlLocCMcw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001059, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 14, 2023 at 05:08:18PM -0700, Suren Baghdasaryan wrote: > @@ -5223,8 +5230,8 @@ vm_fault_t handle_mm_fault(struct vm_area_struct *vma, unsigned long address, > if (task_in_memcg_oom(current) && !(ret & VM_FAULT_OOM)) > mem_cgroup_oom_synchronize(false); > } > - > - mm_account_fault(regs, address, flags, ret); > +out: > + mm_account_fault(mm, regs, address, flags, ret); Ah, one more question.. can this cached mm race with a destroying mm (just like the vma race we wanted to avoid)? Still a question only applies to COMPLETE case when mmap read lock can be released. Thanks, > > return ret; > } -- Peter Xu