From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 648E8C77B72 for ; Mon, 17 Apr 2023 13:02:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8D108E0002; Mon, 17 Apr 2023 09:02:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3B178E0001; Mon, 17 Apr 2023 09:02:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C036D8E0002; Mon, 17 Apr 2023 09:02:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AF51F8E0001 for ; Mon, 17 Apr 2023 09:02:03 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6D1661204F6 for ; Mon, 17 Apr 2023 13:02:03 +0000 (UTC) X-FDA: 80690895726.01.9431B33 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2089.outbound.protection.outlook.com [40.107.92.89]) by imf30.hostedemail.com (Postfix) with ESMTP id 719C380019 for ; Mon, 17 Apr 2023 13:02:00 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=FbCtql1U; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf30.hostedemail.com: domain of jgg@nvidia.com designates 40.107.92.89 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681736520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=szPw/8osvmIcdPOk8gasD/fEYrOR++nVJ3WBNv+WaTE=; b=zuXD6Z5GsVOtZZ7syie2Urry4ZzHfoAkEc0wiRyAE105zvYvgsjwiPdRkpJY9nvsZJcVA9 20fSJaeWZF6/jSXC7pDciIfdR397G/aJwlXY++r8ViTJmCopgyW1OTOAVV/FIIe0xXe3Ic Vqfq2Nzi9qHO71w4oHAm+YuOLeg0WGQ= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=FbCtql1U; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf30.hostedemail.com: domain of jgg@nvidia.com designates 40.107.92.89 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1681736520; a=rsa-sha256; cv=pass; b=jr9NuSLZ1rGpC1Mr0SYP+dMVJJgTAkgTJJasi1tn0SC39McesXgZ/0nl34BlAMermsD7XS Iewm1Gfu8VdKYEiFe45oOcdp9UQIHqUH8utPDcIE4sebUOm0hPX7OhyluLhOveaX3o1/75 X2HH5O/sUTDBVwuAnTLZnrd6xuTD2ok= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EhhyV4d13AZi9hBxZu55PrxB2nRjfTjwwFM4jXFO2s7GskpYPyEA6680kaea105jFyg4zukjzl6fGBnDNci7H7ALDslkYbfHajhQM+biKJiCBejL2hWZw30j9uR7bLrddn2FnS1UPTOKjkMlnKChzibUjscMrcjfxRG6sWGM4EPtT1G96xxXmzblF3MQL1R5uZrNeYhSPc5v2Ei0Cw5MSSWDRSLanc0BPFSIl7YMD7D6OyMJCE6y6uEBpuQjG8MGErguGJ3VJ8bYYLKeaXvhqpXF+P70OQ6KRdOZfpIFoKeXcGyaDGc4MHBeCdowmEXZSs/m/RbrQJ5bUkDCCCYnUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=szPw/8osvmIcdPOk8gasD/fEYrOR++nVJ3WBNv+WaTE=; b=PUwE8zjiqGIvhVg/xIplvvmtYTFI2S3r/2BHUbVKSjVsGkUph93hqFoHEVky/z3GiNI4aaW94YRvyyC9XlKAHDgQfA/kypBMx526eQynN6GT4SjYIkKe+0BXtnokhZWCV9VmGciwkx4yuy07keHIzpAWviwVMJBayHT3t4/+8CywB4O5SUtSOn3DPaadD8Spe7xLVJBxNMqfp5i+70HRmAhOGnX8yi0Im04L/9f6zykB4daDB48XvdcyPR9yC0eMbE6iXow6pAvkyfJDYZXka87r8G9AoDSM2UHMlZiH4pIaRkGsysRliF6pHFn25p0fOVpAe4sWUIjsqq1gOnSgiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=szPw/8osvmIcdPOk8gasD/fEYrOR++nVJ3WBNv+WaTE=; b=FbCtql1U0Tz25xhTlr02MClN9WmaspoAetytleGAzvtvxekTVTntd4ddSvf2HWhFrHFBe6JI1Q04XgBaQByoujnwTOlZHL75WPvbeiSx9YCHsamtNeCNHkoJxa+9M6anGAg9a1FMh6Aze5RHOv52XhYkfz0MImHpQv17txGHN2Z+uGAzatrY7BXAsVRKOCWA6PFV7/FiZTAWJBFwNeklx57bI9xAkTcjzkEtldYj64T/d3/93vTJ4hnV/EBTurN+frUNlNlkXOC3v258S4SUDoIsEjcRiNamKEVSyiUrocjSclhZwNcu2pcisIe69omdQugEswQYFnW5J5xgEnKgRg== Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by DM4PR12MB5390.namprd12.prod.outlook.com (2603:10b6:5:389::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Mon, 17 Apr 2023 13:01:57 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::6045:ad97:10b7:62a2]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::6045:ad97:10b7:62a2%9]) with mapi id 15.20.6298.030; Mon, 17 Apr 2023 13:01:56 +0000 Date: Mon, 17 Apr 2023 10:01:54 -0300 From: Jason Gunthorpe To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Matthew Wilcox , David Hildenbrand , x86@kernel.org, linux-sgx@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Jarkko Sakkinen , "H . Peter Anvin" , Xinhui Pan , David Airlie , Daniel Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , Paolo Bonzini Subject: Re: [PATCH 1/7] mm/gup: remove unused vmas parameter from get_user_pages() Message-ID: References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: YT4PR01CA0409.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:10b::14) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|DM4PR12MB5390:EE_ X-MS-Office365-Filtering-Correlation-Id: 94c63563-ad8f-47b0-91c4-08db3f43ec79 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Yy3nF81DcVWFFMSf7CQ8qyBdIrTpdh52FBS6FUKtLREg0m1RrLYWezUJ2gjbhZEp31E4IK0jKyH5uXYHCCUT0x20ouE9TuG0gn8uTt6tCDHo1pZatXY/IfqfoErA7WC3N6KQTzoNnsySh2QDX3+zzceEBpoyVFsyxX9XcEuec5yOreVBfzzbTJFIESPfi9JKqMURQit+/uGf5j97zgw7hgKHLtwiAxA0/GNdErdwx/VtSq7qa5RHDLKEqJ1cULGSg85tARUiLwWx60bVFO5xnyB6M01sfnnN8nEaR0TmkB19vvr3PgiW81WoSJyIGuMqMqNPELmar7HOpYVeMFargf34np+YmcnUuUbHQkhOka7eyRLnE1EKOLcjDJTyqz75P/e1qAMgteUMl6pZh8GnsbsZ6UhPb1nqsfVmC2kDtfFnrLE9vzwxPDcgxYmMWxQUk5Ft5Tx+dBLOD4CR+Umvgix2wR3VaKtMdJl/zoK6shjcSy+uqHC3/heJ5kq9o7kG9SeBjuJ6ETC2mq8sT61tuOqot2pdL9ymkxgBTK13KygCGHLK0A6sT/eOTn5kRhZF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(136003)(396003)(346002)(39860400002)(451199021)(2616005)(2906002)(26005)(6506007)(6512007)(86362001)(6486002)(8676002)(6916009)(54906003)(4326008)(478600001)(316002)(66556008)(66946007)(66476007)(7416002)(38100700002)(41300700001)(8936002)(5660300002)(36756003)(186003)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IiiDLyEnosYn7kysTkoIkb6lsp5onG2a5s7RFiFSUQPU1f1H6ZHBOvckw3t1?= =?us-ascii?Q?ikBX48odIWovJx4ink9iun5tVcj3x3zt3TLw9ebfJRC3/MWcDEbj6E+o/elw?= =?us-ascii?Q?ioYUtAj2Z7VWCPqzvOmBBtjZPKqY8msbqqxngR5mFVYmAxJHh62ggoabeiyC?= =?us-ascii?Q?s9ixG56yv1xNGjPPAV3JTau2F2GQqqImxJGSaVI6LXpP9Q2yWdgUQR0HJMqH?= =?us-ascii?Q?u5zud9e7+pyZLeQlwelVLCYlFa9+Cey3IRkz5ybxuIvU7ndTeUrzYkRqxk4m?= =?us-ascii?Q?wBQp06tx7P/IPRcqLMVBYakSV9LFxNSstTAq3LShaKDjye8PMKAamtbuZaXd?= =?us-ascii?Q?wNretB1gWE5F7qDdmbr1XkdrdHXkmFCjWixytfbEccryzIdG8dBAIyDgdAJ6?= =?us-ascii?Q?rZzL+J/ft1T+B31fV7dGgyTy9cGZkBWi7VVgAWgk/OcL5IvGPiD8QgsN4Rw9?= =?us-ascii?Q?9Ee/htrHdR59zGp9N3rkjcBooM6tY6JKWDzGx3HuSS2VZn5o3oLIDQvPE0Yb?= =?us-ascii?Q?fUffRgmnIvSI82JIssV9RMLPGe7I/l1Eir/QZKpTYqeptLMpfwXpKrn97HUq?= =?us-ascii?Q?AxVa0u3rGXw2spp/b0UYH/6CTtV6lZ9854cZjlPtqsBb/uWF+agFIMdEs+3q?= =?us-ascii?Q?9PS0nruUcAhnRwKBrh4wRI5euZ3hNDdbMVvsv8YIQ2wFdJnH16VIz/TlMTG7?= =?us-ascii?Q?0w4HKO1jnySh2zm/dGz+xqPyADeJUIK9YCEmg3TlL93Qi/SG2ZA2WugWIwMp?= =?us-ascii?Q?URPIgZQUSRx+S69pR2Ghna7pXvOfNuZsIhMoc9siFYBeXQ/+OXr0NTtEwOgs?= =?us-ascii?Q?Q5Q5JcbuEiDp6Htd5s4hjGfnn2gufMtUbDGmcGCHjGJA7QwrI+XHp8CqjQhY?= =?us-ascii?Q?31FuybFh7zciZPae1d846aOfsLD7QuBM7CzvYl8cvcnykayhXjK1EVUvdZX1?= =?us-ascii?Q?G71pdaERLwfE9NgY2Njq+0wFdFoxtbDKveOygQOmN8A4kEnaQS9IHkkZakgR?= =?us-ascii?Q?V1IUyV0pmFuJwxryahKEnFy5udgyBwSg5r58V5LaDNu0hyv+Tn8RX00xFvkZ?= =?us-ascii?Q?4IaHiVh8PCfJnddajyTJDgHiZ0fVX4+fuJ6O1IdVFVzjztDRAwWSwu/er/zr?= =?us-ascii?Q?aQ6gmogySkho1hNUxbJvrEvIYn6xuC/jWFlksN9bGnohBztygTcsICqgFkUH?= =?us-ascii?Q?HfD5fhhEypD33Wv2fhCQe4JIjOysSvSKJM36xZSnjIK7YfRwKbnWni9vx8z5?= =?us-ascii?Q?fMz65LjauVqJ321gOWte4cxa9KA3a/AcYIbWQzZCXDMzD0ssHTp1/FUgXwYP?= =?us-ascii?Q?+YoPqvOI43omtV46vXGCrg5C9+pB/m2+VJwbodgHNJGD9uMvo8cQLfAvMQKT?= =?us-ascii?Q?Ao5bZpnkJcu0IESxEJKOzY+u5zHE7zmpHUZVGhkKpi5D/mDWQWfYgFptZRAW?= =?us-ascii?Q?5heB7a3V8DzeWD8HLIOQTudw+Zec835GBeW7jf8jcQo32NO2H7IIilRbUxqj?= =?us-ascii?Q?shItB5MZcONmocJdvRiwmL31aNjrwJtROM52t/oWb0+6Izn2cs80XUStvqZi?= =?us-ascii?Q?fNf+rBK9CzK5rw5ULwzKD2ac+RQeP4Llm7x2XYTx?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94c63563-ad8f-47b0-91c4-08db3f43ec79 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 13:01:56.8338 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0+0baHLvWHTdAip5gKuODZ98CnsDXYde+eVw3/kzGKTNb73pJjHUY0cRYBX8Htc0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5390 X-Rspamd-Queue-Id: 719C380019 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: wqshsme8ecqkruommac5ebrxi1e777f6 X-HE-Tag: 1681736520-585671 X-HE-Meta: U2FsdGVkX18dPH1Zg1SfZAabAw/AvLhFvSZPYXThu1fsMfSexjacWNfLlE/mx0AGcL/bYDiBeUlCISZ5JWGPRgML7Tx5biYjVVuDfCvpVGRYy6EjSpHqhaXSIVMrWD85yHWWZ7QPVfc0k+1izx8eUPcTrzgCdy06Opqfq+xubXr/bYcthbc6ExLWUtTkD4E3WTEUxsaSOEws88HzzsQo+1AVhS/tmGb+d3wpHS/wSf2N2EhKjz/ahJ/a3+tOYQKS2HezxSzkZ1r1Tso2cc3t4Fw7dP0/imyzQRyPLsi0kIBSfQpcUZSYQhtIe7QqVuz4/kXgwlbxU1PxTDlEVSResVDQOeosA0DLCKhZznqHFwzztGiYk0gS386vUrsEflCfIWSXrH1r7fMic0Fc/ZraSXj7An9efsF7AcPyTHBLhjlWcWz7WJaZzocK1AUqI26uLnjYom3lDYFPvffatOtTr8f3kOF3ep+h6zn8Iki4x/Lt5ytbOmbypGIUKrKpe0jYjBjerl3HyM+PaNQYB2Ovxh+yL6c8S2V/BpWV4PcFMJ1IICojSZ97zYxCpVXSC5DbQ2tOT2YCwtA2jNDmPMPIT0mXelfJX2p4hUKA/gPjPlh/4oufyzGjR9ZKmyYH1brZhME0IQ0i0nnih4Tn5IH+9DnlYdNyVD/RlzRHazF0xXzXzE/E/uGK30cKpF9VXwbDN6Yt+WYXreGQXx5Ep9aWiQ2wR7Xk27R/Ug0hs+sYKBd/a62U2egvohRqgYvrbNbRwIn9Hs63sIunUBGGaXTP3ay0k/jQp92EaB3jOFbO03BoSKrKqyaTh/ip9IElWMNfGBPYvXr7Zkmo0NfUL5DAh/PV4zQLGIoat4hZATVHGc8H2JpMRiCXv2roD0/N0LUArEL9MB7178AtAW2yS2tVVg3w+04nx3N4ds2nBay+hBHUASMdFUM5xFwyCLreU1RcWdQIfbidzbnXdtswjzQ n42pnxQ4 kV3qHDKmxenxYlVctXBP72dTXgLGQGphcKH5fXIonzUEC/nnYMC001dvCK0M88o/PVwN/8xUKNOpCatgNev2ylgYkXSt9x7mEUlYQ8yR2nHkqvTEmx1dR1d1U3OIR2xr6J552D4CXYfDyzD05cndfDitnKLe2/8XE+8EQqZjXXZjHswDF62b7hwoETMBdv9Ueq2FTaET4TRmCNqNT890g599A8kYGdvSuNUpi/iMB2b7QNJtoo1MH4oJnbwfggpUZpeqyzRWYR/DhGWQrxApSmkb8WcuHMcLqjUPg7aYM8XsDzrTJlzdZZNiWhAnzBs0/QIVH44mAje6hFkaAhQ4zmm6gNSLwClAGUKKR12wBl8SdaReTYJGjN8XZBKWANN9hFmz+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 15, 2023 at 12:27:13AM +0100, Lorenzo Stoakes wrote: > No invocation of get_user_pages() uses the vmas parameter, so remove > it. > > The GUP API is confusing and caveated. Recent changes have done much to > improve that, however there is more we can do. Exporting vmas is a prime > target as the caller has to be extremely careful to preclude their use > after the mmap_lock has expired or otherwise be left with dangling > pointers. > > Removing the vmas parameter focuses the GUP functions upon their primary > purpose - pinning (and outputting) pages as well as performing the actions > implied by the input flags. > > This is part of a patch series aiming to remove the vmas parameter > altogether. > > Signed-off-by: Lorenzo Stoakes > Suggested-by: Matthew Wilcox (Oracle) > --- > arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- > drivers/gpu/drm/radeon/radeon_ttm.c | 2 +- > drivers/misc/sgi-gru/grufault.c | 2 +- > include/linux/mm.h | 3 +-- > mm/gup.c | 9 +++------ > mm/gup_test.c | 5 ++--- > virt/kvm/kvm_main.c | 4 ++-- > 7 files changed, 11 insertions(+), 16 deletions(-) Reviewed-by: Jason Gunthorpe Jason