From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AB49C77B77 for ; Mon, 17 Apr 2023 10:52:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D438E8E0002; Mon, 17 Apr 2023 06:52:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF2CC8E0001; Mon, 17 Apr 2023 06:52:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE13C8E0002; Mon, 17 Apr 2023 06:52:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B17068E0001 for ; Mon, 17 Apr 2023 06:52:46 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 81B9EC04BE for ; Mon, 17 Apr 2023 10:52:46 +0000 (UTC) X-FDA: 80690569932.18.53E1F85 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id F0661C0004 for ; Mon, 17 Apr 2023 10:52:43 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf22.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681728764; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cc/9pUOO/zETIb32WJW/RJXmVNctXN1CXTfJbEX+7mw=; b=o2rH4wQHwmmnCgJhbfs9C72yyRmYalMGEA6lEQ9Eq61JyLI+J3k7YvyDKsbj0FPh6+U9iX aB4pY0d34kAdKG6nQHpZySg+7cYJXkcT1JY5KZZBAI0wnLykcA8uvFqixPGPjUoe51hvMk iLEkQMMBAi2bDJ0TQdlb2BravQUdN0o= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf22.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681728764; a=rsa-sha256; cv=none; b=2i2gxMoA0WdModwO8YXH90WZVENf5eCorTj76O6khGgMyRuMfNbWMlJ6ozbFNWjZfeUIXR 6nJXHexP56voLczQYzYD7NfaxeODJwvj22iFdZdAZQYnFcPhvkg2SKKHBgh9dQEe3Sha4m zcQZPBMyXjfJoECOOg+IyLripdyBuT8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D44F1621E5; Mon, 17 Apr 2023 10:52:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75C41C433EF; Mon, 17 Apr 2023 10:52:36 +0000 (UTC) Date: Mon, 17 Apr 2023 11:52:33 +0100 From: Catalin Marinas To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Matthew Wilcox , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, Will Deacon , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Eric Biederman , Kees Cook , Alexander Viro , Christian Brauner , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Kentaro Takeda , Tetsuo Handa , Paul Moore , James Morris , "Serge E . Hallyn" , Paolo Bonzini Subject: Re: [PATCH v3 3/7] mm/gup: remove vmas parameter from get_user_pages_remote() Message-ID: References: <523f0764f4979276a6d4b89cbad9af9124e4bf0a.1681558407.git.lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <523f0764f4979276a6d4b89cbad9af9124e4bf0a.1681558407.git.lstoakes@gmail.com> X-Rspamd-Queue-Id: F0661C0004 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: bt5at1tnnzzxuxehr5i1uf6y3qncuq6z X-HE-Tag: 1681728763-328807 X-HE-Meta: U2FsdGVkX1/ZMgvGsAvp/lDqiipO6J/seU1fm8zf7TvYj2zgmcjJiGVxGQ2YnOUyQY7XywROJx1DwRQ+lz+V2F7C9Trr0NaC44qQsnQIgFXr8ra7JCaMBopP7mfuP9XUofzzfzbDTJaHSjj/S2ZXEWTYQMPEbT8fdP+At68bA8XiUbrNyMwzPjjwjkD3fPsnBt/fGJ1zo1DBuZ7xcr6HSxMCNyhaFlpE3MYnrA+xb0HWQYzwWo7b7uEXlC6KZ3vgV4msl5D7ilt6wpBuRXptiXY6uNzD/nfJk42c5ZVGt2+6P+2PNoCMNmAHxvL6XShrKM3DqQt73+1+hv3pBkzxZ4mibqBtOW+0q7U3EuBZD0eCd/OxTprvdnYbd+q3ukQnUBXYqW7pwM8crUJJBapi5rOxpqva+zliXXmVGqoe7zvLcckiSYnSnhA0yNBznYvKs02fpiiBRm61ZCUW4tPJeS/sg9vlucBWG/k7RCUgIZgkvB1DUdAC1ebO+/sdajnGBWktGQng90ooOcaZwu5Ondj1zt5/uUyWHgBjLyJDA9YQwQAYY5zMlisnOoGsg2qT8p6ONlxWr1VqnSIHgOqbL7H6wa4bdveP99UN10yc4QN+G4b6LoGLSrnG0R7HtheghcGLFCyy5x5EtaIXvRM8ADUKmmpWVe6tidSV5fXIoROXbetwJfpChNg57uPF2jrJ1I9rU03WasyEmR1joVioBvV3jWxL3048PyV3ZTm/LUJYvTOOUp/TgIVUEKy9Y6YNAH2cRpkNgpHiOkJCOiGB3BRqr0JO/xpC1QP0/iBhelAWV1n8Zv1Gn0T274MlE02ejLad9Ljn1FKZyQIDpNhyu7uYOoswEqn1yC7oFqvRA5s5VBtcX4M5sfe/4tjuX8+Zczh2NSF8rI2OIsfX+JBejoLJrTWcAL7VgW5Q3fohHUV7ViawljYhRy3q000NahUm1kQPAodWczb+nWeVCYV kNp0kMZn xRyoE75wpKMpH2R9X8lzcY1pLut5LITy5D6+HTfEu/dNK9uG7MZjf6v1XyuwhSZfqQYD2CANs/AESz+9Cu8W70Pk0/uTi7zDjYk91e1z2gpGqwGcDt4keqL8pvJIoSTSQIwWF1TqUnpa/grO5bCeN/D4OfGgRXtBIHvt3TpnMNfA7tFwJskVCIGol8fmAH9Fn09bMV1FM4GO+dlI/aEFuW1cB1d4XhX42LhVhcxdopAvdEEQj2pqf+ijVPkM7tg5wnoTwEZMx6h4bvdLOEAYHs6rMCmbjUN9z43Kzkjbgl+Ju2PncPxXS181DoYyjYp2Nw1XJ8/7OzfRbXp3TIvtn2bQau3FIlF4UtdBiOjVXCiquQS4S28RWXMxMVrTKWLwCz87+HrHwvnrgg01bTlo275n2iQ0quqvxWgW5CIj2xWjQIquOR7//01zn/kX73ZugTO8TbCMRblCIP31SnYUMYsY+HqnSZ6Aoijnwdb5ccB/EPHaHuI6IrlfTH2qJdQtFCp9S5I9QyufIGcVbnnJXc3GOb08f6ZL5N/r4zukPvzoPYm3vzegBOpyJbtFPQPOoRhrPa0ZJRsXrfszSKyEtYCdyzw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 15, 2023 at 01:09:24PM +0100, Lorenzo Stoakes wrote: > The only instances of get_user_pages_remote() invocations which used the > vmas parameter were for a single page which can instead simply look up the > VMA directly. In particular:- > > - __update_ref_ctr() looked up the VMA but did nothing with it so we simply > remove it. > > - __access_remote_vm() was already using vma_lookup() when the original > lookup failed so by doing the lookup directly this also de-duplicates the > code. > > This forms part of a broader set of patches intended to eliminate the vmas > parameter altogether. > > Signed-off-by: Lorenzo Stoakes > --- > arch/arm64/kernel/mte.c | 7 ++++--- For arm64: Reviewed-by: Catalin Marinas