From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76606C77B73 for ; Wed, 19 Apr 2023 09:30:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5A988E0002; Wed, 19 Apr 2023 05:30:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0AA68E0001; Wed, 19 Apr 2023 05:30:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD2358E0002; Wed, 19 Apr 2023 05:30:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BEA378E0001 for ; Wed, 19 Apr 2023 05:30:10 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 94E811C634C for ; Wed, 19 Apr 2023 09:30:10 +0000 (UTC) X-FDA: 80697619380.20.957A32B Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf10.hostedemail.com (Postfix) with ESMTP id F0AB1C0017 for ; Wed, 19 Apr 2023 09:30:07 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=KI59aLQe; spf=pass (imf10.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681896608; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BCVaQWX8wENq0DO7uDMubrTTJdT7g8WAsUs6XZCUPEc=; b=75i9AhDpmpA3tMAKF+qcpN89NNwMWD42Tcnz9tzNluktuIkThKq0KfQue0CKC49KJCxWAT qPtBlqcVxFGKkfvyR6aGh3Dl3b0kbdoP9pQjNbS/HxU41pboHrImt4WxSIgskPObybILea v4ZiNa6fVR/JDKCgqoWh2TBtLbrs7IM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=KI59aLQe; spf=pass (imf10.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681896608; a=rsa-sha256; cv=none; b=LQcyJnLujSIfcow72YIHHxjpvcqLQXd74/fZdQwUG0xt+UzRpLGChmqeX3IB0TJ3nYKPTY OcAzRD6Drvc+1nCZyguO8Aj5pyg1n/XTnszfPdMv2qYtdKu7zl8SO07MtJGr5U7Z5Fbrb6 QZTUaAJePJ+n2fJ1N8qzBU2BVYGuGXg= Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33J8BVSD027803; Wed, 19 Apr 2023 09:30:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=BCVaQWX8wENq0DO7uDMubrTTJdT7g8WAsUs6XZCUPEc=; b=KI59aLQeP+ewyXB61WATBv0WCZ0jamjZKmXqoLQFp8b41aS9dlFFh3AP8mtMTFJ/9Yu0 UhKfdMVPQNZC8ucf29Kwj6Uh3u8tGPyicOBVqQC29FUAvpsRb50E0hInINag8DlcEmjX BYi/8XjQaAYF83rEo6XN6zIKvhbGrxcJwOPaKi5IGItQabxjfd0/7sfSrzdLNc4mw9GM Jb2+ukiG/uXqx2wNx2YBGfl25k+GoBBubjOzbe63xRqHETjXv4462krI0Nz+kQlSL8xi gl0GGSR+Di6TKuz5ahCh5KCOPxyjSSH5ineA9rvpVptny70FNKADhcXU2FK+MQGu1Rqs 6w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q28tyrdxn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Apr 2023 09:30:03 +0000 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33J9OZkt019579; Wed, 19 Apr 2023 09:30:03 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q28tyrdvk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Apr 2023 09:30:03 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33J3K8C5027628; Wed, 19 Apr 2023 09:30:00 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3pyk6fjkyb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Apr 2023 09:30:00 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33J9TwhR7275050 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Apr 2023 09:29:58 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3FAFF20043; Wed, 19 Apr 2023 09:29:58 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 576E020040; Wed, 19 Apr 2023 09:29:57 +0000 (GMT) Received: from linux.ibm.com (unknown [9.171.40.70]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 19 Apr 2023 09:29:57 +0000 (GMT) Date: Wed, 19 Apr 2023 12:29:55 +0300 From: Mike Rapoport To: Hugh Dickins Cc: Andrew Morton , Mike Kravetz , Ard Biesheuvel , linux-ia64@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] ia64: fix an addr to taddr in huge_pte_offset() Message-ID: References: <732eae88-3beb-246-2c72-281de786740@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <732eae88-3beb-246-2c72-281de786740@google.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: SRg6qd7GUcrAaW-YibhBdvpq11qOi6sT X-Proofpoint-GUID: 5W1KW1xNB19ev1igrtiNiz9uVgMkUKmC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-19_04,2023-04-18_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 mlxlogscore=697 clxscore=1011 priorityscore=1501 mlxscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304190081 X-Stat-Signature: qx6uo9sd9t1zpjj9cadfw5c4ikodkong X-Rspam-User: X-Rspamd-Queue-Id: F0AB1C0017 X-Rspamd-Server: rspam06 X-HE-Tag: 1681896607-154629 X-HE-Meta: U2FsdGVkX18pjV6pIG023XIWbk8MmGguNLGfeo41fhDIM2caaMAxb2fz0kp5g2c4kPx664GRUwilExcz004gZveSpn4vFtMS5oEIw4MFxjT2hZSsP09WNmPp3/X645A0kRajVff6/F4HPDfHSMVh07R90Q79+tc6hQ0UN9e0CQ0z/n1luboqF4grXUS4zAW5TIHMMq0a5aTM5mJl78RnD5VTNy0JDsx2RTvLqUFJMF8oy4hDIiQCw/rSG85i/aDZYKi9xCSGQmFTX+SLW82yaJbb2PUWpbLW+0BdcYO8/UB4GEfNm8N8oKVO2V8GbrqByXzllmiZc0KTO4aH3k/RLiRv4cHwIKezEvja8TZ1tiItDdJ6BybKuGoxf8QWrTCH2qnTK3TIb4RcNFhcPkTZ3vybR63k4r+07lvM+kOTJ1yFe7O0jXvfpadgoFjjMPPs0zXGKOxKPZ/Ju7MNRj1rkOGjFiFzgx/a2TKHrvaRC0k7cOtllKHtzXNJQs2ogqL0tQ1xeKmyjuuvjYX0/wf4US2fEN6PKm9ZM1GmSd8yHNA/WAor5XMO032wSy2CH77KQhqMClwAHYOMAtjpO99lB1bOZoueyVQcFvUgRZ651S45zlvZS8Hesh02zylpy3kWwJ3vTcsE0vbepaoJmqkr6S+kB1Ojc7jh6qSCpxPSBCwDLdlTphGfEuCw/lGQwonKYhZBs4z4oH3LJEx+jjgbZi7cpPGCog6/91U4Koruz6RAAli51UI6LAOs4RalrC6v5+f8kTAROYqmYYLYyH4aLJMzz8v7Q25qPoGIFZNehrqvsEPDqBx0PNij3LfL4s9lMt3J4T/RQXDOLAN1OuJGwg2BGN0efHVef/xGGu0nsAdKzQnGlHHvX1M+ybhpvP4UsUdARfOxFHsgaDljSRUgzzz//wH/Cf5iD5Abtacrkx3/XIQ1MTM9/Zoonum64FbnZrirbZGSXVCFBuVKth0 MZ7TdpCN ZQxNNG5Cnd/Vw16E7ogZxlEolqoXFNiVCFYTRGD10IaV19mN4Bujbs+EHnD8+oyOvQMkKBuYfiemDw7RNwF5Hw0kf3Qko+1u8pAeLj9p/4ZM6LDA9C6foQSW2wcT/PDFvT5Goh264CDc5tn0i+4lsNOHZOFF2JaaSXEMhi5mvEnk07MZMcT7AdD7ykSJb5JkkPxgBBweOJIIvh4iM6cj2bZyaw23LeIyc0t387So/MiLuuVytlxYPFXSI2znefqjJoQ6MgDifxH08Rb36UnI81PhuAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 16, 2023 at 10:17:05PM -0700, Hugh Dickins wrote: > I know nothing of ia64 htlbpage_to_page(), but guess that the p4d > line should be using taddr rather than addr, like everywhere else. > > Fixes: c03ab9e32a2c ("ia64: add support for folded p4d page tables") > Signed-off-by: Hugh Dickins > --- > Just something noticed when visiting recently in the source: > thought we might fix it before ia64 is consigned to history; > I'm unable to say anything about the user-visible effects! > > arch/ia64/mm/hugetlbpage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- 6.3-rc7/arch/ia64/mm/hugetlbpage.c > +++ linux/arch/ia64/mm/hugetlbpage.c > @@ -58,7 +58,7 @@ huge_pte_offset (struct mm_struct *mm, unsigned long addr, unsigned long sz) > > pgd = pgd_offset(mm, taddr); > if (pgd_present(*pgd)) { > - p4d = p4d_offset(pgd, addr); > + p4d = p4d_offset(pgd, taddr); > if (p4d_present(*p4d)) { > pud = pud_offset(p4d, taddr); > if (pud_present(*pud)) { -- Sincerely yours, Mike.