From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C62EC77B73 for ; Wed, 19 Apr 2023 14:19:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3E6B6B0074; Wed, 19 Apr 2023 10:19:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC5D8900003; Wed, 19 Apr 2023 10:19:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C65746B007B; Wed, 19 Apr 2023 10:19:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B37446B0074 for ; Wed, 19 Apr 2023 10:19:55 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 90F091C5C8C for ; Wed, 19 Apr 2023 14:19:55 +0000 (UTC) X-FDA: 80698349550.27.03823A7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 6F59C180031 for ; Wed, 19 Apr 2023 14:19:52 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sagm8bmi; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681913993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+pd4oKFh0oFb9+Iu8ItMUHH7+UjLES4jQSrWjxoNntk=; b=48D43PKllbEcBn4uXWyskJMSu5oVny3LYjGGdNaXszX2Pd0FwPHYWH7TJZVAnFZyq6S4jH sLRJciEzKWICojC9anQKpEhkn0vJLAS1KQ+lpSkvh88UhPzyjgtK7F5WVr51D0ULDQhpCX i7vQpX/Himh7AC5HiMumrXAd3GG1YBk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sagm8bmi; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681913993; a=rsa-sha256; cv=none; b=oaq6Ou/OehoncdvF121gVL2vtl1y7evyCH8C0axatg+ULCZStDOW83g34/1UDR92vV5D1J 3AmeiwwBz34+8/zGth2FWpbxfp3NxQqlNJyG6BJF19IXINoaq9Ttc2FIUOuDsP6I5o4LLP xi28q7bI06nmAdlIKj1bmIhv0tKfE0Q= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+pd4oKFh0oFb9+Iu8ItMUHH7+UjLES4jQSrWjxoNntk=; b=sagm8bmiUZxQFociF+FkwReyXx kqdFZHQr4HuDFcx1J+L17DKTxkCc08j6JFj3DANaq0ApL8Ik4omqR93XamI7fuhXfrq7qNJIm/A3i 250Wr67KjPr1fBJqaSoXCq1K0pnZixmxYxb7sEU4Jy79RcYVlhRuhFtZ0f8IIDkj7aPo4UtyehLpx WAHMINlPz6T7j+3uE2+7rYA0dRJTgkTASjEFlsEQvNF4zVW/Udb1b2RIR2ZUrhpEyMg5i7oehPGtU IMknaJgbzbBX8AuJwMcwzwR8HwfFibwnD9fr/HyNgJLkTvwyBmETp0+3InlkyinLD32SHgvwXOyJk znUSSLTg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pp8ed-00DJck-8U; Wed, 19 Apr 2023 14:19:27 +0000 Date: Wed, 19 Apr 2023 15:19:27 +0100 From: Matthew Wilcox To: Johannes Thumshirn Cc: axboe@kernel.dk, johannes.thumshirn@wdc.com, agruenba@redhat.com, cluster-devel@redhat.com, damien.lemoal@wdc.com, dm-devel@redhat.com, dsterba@suse.com, hare@suse.de, hch@lst.de, jfs-discussion@lists.sourceforge.net, kch@nvidia.com, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-raid@vger.kernel.org, ming.lei@redhat.com, rpeterso@redhat.com, shaggy@kernel.org, snitzer@kernel.org, song@kernel.org, Damien Le Moal Subject: Re: [PATCH v3 19/19] block: mark bio_add_page as __must_check Message-ID: References: <20230419140929.5924-1-jth@kernel.org> <20230419140929.5924-20-jth@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230419140929.5924-20-jth@kernel.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6F59C180031 X-Stat-Signature: 66adcrmttm8pud3znm36hw85tutkc6ga X-Rspam-User: X-HE-Tag: 1681913992-940403 X-HE-Meta: U2FsdGVkX19oNcMti1dMhSBGpzIesr40AC+13hqvpV8rjMDf2uDAUBCprPBVtxMl6WmxLnu77yFdbhze1FNC4e4AhcunhE2ZBc6JiZ1md+btQ7/qcQkwdfk1FdYzWwIgqXJraaCEaJzTiLwMJqh9kNxj3JTwWpz281JgYRwu4iuIwNj6RRau2Gn7I7C+XQFeNo0ZGhs5qSoVNKcGqMVxeB4HVCAjJ/aTf2NEWyOu5Jbn/M8FHSPpoSD3k/9AetV5VqdL72oX4fv/bVTonqg+3fFwjv/XzttsfwQgt/chZUFkFJVpoA3lV4Smp/vReQIMoMqlnfeTAucnH7YjTA2toK6QSMIf+2wajjev2xER8yK31SaFtu3EIYzzbg8jSWzA9+Xlc8CI3BtIZ5ZNjNy2W+reFInjgsNaZVNKhO0ErQz1pFzpFZMJbJdygoyodE2qMqb0vcF6RA0Omo1vRCTWTONHGADdTpyznbtWPEsgmJX+ZQJmPuXDZbwcD7XnTIBScEP8mvt0XGdkmm6ZZMQ5zWTnbx1ji69/vZY/Tv/Qf/BncPodsFJkykIqgOCaa944qDpGsukUGPWqpaZE+pBlsBjtC5axUWEjaf1QQ7AehCEKscY/Ez2UdosssmH6+bcKGPxSY9CqsGSGfHecuX/U1N/gZQ23De9EIjHdmTFkTSXAHuRiGN6fFCUe7YXkUnll6CI+MkP0m+1XBHSvyUbFW0dSr5dz3g775RkE98rgqhnzZN22zCtS31vwJU7iFTWXCi0WaSSzO1jIdZNK9Y32nCOSYzdsYYzXyNAPbg015uDfNenWX4Y3zaWdKrcBUgNxZDnYe3ZlhhJR985jDEUSDc9yNvY2QZnby/bjY3LcK3jJF4Wj1rBILgCHhpC13iWgq1OuPg0xFEG/w13igUV+pyOeFK5MTd2Tis+W01FSuDeKbVDoCglqaX4WxkFdgVWpjv2wW3HfP7Bk9l1VyQK hKQlSUif a0vAUdSNhjGfQUUNEAvVpG3SkVXequgAQfDBnVtTE8qJBEDCNWsXq9FwDyaf6LIl+Vk0zcyc/ZxvSN9oMETJKpie3ceqcbsp5LaLhE8hhV0a+qfOGXC1QFI0lqdhj68SfGa93fYuwnbCiVsENsR6+qe7ndq3hPXeCRpky0mq87zu1QsYKcS4mCYp0dltB4E6J34QmDWMfcA7uk1I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000087, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 19, 2023 at 04:09:29PM +0200, Johannes Thumshirn wrote: > Now that all users of bio_add_page check for the return value, mark > bio_add_page as __must_check. Should probably add __must_check to bio_add_folio too? If this is really the way you want to go ... means we also need a __bio_add_folio().