From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04271C77B62 for ; Tue, 4 Apr 2023 15:09:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 283F06B0071; Tue, 4 Apr 2023 11:09:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 234216B0072; Tue, 4 Apr 2023 11:09:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 123586B0074; Tue, 4 Apr 2023 11:09:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 034B56B0071 for ; Tue, 4 Apr 2023 11:09:26 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B5DA1160BFE for ; Tue, 4 Apr 2023 15:09:25 +0000 (UTC) X-FDA: 80644042290.25.2CBB3AE Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 0C337120020 for ; Tue, 4 Apr 2023 15:09:23 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=zpV9QjGD; dmarc=none; spf=none (imf29.hostedemail.com: domain of BATV+8568051c7530f6265d9e+7163+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8568051c7530f6265d9e+7163+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680620964; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PlNwhxmRsqAwivE1o4coXOoSVUnRwZpYbtOW5USkPZw=; b=OIhMLuFg3jhYCq55gkQLMNDAnlV+4dNDMjj10oAFhM4rQ3/dRRZ/5rqpw1bKwQJ4AXjR4t orQ5bN3thIuPlVD7zefjBIL2hxMyAcpeMf23jQ/IXIdc6NgKUcaivKyl6XO/WFlTfGfALp i8iv5QNnVaU8DFdsfVniBVHLX/dXe9w= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=zpV9QjGD; dmarc=none; spf=none (imf29.hostedemail.com: domain of BATV+8568051c7530f6265d9e+7163+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8568051c7530f6265d9e+7163+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680620964; a=rsa-sha256; cv=none; b=suJiRPSdaJBtHYslzsqiJT7EFEzyJwGNNXJFAR4A7JuHLdBaidruffaEiyvmtrLMHBdCj1 GtotGdXUjg/7pRJpVdqhRoY/XuLjV9xBgR9zNeEvI2rSw+cj586P6N1GmtwaejVrGnyxg/ KEK8O+cOcG+gLePXQsvpXVIqcn6z2TQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PlNwhxmRsqAwivE1o4coXOoSVUnRwZpYbtOW5USkPZw=; b=zpV9QjGDblzOdT3Kpl/izTo0J+ ojzjuO+DWg0aaCeHuCFEMQoNJ1qVxvDWY5z71t5kvNZUV1lQUm4yb5vtR2bIPAKrIb5N1udjGt9Rk gV2W8FHgScYVgfs1W+znbo2NtP/oA7EIwCTNK1BYGfMQaCOzdUCfA5+jPGCodnJLBeZ1Y9HuCMTUZ NhZTqatBJlNvnpwAWTZW17Q41G15Slw/1UFT5OppIWUJUrO0pmhe+8jxbCgUVEIShGHyH4cTdBD/d 9DF5rIAbpmX/6XACqnqm7wsW7ZjKnMHgXsJogBYve1FvXu8wpB0O+0JM4PW2EenYkKVq10vyInIej jfGiLqEg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pjiHd-001wCA-0R; Tue, 04 Apr 2023 15:09:17 +0000 Date: Tue, 4 Apr 2023 08:09:17 -0700 From: Christoph Hellwig To: Pankaj Raghav Cc: axboe@kernel.dk, minchan@kernel.org, martin@omnibond.com, hubcap@omnibond.com, brauner@kernel.org, viro@zeniv.linux.org.uk, senozhatsky@chromium.org, akpm@linux-foundation.org, willy@infradead.org, hch@lst.de, devel@lists.orangefs.org, mcgrof@kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, gost.dev@samsung.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 3/5] mpage: split bi_end_io callback for reads and writes Message-ID: References: <20230403132221.94921-1-p.raghav@samsung.com> <20230403132221.94921-4-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230403132221.94921-4-p.raghav@samsung.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 0C337120020 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: k7s3hn7cjzfeewr4u1s8c66ux5ytnacd X-HE-Tag: 1680620963-401422 X-HE-Meta: U2FsdGVkX19rQe5MaI8uNGujjy6RlM7ybspU9YNsUvHGe/75X/0K+O2urFfBD9ZU8EY4GWdCQ/gKn+EOcgQngA8M8RwH2vhCBwjgPN5FfSW/SVr3F+YLYq99847ZfnHyWIuA1guoQ33I2cqonmp40SEOsmxdrXVKtHAqOXfAy4VE1UuVc3zsnYDEnEqwNKqKO9iemyYd+my4T8I9oWAHfftQ7RE1UqGoaNIxXqW3zUr9Ouv58hRirTyFfmu0p+E1ghxDHQ0I9euuVs/K512TgTfmHKtBXg5NoZ7z3knrMeG/goXyUANuj9HdQLes7mYdA66apVTDEMoetCtj2JkyEt3JwJmED0Z/4vGCpwJuMO/3orBf+B4VU2hIvR4ZnLamHh3xj00ZX0zMyPm2QWFPa7SNDoIBpEZNTbUvtk2gCXoriSIPOxbSWEXQ9YhsNqedFkkfYMs8fCEUgwHcb1MDPnAJ0gIxy1TXuekjWrb83m66uPWAlqJZfGZcJSvDQIWN2DcHixSjH7By7YTG/Le5Ij6LbY4lGTv744xlMyqRhGEXJhOUHjSDrJsL8b9aPwfPIxmrgixxnppq66bSnMg/U8Y5mQG8jxXBzbFdFzKuUe/IjSCz+IjOrMMtd9rtTbYvzDcPwMglXC9UR8MM21SQH+od9bLZ5nWdahzsFHh6/ygtkeKGwH29Vt+cfZpQNmcZ1lGTEJ/zhQTPoSzgIPf57K51GCqHHZzE9s/kXVLe7deX1RLgTPMxWzRsfcxXgMyTgubYMGNDxGR/yBEBCSRQ0Cs+MFxg7F4OxXUkew/swtXueetWyno1qJZqgc08itXePORCINC+yVCdS7sBhnKdszQLLLO6YeCPvxBenOOsd1b9HwcMPX/3VxJtpmQPLv/b04BRXOAPd3pJDhF0AdQrLw7Zddkjc5DOiy/i3Rb3wiMWoQH3Hx0hRgHSgV80j5brh4Hof3FXzSbuDEPzYxp 1URdKIkt DPQiwRB8WenlfMp4aE0yWzHRukYe2UTX2sLVE2P9Al33tkyrhJIs7KGd90qeXy2y+kAekw7JJq1M3c45EeZsNdR1zWah6LaxKxRA+bMLEW0c7ixQZdmepkzFD95S2/i4VxJa48/hFcbyyQ+bmgOwI5hse3MhnRYB0o9Y31ss8dD45ple8EXVgniF/aotIPLZPWiquszsYWOiDEmYMgJGUe2lZBnDz2OY5WRFZZSRabbNF5yAAXUUgqenfPKRLCtpP3aoBZkQI7kaHkwOK8qam9X4tVmGK5ooIb0e+sd9YtwsQzUSsDIFO/8RoDRo01NngF/Gsv5/y4N0wm8i+c6KPFq57JmX83pZqXlZgAPMERw+Nbkyg/6zOmr/6k62BOZNsg9uvcuINHZjwQGTGscbpdwAeNgNK+pocP/pPvMfjkXNLpDjiWh82WpXziX0R15riBiHamElruNXfICM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > struct page *page = bv->bv_page; > - page_endio(page, bio_op(bio), > + page_endio(page, REQ_OP_READ, > + blk_status_to_errno(bio->bi_status)); Nit: I think we can do without the page local variable here. > + bio_for_each_segment_all(bv, bio, iter_all) { > + struct page *page = bv->bv_page; > + page_endio(page, REQ_OP_WRITE, > blk_status_to_errno(bio->bi_status)); Same here. > } > > @@ -59,7 +73,11 @@ static void mpage_end_io(struct bio *bio) > > static struct bio *mpage_bio_submit(struct bio *bio) > { > - bio->bi_end_io = mpage_end_io; > + if (op_is_write(bio_op(bio))) > + bio->bi_end_io = mpage_write_end_io; > + else > + bio->bi_end_io = mpage_read_end_io; > + I'd also split mpage_bio_submit as all allers are clearly either for reads or writes.