From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF879C6FD1D for ; Tue, 4 Apr 2023 15:10:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 430A16B0071; Tue, 4 Apr 2023 11:10:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E09D6B0072; Tue, 4 Apr 2023 11:10:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D00A6B0074; Tue, 4 Apr 2023 11:10:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1E13F6B0071 for ; Tue, 4 Apr 2023 11:10:41 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id ED5B81C6FB0 for ; Tue, 4 Apr 2023 15:10:40 +0000 (UTC) X-FDA: 80644045440.01.965B931 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP id 34FBC1C0013 for ; Tue, 4 Apr 2023 15:10:38 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=uky0j7p+; dmarc=none; spf=none (imf18.hostedemail.com: domain of BATV+8568051c7530f6265d9e+7163+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8568051c7530f6265d9e+7163+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680621039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cHuev+laSziwM6gdDJJLMMaZ0GcoHaV1uuy1JEfyFtc=; b=IlOE93YDhdM0uNCCJK5BAyaX+4nXdcqNRo/1C3z4grHafH5lfuaXKOP3ZsbcJwGBmO/gMu k2dVjisahgwldD84NRBYN7FGlsGrgT6x1KfKeIlHPq02d+H3jndmqVEV7eg6OWjge9Vtm4 oJ94FDUmj1eV/37M5fXSuEfOMg0mf/k= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=uky0j7p+; dmarc=none; spf=none (imf18.hostedemail.com: domain of BATV+8568051c7530f6265d9e+7163+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8568051c7530f6265d9e+7163+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680621039; a=rsa-sha256; cv=none; b=xkuyMTU58i+uupgklj8eBzW7sJtHN4dZC0UPniFQLEBJFcphahEpSOvv6eqjb6BC35ovJX WcB+RoW2dXycEMe+icUH3ZCJkcjpklJ2H6rchb/tM0PJQuT/6H+xQ5OotnyLWIEDX2sdjx 1yefv4t//jixaR1WHvdV4iVJGWVmTtw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cHuev+laSziwM6gdDJJLMMaZ0GcoHaV1uuy1JEfyFtc=; b=uky0j7p+uWkVvEltGHje+zBvuO kQbp4NB8YRI6wz4uhmKAmwNXlIqIv5Dw0ID0havkpzNnYFJBuw7ukyiMWCfLGzuy3EtsOWiPk5kXq 9ulBSJ/BDfxNvcpzxfc5kSDU2s0rFXwyyxSh+eedLMsLQaK01K8Dij8DG2bnVfQvnvKn+HN04NObd C8ucFJAz+e6MyJDoTgPiuojD+U+zPIpAMTkgxdjH65pzECkdpMitUEB5uosoISC2cuAi6fr0rfBqw 2/Pcgdne+lXRPJrSTj5HY9Zsz06qTVzDuU3W6piYfRBEmAMMNdbRVz9w2JwVmr1J7KvS0Dd+d03Lg +lC69xrg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pjiIp-001wQV-1c; Tue, 04 Apr 2023 15:10:31 +0000 Date: Tue, 4 Apr 2023 08:10:31 -0700 From: Christoph Hellwig To: Pankaj Raghav Cc: axboe@kernel.dk, minchan@kernel.org, martin@omnibond.com, hubcap@omnibond.com, brauner@kernel.org, viro@zeniv.linux.org.uk, senozhatsky@chromium.org, akpm@linux-foundation.org, willy@infradead.org, hch@lst.de, devel@lists.orangefs.org, mcgrof@kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, gost.dev@samsung.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 4/5] mpage: use folios in bio end_io handler Message-ID: References: <20230403132221.94921-1-p.raghav@samsung.com> <20230403132221.94921-5-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230403132221.94921-5-p.raghav@samsung.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 34FBC1C0013 X-Stat-Signature: apxkpit7ts3zert13f6eo5dpfc79uwns X-HE-Tag: 1680621038-887276 X-HE-Meta: U2FsdGVkX1+FT72lw9rC7BiylR8cdT9KYdw81epvRHlM7C8g6Acbw49EbSmuiiRWD+LBmUBjGKIOARn0Rd1+YimQA+jfjkel1WLg2N5vjC6R0z6nSelRrA/HApN2/LNwBPYbvIqG4DZSTG5pbhYVZPPHwHS41Tb+Qsc3tBRH3GhaqsQXZtTL5XnEoazcXNBuR0LGa3pBa1TkcP5gbB4pmRjPq3uGaE+UVT9nEJ5eNAUcntHXjD7hi+uKEud5L5CiRK0Ep4cgr82fMaHYm4+vNTIZkxjTIL1fy9EpVTSzezsGwEurCea3BPr0ESpz93WxBZuR7jLcAzuzxc4uBUrtpfiTEw9fqYYNd/zwHXVjEVwq34yFQd9gFYPshfJbwlkFq0DRfKOgLRLxpSW0VkuP7DeOt6Gw3cLcUkbdVxXApoJNSIl0sv4omEOymw0SUZb26Y3LiRDBDoA0Gxf4IYOj48JORWjFQVDfzaQottAzsmWG3zU/twKyKcE4BBhFKuSQnqf1T4XtAUeVbp8rYK6/THMm2i9+4L01mTxzrObAmdE2NxRQ6G5SW06mByB80E7iRktfSKvYS0El8/lzu9feWbuox3D99cFbdRmYBRhEAqoGSl1K/sTNDdQqWKZC5tWRkOlf2LPOxkbA5mTf4QmEHD7gNCTY6MGXRFGolhPLl7bcwb0xziHcKTfNXHThr1FwB5rTSPrPKMo9Yh+hg792KjKcZwoEK/LZbiIHOtvGvhKqpWWYX1EGeCBt1AZ6fuZpqiGIfc0uwZfmCnrupkyUob9doUDF49jZpL3TGvTMF/iSXWVUHQBAidNHxDogLGNt6yETU76Bkedmg7Bvq0CM/8nwy+kDRmkhVy3p8czPOoLsJpwa+SdPKt1xJD7ZoqJOp/tQ0Ma+Yl4J0MQBHo7kega9vM7ZHhgR2gHlTD00suQWHCvoIQi8CTDKgfemKhzAu2b+M1k+e8JqLHVp3Nd TzYQRmwP JjN7ivBXL3hXDmcnVe5G61kSFlciuQSiu3LfefM4Tu37cb/9jyxvuDLl1F79YCUmjqlo7tcLRGvHtTcA3N5ZNiAqsjve64UZckTdKVP7vPtD+kYCawohn2TVWUxsnP467J06FV8MjQ7n/o8SXzrXO1YeLMmm3brv7BP4Xu+IZCiWpzF52QzJ8dTKi0J0KvLe9ELvGDTBPeVbZEygijfVK/mt/o/ZIY9tSvwnZX1KF3Z+YIntoNY2Vum13tjDZkzEYF7F8sqt5i2qttOkL0xQbZoUPuQ5cKfp91qV59bQUroDrKm5oQ8DRLNH37IWe+oPrJVMvhAjEDNrmcBAw5XWGU+krZCoL4DbvMvaTAAF+Hqk9yJxYVFB4M0BLdq3O8b8M1KUqDkgsnfhEI++ws+CkZgbEexEXGRPubr0CXItMVfVBRDxdKTsO0s9CO2rCqU6p+EcpIDNdIFje1GA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + bio_for_each_folio_all(fi, bio) { > + if (!err) > + folio_mark_uptodate(fi.folio); > + else > + folio_set_error(fi.folio); > + folio_unlock(fi.folio); Super nitpicky, but I'd avoid inverted conditions unless there is a very clear benefit. I.e. I'd rather write this as: if (err) folio_set_error(fi.folio); else folio_mark_uptodate(fi.folio); Otherwise looks good: Reviewed-by: Christoph Hellwig