From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5F35C76188 for ; Mon, 3 Apr 2023 21:19:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 112836B0071; Mon, 3 Apr 2023 17:19:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C2C66B0074; Mon, 3 Apr 2023 17:19:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA51F6B0075; Mon, 3 Apr 2023 17:19:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D7EDC6B0071 for ; Mon, 3 Apr 2023 17:19:39 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8BB59A07BC for ; Mon, 3 Apr 2023 21:19:39 +0000 (UTC) X-FDA: 80641346478.15.D5F24DC Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf28.hostedemail.com (Postfix) with ESMTP id AA7BFC000A for ; Mon, 3 Apr 2023 21:19:36 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VCcYybWY; spf=pass (imf28.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680556776; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9MIwuslKOv23RmObbF1opEGXBO5SntQiEEpUaiQ2xkw=; b=DDMamBJh7jSHOR1c4ZiBRZxT1UAeec0szh43IimuU677wfC8USmv/cJxwK32g0Qff+4bu6 HGmCeSHqotTtC+bLRUISRJPQAyB85t5e4b88ZhiNLmm9+6+Dvtsc8iQyVFchznM8sUZIsu ldLUrNSVPQ9QKBJXvaywumvvDrUcsDA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VCcYybWY; spf=pass (imf28.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680556776; a=rsa-sha256; cv=none; b=A2y+CF3kF+0BtFmVHwiY+rUWcptAwMq4iZXnKXphSDgAoLDQS23zze6IGFILTDODWZr73+ cVWC+BnZjS53x3y5/mAI+YPMVXA9Lcr6D1R3xPRYEnfyy6GwsQnkLk3nSkwVccj+aoBBBd MBhZPrOC2cWdYo7/F7UhAI2TNctXTUs= Received: by mail-pj1-f46.google.com with SMTP id f6-20020a17090ac28600b0023b9bf9eb63so31898494pjt.5 for ; Mon, 03 Apr 2023 14:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680556775; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=9MIwuslKOv23RmObbF1opEGXBO5SntQiEEpUaiQ2xkw=; b=VCcYybWY8EXxG2djVLd2aJwEv3cQfYWsN6xic8+5BBdab6G7SK99uEilDzr2s5ecNm EUSnIt/fmVyLhdQ/v+j+mZH7wWt29jvd9IjTBPvaLo8Kp3I4XtcysEn8SChIyz+VOdiT fKK8ywgiCVhVQBHjW/qt5N4h1oQevA4ZhSw4Q6AI38O12K2HrGD702U57RLP/i6nlG/e KWe+Frfzxz1hsWj3xuiZMwARooukrDJNwK1NdHQcR3lrWQkWLLbfKXsKqinoM8iP8FtD WxUIintHLTELgXMfeWZqO/KwVems6bBzZ3EiqryVfucKxRFlHXBmeTwzQbcwjkbZYTuf 4F8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680556775; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9MIwuslKOv23RmObbF1opEGXBO5SntQiEEpUaiQ2xkw=; b=eK8heNhIKLxJqGw33GAitr/g+vtTiGEyk9gRBB77KrNQmAA1LxkGXbbojxue/LRqbB ZDOjsiTyXCEAZFFsztNLaTgZQIyLWVNydRBdPg6y6MialkeGai9muYOMDk7vKP9XP5ND v+xgH3/KSaRDxPQU77Wwa3iSqGZIMt0HG4bqZWSRUpkWmXIhMVcLt0tPTitQDXf/PSa2 qL15/xfpX8gbknceo2JyWWQ2TvrSCnKwlnO2Av7msso6rTw2ZPh6ukzQv0KSWKrzt6Uo WxkIDLTK9Rg8t8A+iw2cxkI10a918tl+OXYrnIVFs+DLagyLX0KaLg4eZU8QXRMQvH2w 13Ag== X-Gm-Message-State: AAQBX9eW/KjtpNNEYpUu5wHEkYPuFFDpkPs0ZVJPI+7YgcmQVFgSMqAY DoRrk4JlJjtHSSWqh2AOLm0= X-Google-Smtp-Source: AKy350as6sEsccwjl6/R0AjaknzzuuYQpBo6CpKe/V5UwkgYSell9ckH3bWSIgb0ayPm7SwKy77zWA== X-Received: by 2002:a17:90b:3b4f:b0:237:161e:33bc with SMTP id ot15-20020a17090b3b4f00b00237161e33bcmr316502pjb.16.1680556775321; Mon, 03 Apr 2023 14:19:35 -0700 (PDT) Received: from google.com ([2620:15c:211:201:da37:a7fa:157d:2446]) by smtp.gmail.com with ESMTPSA id mr17-20020a17090b239100b002369a14d6b1sm10083835pjb.31.2023.04.03.14.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 14:19:34 -0700 (PDT) Date: Mon, 3 Apr 2023 14:19:31 -0700 From: Minchan Kim To: Pankaj Raghav Cc: axboe@kernel.dk, martin@omnibond.com, hubcap@omnibond.com, brauner@kernel.org, viro@zeniv.linux.org.uk, senozhatsky@chromium.org, akpm@linux-foundation.org, willy@infradead.org, hch@lst.de, devel@lists.orangefs.org, mcgrof@kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, gost.dev@samsung.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 1/5] zram: always chain bio to the parent in read_from_bdev_async Message-ID: References: <20230403132221.94921-1-p.raghav@samsung.com> <20230403132221.94921-2-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230403132221.94921-2-p.raghav@samsung.com> X-Stat-Signature: c64kcegwspdmegnx4d5ony6pnmrr5f3o X-Rspam-User: X-Rspamd-Queue-Id: AA7BFC000A X-Rspamd-Server: rspam06 X-HE-Tag: 1680556776-155129 X-HE-Meta: U2FsdGVkX1+OuJPipVFwuc6cQOEeN6rvDexcCtvavGWz9Btqx7g0P5ba2sITV/Ps96RwOMnut8ySCgHKPOaCcaNOBJQuebUFsaNA5jDqAJId2fhlMbyHzjmQS1+u06W7QLyO+XozR2u9mRubCDmrFELJ2+GVJrPSRivIA54aic4tnCNytFyAsQyARx0sHPwLyVFoUVjT8GDJ59RHwe+HjT+EIq5+x3o9x6A7Yp8RlhiFkTnsrFS+k2n1IpU9PHiNhZfA+MPLtUU24cfsQYnjFfwc1bDTw51Sy8jwJF3aWYprm1dSIxHCSbQhaslNGqRtfodm+IZOr3bnpSVkwCqTh6bfjAKk8XPmBlVruyTCnmka1B1oSzdB3SeRg6Z+9YhmfaGiphkHxEpkorUfNX75DEOVgei0DIhrBQBD7PMEEwNZ6Ox5Ppoi1y0nqIj53LS+RL8mlnsW6eDHCoyCd3ebaFynTfuKAtZAfNZX78PWw1RT/61d78hYgoiTPr7cKW5oRMyjpkDIP3HzQpt2G97WzsDJQyYcZ4Ley/63MnN/lSlW1618SH14QRiAZ4WPaH0G9pTR7LtjBgmypYO1PzDD0ydw0fIlVtJ3fAD5LeNR4MFbgpXI5dxRKYX/QjKkkTaThyD0DQeOrLovBd9B/P6IQXCtzAfhxedTYZOpl4izDOe3vs30T07hxTfp2EOpFsSnRWm4f36VN4Yqj5I8O4vdXlM9LhyZHB5hRK/YvlZhkohs4lFkaFjWZa8TvD1SE8XyAHPHjbl49jSqeHPKmI1OfWAuAPi3lLzHwjjfVJM5UKykjC0l8bz/Ntc5NulbaD95airGx1IvaVREJ0sUzGHYQAS9K5Egnq5gaxHxNqlbP1BLHzUXdOgsaXB+kA+cVY9+Wcvs9pgAyZQvLgR0ZeHitIhopKTgwPzIN9blM9Q6crkQOQn3uBM/neoHqDpj4k/pialZxO8yJVFGSi8zCkn p8XgWUG/ fqihM8Wcrm+B4xqs3amX23KoR1cCrNADBygQgPL+TbCaZbRPxIdR72S1kzGJynQwLOe8wnDe1I4FIeYYEmlZR0CHCd9oG9rIEnBEYNNjd/5ZSafvMXbuWNdFH0gIi5CPH2hH7l/+jLrXkVWNfr2jndck5t7uLJSKGnP9DlosMDzGaWysXjLqxD44VPe3swC+EFvGc+qG//zFAfXgk31dX/IYaP9jJaqJzIH9ewAa1LbAvlTXUwb3qk50XmfzQa6QWvbodOk2ru3OY8AV9kzwLicRLkcqo49YUtL+1AM6Ebmqq5EKcn1RRc71yjxS1y4wPTp37uz4GBDcPVDbcotUqjIY56qL7UO7A4jJqOm3TmWLtu1yxIbFGcPnDi761q59tJUsRc7eUf/riw/8rxQagrfQMzZ2A/iKoDRDsXxk0KWF3qFCvUcpDAExMaAxnIAzjYx4M5xPWXDhbG3D6HIU1qGjNMNSgAXnnfW05PYueJGfVeNQwrFC6so3gcExvCdL7IRRIjCSe/mEX7S+1rAFjdmPUm27zZYiThu7QFEsFN8pSc4bIqNdk4dAQeezx7mqy8NHmdz4tdtsQqrPiTTBHUzD7E44i9Zpzo1hVtl97zdOWnMVHijc5hnyGiYMP3ivJUVxKUK2pwWIXHiN+QHAD/N1mxJ2kkOSiC43qNvqUl40DzWP6uKg3jybcG+UB1EGk5q3N1QaZRAQDtMw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000424, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 03, 2023 at 03:22:17PM +0200, Pankaj Raghav wrote: > zram_bvec_read() is called with the bio set to NULL only in > writeback_store() function. When a writeback is triggered, > zram_bvec_read() is called only if ZRAM_WB flag is not set. That will > result only calling zram_read_from_zspool() in __zram_bvec_read(). > > rw_page callback used to call read_from_bdev_async with a NULL parent > bio but that has been removed since commit 3222d8c2a7f8 > ("block: remove ->rw_page"). > > We can now safely always call bio_chain() as read_from_bdev_async() will > be called with a parent bio set. A WARN_ON_ONCE is added if this function > is called with parent set to NULL. > > Signed-off-by: Pankaj Raghav Acked-by: Minchan Kim Thanks.