From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB59C761A6 for ; Mon, 3 Apr 2023 15:16:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04F5D6B0075; Mon, 3 Apr 2023 11:16:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F40DE900003; Mon, 3 Apr 2023 11:16:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0897900002; Mon, 3 Apr 2023 11:16:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D160D6B0075 for ; Mon, 3 Apr 2023 11:16:30 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 53C7FABF74 for ; Mon, 3 Apr 2023 15:16:30 +0000 (UTC) X-FDA: 80640431340.14.48CE4E5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 3CDEAC001B for ; Mon, 3 Apr 2023 15:16:27 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b8hWQDuZ; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680534987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lK5YNXaya6hGDvluarLJ3PrXroCIynGO5rYCK52f0Ys=; b=VukOokS2PiI+oghXHXsL2EzITkDmK4oVOMEwqKsEnwEHIap+20i9rwgQt7BR7JX35s2/aG datb+2TONF6KOGWrSlhzKI+DXWynSGm7g+B0E+FHRqHzdjBuiXkswKPrLzAz+icTwNfMUO GbCmW0xHUPQKip0j1Cym28o4XBH/c3Y= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b8hWQDuZ; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680534987; a=rsa-sha256; cv=none; b=EWGaSR0dscn8OIS1gjwNDvRv1FqnzID7/Cevv9W3FIE+aJz3IYXDkUK3FP3EPAMxBipDQD y73itO1MQJ4hdpWy5lCIRJP8Ag7/BgtK5/PliCXxrjAdpNlcQWNUwTBK4o+aqoqV+CmlG2 MfRBm93YR8SJs7QTHVBig+TSmmpCDLc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680534986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lK5YNXaya6hGDvluarLJ3PrXroCIynGO5rYCK52f0Ys=; b=b8hWQDuZVx/yJCmqf3DFBnlB/W1d+rGF+Ec7xGd+z7s0ALNAlrF/518QQHTYYgtfuSp7Mr bh29v/PhztQqOegNDO6SVQOSxg8MSJ37VfWdtrTBgiaNIT4mo0qatJ5hymbukiKAowIcFp lCD3zulSta3ooB8GNqhEfy+o9Xbz3tk= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-414-NlktlRvFMSWNWH-GJHF2Dw-1; Mon, 03 Apr 2023 11:16:25 -0400 X-MC-Unique: NlktlRvFMSWNWH-GJHF2Dw-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-746bae78af3so95166685a.1 for ; Mon, 03 Apr 2023 08:16:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680534985; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lK5YNXaya6hGDvluarLJ3PrXroCIynGO5rYCK52f0Ys=; b=DFooPOssTkT4cOt29ZU9EGFFzQA9H4IqIdKF4VbMR71KKPlXwVNRJ/StHNmdsj2Gth 3r+eDgt7nvz3xcC+pKWYIyCixKSVjTmTlHhCW9K45XlZStI82vHN3fp94SDnQZnrwAza vhL9IgcaWj6ZLDDyzOKQiyQSmcCRvSUdSUK5B/QZKyb0BFpMv8rT64nxqDNKrFxyAFMn xrsYI7YOD0Y6toGM27w2LJYT4HlXCQM2ZojY1nDpez/OrtluV6OfluuwYpi+kDrPDAEk mWBRTXrUXYjhBgcAcINuktjGB1UnThZgGHmFjpb7Wkygr/ImyY+2TRvip3dhLE4y+pV/ gP3w== X-Gm-Message-State: AAQBX9dKDkdowHoEEVmfYmhgSxFfd9Mprfj4n0NPMyr1Y2jOESMrIJCE gVwqjLYTQMbjTeF/WAwvCMyAMGQwYuy/TB1QQyetw8w0hzUj7qVvopg29TCgrKnocRlQq0a+i7r kphoLDrlVoRs= X-Received: by 2002:a05:622a:1aa1:b0:3e3:8e1a:c30b with SMTP id s33-20020a05622a1aa100b003e38e1ac30bmr25606619qtc.1.1680534984895; Mon, 03 Apr 2023 08:16:24 -0700 (PDT) X-Google-Smtp-Source: AKy350ZAzDpim/v9s09Ky3zn1VEBB9zCqh+JtA3x9ZFNrz9AYL43VbUuDGmBlYyzt5tUCR+ZmEHzGw== X-Received: by 2002:a05:622a:1aa1:b0:3e3:8e1a:c30b with SMTP id s33-20020a05622a1aa100b003e38e1ac30bmr25606583qtc.1.1680534984587; Mon, 03 Apr 2023 08:16:24 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id z5-20020ac87105000000b003e64303bd2dsm2197685qto.63.2023.04.03.08.16.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 08:16:23 -0700 (PDT) Date: Mon, 3 Apr 2023 11:16:22 -0400 From: Peter Xu To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Andrew Morton , Andrea Arcangeli , Axel Rasmussen , Leonardo Bras Soares Passos , Mike Rapoport , Nadav Amit Subject: Re: [PATCH 07/29] selftests/mm: Merge default_huge_page_size() into one Message-ID: References: <20230330155707.3106228-1-peterx@redhat.com> <20230330160705.3106966-1-peterx@redhat.com> <20230331181535.GA12460@monkey> MIME-Version: 1.0 In-Reply-To: <20230331181535.GA12460@monkey> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 3CDEAC001B X-Stat-Signature: 7jsnn313muekw98hm7chxgo6e66hstft X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680534987-476771 X-HE-Meta: U2FsdGVkX1+xzPEWZvV+LeS7/QeEK63uZb/u5/YXow7tqe0jVBmpy2L3gEIN8qWfg/WPGrJ0pzP8XLqLsTvbvU0y3S3Wl/h3oZB05+dt/O07d+UQHox/Jy8Cr4itFljCkCdFNVrbvDbuaVnTap+uanmelUQZUeYavls6NM7p1YeGsBKapce3DV4q3erWdeqXcpAe90+kKZ7hrIlDNmGjRFqYbAE1pXCHV5O6MEROCswHrZT42BHtWUCjyLv+aO6dYgHJ9E/vYGIk8xQ/ZuwetGh4LVBZ1BcBUVAMrUYNyfwGEBfGiechYJv8nVv9+wt3irTc7ZCBhvhnKH8/LytZYO2VCtt+xZt2mZ7APBDYq1n6W9BHz7/4WYMu+IdnL6TdkTg33CdiKCAF/XMf6CbVXQSM27QlxUaQiw8D+Y6OP0Dm87zrxcJ+HbwLJE4LhNopSQRsgwKoeRBwhQx3tHennmsSnschrNI4kVrXxRPgC2awn2GYa/2nmyCTjm5LZK9NhWL4aDHmJQT3u8PQ/Q2gSW53gLyVPxo/c1zR+kOUysOvMhZ7pu7UA+IWEe4mnimdhLZkg3ZoHVYb9EUzaootcmxv4rJQNlwmsjEacStpg2hhfbZ6EDq0vwPmh2Xd5kGZEipTnWK5YLx15Xe+nqWTjKvmozYVSsZ+ytoesRdfFzcFh9ALhO3FoFVC5Zuww3ykytLvdOpNZ9B0S+mxEjspOOmSohYG8ZqnxnHgDaLYb5EkBwMfZDknVGIezgxv1vavKRyCYg8blTDbcL3gxxdtD5uwQrqocNSLqvJ2UE0wTRp1LIOU+DYzKFhH8jY80fXFP4tYNkyagsrKImFB/Sd8aNtkdKAMd3GVNBkyXmMUdS2okeeFKP4IQnJGLdOq5Y4V9VnfDyb4YZ1+pPmgoDAAsRUJu1fIYebaoaFSB+Gj2CEO1WwA+IAJJ8IFsEE5TgWEf9Snt8YvrAK6N14cqFB nAA5a9+z GkKMmizBH5PLJXxx5P9T5ngLcWl5PFTrZ7oTKHF6Wq62hAoeJSEReD0SgiEU/7psUsmKRkX3TORAB3bQB3mh/MSZAa1qJYjmXlCIAWE1Z9eIdk67aDuZK+kTtPqroppZCIuftd3fBBdbDPQXeB5HHGratNEuwsNWH1jO64i4a+vJzt8lQs+8XcJeC80Z6WaebmNaqB7WMmk6yrYjz6yKamU4C8iqjZ3mgJqTX2T4VNzG951imIs3yEHJSkdwh5KSXs84IaihprMcO0FngZmsHMZC1Mx2wQ659i12/pYzvWEUjYqywrCpO3rg7+x3HGk6H7LO/tR/f90EleL/ss6uUAIffpEkj7OLsSaTpeR3+iQYyJQHwrXB0xyPASQaHxS9ajWA9V4G7M4wvNWgHDgeDccU8Gkkrqbf0GqA1ozNyvxRjA2sWReXqzOnQMI3ubsHn7r9KVLe9IYTBLutUtbnXmeYzCkQcmVySLFMjHosDdBjYkEV4v2XaYPpfJ/6FUBRZJRLSbY49+rxQ4OhDQHpaPLwA1HMgyO7wpZkczR4ftHg1jx/V1LipoV70bA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 31, 2023 at 11:15:35AM -0700, Mike Kravetz wrote: > On 03/30/23 12:07, Peter Xu wrote: > > There're already 3 same definitions of the three functions. Move it into > > vm_util.[ch]. > > > > Signed-off-by: Peter Xu > > --- > > tools/testing/selftests/mm/hugetlb-madvise.c | 25 +------------------- > > tools/testing/selftests/mm/thuge-gen.c | 19 +-------------- > > tools/testing/selftests/mm/userfaultfd.c | 24 ------------------- > > tools/testing/selftests/mm/vm_util.c | 21 ++++++++++++++++ > > tools/testing/selftests/mm/vm_util.h | 1 + > > 5 files changed, 24 insertions(+), 66 deletions(-) > > Thanks! > > Some of those copies were make by me. Sorry. > > Reviewed-by: Mike Kravetz Thanks! > > BTW - The same code (even with '... copied from mlock2-tests.c) resides > in the selftests/memfd directory. I did that as well. :( Suspect it is OK > to leave the copy there. But, it does make me wonder why memfd is not in > the mm directory? I don't know either, I suspect it was just a personal preference when it was firstly introduced in: commit 4f5ce5e8d7e2da3c714df8a7fa42edb9f992fc52 Author: David Herrmann Date: Fri Aug 8 14:25:32 2014 -0700 selftests: add memfd_create() + sealing tests So I left all those alone for now. Logically they should be merged into mm/ indeed, perhaps in some future cleanups. -- Peter Xu