From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC4EDC76188 for ; Mon, 3 Apr 2023 16:16:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DEF56B0075; Mon, 3 Apr 2023 12:16:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48F106B0078; Mon, 3 Apr 2023 12:16:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33AA66B007B; Mon, 3 Apr 2023 12:16:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 20BED6B0075 for ; Mon, 3 Apr 2023 12:16:09 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B525F40330 for ; Mon, 3 Apr 2023 16:16:08 +0000 (UTC) X-FDA: 80640581616.23.ABAAACF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 76D02180027 for ; Mon, 3 Apr 2023 16:16:06 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Vd1Gv5LE; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680538566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V3WVVlCgDVu+so3CtUZvMFVtwTzfAtjj67XqfHbOtAk=; b=Gh4zZolpnd0HqtIMZHvU1mYHuhsWLcaNSq1ll7nkTE15LUErT8UosvtaTsaVhBfxeek/yo tV45eZ1szDxelFcC+Y69IOERQ/ad3J/5LorJoOGxSbjKK2D2ngTRtChEc0tGH/JMz1DX12 OAvThEnLa3ldyzgj3wIUYwyeAX3o8cs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Vd1Gv5LE; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680538566; a=rsa-sha256; cv=none; b=vY/PTMnhCLvG7kVjmOKAPNNVHV+vvdEzPVBGhD0MJLtL3EVubs/JGZA49aCH1A9tyISWoj RrT/Vb1A0dOcuo6prHHLyY0ZZ0NW2bvuwN/Nda6+HZGbNIQ1yXFZ7Ci9nbNLEyYW8JrsFZ xq3I5R/OpD2VYP/u4n0Zb4YaXOiT2u0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680538565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V3WVVlCgDVu+so3CtUZvMFVtwTzfAtjj67XqfHbOtAk=; b=Vd1Gv5LE9X7OAgvSgJ9HZVZkldb9ZmH3ZErWphwKJ3HFKmjLeSIJiSeuadYVvNlUv/AqAt xrbQsql1op2b2TnPUx/5dYwFLLCcLwkyilXWOonf27cUVt3B3y9FASeTZ3dXV4oefPIAnP itkkP2aX462JGGl2uCTpW+7zQIobhqk= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-412-jTC2u257OlmlkN1zx_7-Ow-1; Mon, 03 Apr 2023 12:16:04 -0400 X-MC-Unique: jTC2u257OlmlkN1zx_7-Ow-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-3e2daffa0d4so9301651cf.0 for ; Mon, 03 Apr 2023 09:16:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680538564; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V3WVVlCgDVu+so3CtUZvMFVtwTzfAtjj67XqfHbOtAk=; b=AkCzIBULAqH8MWPbebibBFbWkocpnISygt9bIQG3YWndmmV5PdM8KpH0oA+/peUqzK iTW3/xtceMAC4b7rGVXxjNTubpEaCP6s8bodgTMEYlUKKWQonslh3WInfoVC4vC0F1Tl zmov8cxin9+/trQqee7MD7X03/ZMNod/sGAinN0DxN7N6xVHZca4nQSnSlWzRtfQhrbc RcssIGIvT6VDBjQNpQDUuPvZgPf6XzK3l6LH138RTpHOfnDP7feZM2DA1QE8vhMydHFN LwzjjyPYmVvP4WMCr2q7t97WQsHCk/rUUR0bh7ujpXfop+H53zl2xcEV7BijewNOdh4S /gYw== X-Gm-Message-State: AAQBX9fHT3qrvLH01PEK9YM4++v6q55gFK5eu2PsqSw1+y7y0aPuKJ3V fL456sYuduYOZVlhXoXezDs5WUSeJ1Y34I9mrnd/oAkreGtgd9JZsoFku39LwBZu0q0Ez+SGLps 5hobTjCDvdjg= X-Received: by 2002:a05:622a:1802:b0:3e2:4280:bc58 with SMTP id t2-20020a05622a180200b003e24280bc58mr25404667qtc.3.1680538564165; Mon, 03 Apr 2023 09:16:04 -0700 (PDT) X-Google-Smtp-Source: AKy350auaIF1EPMeG/FZ05u3bLup8PpepYVe1UIip6Lm/q9oxc9sQKzvvEMdN/9/Vh965nKg3bZ3Zw== X-Received: by 2002:a05:622a:1802:b0:3e2:4280:bc58 with SMTP id t2-20020a05622a180200b003e24280bc58mr25404641qtc.3.1680538563912; Mon, 03 Apr 2023 09:16:03 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id 203-20020a3707d4000000b00742a23cada8sm2854660qkh.131.2023.04.03.09.16.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 09:16:03 -0700 (PDT) Date: Mon, 3 Apr 2023 12:16:01 -0400 From: Peter Xu To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Andrew Morton , Andrea Arcangeli , Axel Rasmussen , Leonardo Bras Soares Passos , Mike Rapoport , Nadav Amit Subject: Re: [PATCH 11/29] selftests/mm: Drop test_uffdio_zeropage_eexist Message-ID: References: <20230330155707.3106228-1-peterx@redhat.com> <20230330160717.3107010-1-peterx@redhat.com> <20230401000317.GF12460@monkey> MIME-Version: 1.0 In-Reply-To: <20230401000317.GF12460@monkey> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 76D02180027 X-Stat-Signature: ramx56ih3gq4x7xo79n8g6hcep9xnppq X-HE-Tag: 1680538566-983960 X-HE-Meta: U2FsdGVkX19h3IRFlIUp7WwHtL5bAwhFRVQy1wet7NWb/BFGMLdqpBxQ4wYu0w5bwYoVSsPeOY9qBHT/Nh35LSiMXUKi1pSHKjR/zqc5Tl6tNmF1Iayy6VUaWv6OmpJ4MfUm2AATuJNmyuN7gZNMGijg5ocf/u9VCs9Ru060kSUv5Z9vKDcUIlkkt3LjSlMDRJDotCV4tAPxI7X0PDeM7dSyjVE1KnhY7owI8Cjy9dONzz2w9wENq9u7BcLKbqwziuyuXaaoHgtVvjezyh28fglF9W5jJIQrFARgWMVbglEYuKnV86TijoqjrhjzXkM5zvLL7M9lvKd0kIrN0WYWmoN9zXlDIDMBMjnAJijwOW3OUCE2t+7SDexdxwNbiUi9SkWo/n/6nxL+elrIDtGb+VLuv5K4P5XJFFA4mEilBpoVEQYBeISjIu87P+qymOWMoI0Y0ULSe5W7+JlbzlzorurHMvOZVxpscJ1Cvm+X6U1e0vI9FiUEXrJh5VNhRsTN4qrLYaUGFwg3+TWb/ho1zw2gqhzxNJ2/T73zdMiovmhbBfNyswsSYcMARxxjh6+xwz6wtJ7/Gvf4g7nNJ/WyRGozpCG5MUSewPdHj4o06pCGN8ooGX/sOUNFUN89e/hxHBauqvECeSCp2MX/VGwJnN90z4qy3PeGcsglguXqaln5CtWwNOqsSDHqY2DjwzL37sZH3ekYkEON+5tjJR3Epm2q7DsSZTWVVKYnBeC2dxvBntGrdlOzIGBcCv0xduPdg7oFBZs4ZmPdLufdjgESSkS1akmhWQoJ2aMJCt70tXWRjkd/+g35B2Jn0Q/GoaGTvGA+dTvvPQKzTCK6fusFWQhrMN1MdNAh+pKwQepDoyOJ5c7ufHTHs2+AyrWITanrih3dR3abFfKSjTP8HqGhSbJK9DmUBwpvpUhetKbRIPmWqv2aNmpDyDo902u8XizcRuFnmuxfSy4EKt3c1Pb Fnrbsx9d vfZNoo+m6BZYqAbLKqBEU/ZwPOSOr9b2cjZZYHFyPe7Gt9eKlNGJbA66nQO8QejSjxWPaoaOBNKEICQmop0CF1dUgdOPWU/Ub8a/a4qvPH4akrLlT3is8FjYeM7//0xmQYAxfBlxd9YkGUTTuRqfjt3UqGPpNNDiM1/RIkCxLVaWhuV0YFxKvYxDMQg9KlsxoTOR+F3kvQdtmytpFYVLXCYu+AJi4fYP7jWpX3GY9+PTO0vVt37/yyo/mbkDR9Bxq82vuIviJujzrIBYXMsI98k16TvNoQulV/FGdcur3+jrMOb3KAub211qL0hXO1wTcOPJnBSmEvweyoE9qWTN5cNQjXmdxjn3BkFGOWPnqvPkBMHG3tuZmheeWAHWgdJdbG2gtN7WZxPvYa8Mc5l7X+HQqrpG1E9e0ClDYqIWQztsQbvFEW4RpjpExwz3lq3f9SDsa3P7+oTPKDxFToMrq+a7s1SQMTElcQ0GWTXJOHJd9vc5H9afJpkYPtVC2zrb08bXUk0p4uGp1RlarBnkvXiBk3noKAleVK2q3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 31, 2023 at 05:03:17PM -0700, Mike Kravetz wrote: > On 03/30/23 12:07, Peter Xu wrote: > > The idea was trying to flip this var in the alarm handler from time to time > > to test -EEXIST of UFFDIO_ZEROPAGE, but firstly it's only used in the > > zeropage test so probably only used once, meanwhile we passed > > "retry==false" so it'll never got tested anyway. > > > > Drop both sides so we always test UFFDIO_ZEROPAGE retries if has_zeropage > > is set (!hugetlb). > > > > One more thing to do is doing UFFDIO_REGISTER for the alias buffer too, > > because otherwise the test won't even pass! We were just lucky that this > > test never really got ran at all. > > > > Signed-off-by: Peter Xu > > --- > > tools/testing/selftests/mm/userfaultfd.c | 20 +++++++++++--------- > > 1 file changed, 11 insertions(+), 9 deletions(-) > > Thanks! With only passing "retry==false", that code is indeed dead. I had > to read the code again to understand area_dst_alias. Thanks for taking this > on as the code is difficult to understand. Yes it's very confusing. I plan to move on the cleanup to remove all these global variables at least in the unit tests, but I'll first see how this one goes. > > Reviewed-by: Mike Kravetz Thanks, -- Peter Xu