From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BDFDC76196 for ; Mon, 3 Apr 2023 08:38:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DC966B0072; Mon, 3 Apr 2023 04:38:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98C136B0074; Mon, 3 Apr 2023 04:38:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8534C6B0075; Mon, 3 Apr 2023 04:38:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 75BCF6B0072 for ; Mon, 3 Apr 2023 04:38:31 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3E164160A50 for ; Mon, 3 Apr 2023 08:38:31 +0000 (UTC) X-FDA: 80639428422.03.62ECA29 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf05.hostedemail.com (Postfix) with ESMTP id 95A87100011 for ; Mon, 3 Apr 2023 08:38:28 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=LDAThqfA; spf=pass (imf05.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680511109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZnIw06JprC7dy+OnhMRvOYKEzAkA2puzGDnOPlmZGCQ=; b=GDUIbLmtTg5DDefkuuc2HBI/al7jOe3rMYPlGNnFiQ612l0j5QItdVwsX8pqQXH9Sfbxmp 4rLOs4c42ubtyX4Aw1EqPtFWkSYR244+5Ow/ykAF+N/hnGQMfNc1ConbArHKy5hrc/9JrI tceWEbGFpA8jfU6obWz5kkLJsUbsQqE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=LDAThqfA; spf=pass (imf05.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680511109; a=rsa-sha256; cv=none; b=aHEDlJJnUtCNSuoJsOcv/RLdzheZfVGmqBFreos5wCsvrHzg/cn/kZTbVZzHFBrS+etMGq TLtrkUljEx+SFle355IK3H7ckKOi46HqCtt+BZgcv/LWYgomMaN3psG0hyWFDQeIDNdizg gwR5ulZJ/DizF6/0bIxPUHwbBNMOBms= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 943051F8D9; Mon, 3 Apr 2023 08:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680511103; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZnIw06JprC7dy+OnhMRvOYKEzAkA2puzGDnOPlmZGCQ=; b=LDAThqfAUeP8YfeXSMx0SCHxnohK7Gj/nCpVhVUNjqwdqETlqzrvBDKy6zQjJyHIXkNUrb W6q2FQW0lYcUVVPC3UdRINlfnj6L5qLDp56/Q/IMjloPT68YokJAyiWkMM1I2SWlg8W3Ab mdMS9LC6dZdFbLNpceTPxyFhjNTS7Bo= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6879B1331A; Mon, 3 Apr 2023 08:38:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id k4RGF3+QKmQQSAAAMHmgww (envelope-from ); Mon, 03 Apr 2023 08:38:23 +0000 Date: Mon, 3 Apr 2023 10:38:22 +0200 From: Michal Hocko To: Yosry Ahmed Cc: Johannes Weiner , Shakeel Butt , Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Roman Gushchin , Muchun Song , Andrew Morton , Michal =?iso-8859-1?Q?Koutn=FD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 4/9] cgroup: rstat: add WARN_ON_ONCE() if flushing outside task context Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 95A87100011 X-Stat-Signature: 8c5x3arb4betx91ya4rprjpsi3oqwjpw X-Rspam-User: X-HE-Tag: 1680511108-467187 X-HE-Meta: U2FsdGVkX19e37oYdfkR3CldAcTYwmLxanN9TWKxtIvqysDCd7DD/T1PGBDUnqnsIsaPS29VdaPzO/MxZpa4QBT3oRICT7eQwMYXTqg3tjCixNhct3F3vFVP+rAkG++FgCv/ikUL+ZFucKWjwGKHnLwQUqhB9ZsCb366nUEoxmmq1kzF5V577C/9ODATilX9kATc+XEMCHaA0ODarZ+KXiifktZzbkiro3ResIC9vwXCXnyhNQ+Gr9y0SZwMeERt+rgHryPQfVuenG1w/In71ZPeDkVGWObyo30fruNEqR19pQmq9Ajt0qLinN18mkR/UafyUu6XsQf5FwsvXKGmPRIg8X+Mf5z1DEWT8kACixymv+roCJ8OWgnkPVUvAZ5OkfNITXQ36LEjkAuG9sUJ10ryD3Lz3wWvSC9tvF23IUnlVVxoIgohmirn5wi/YXMkL6hdHbs+ftvMuw5fWAajouffEMp/RM9pYNYninGUiCacMt/ZnmSTti6asO6Z+0dd+w309tpYMq9poofT7muwaJYGGuPerIX3x5juk6hymvoSm/zh/R880juAQoz80qOPB1gjBT7c+KH//fJEO8cERe6yALC4xDLHtkF2CE+WYf23MFiqQeGI6RmoN+hPvlU3DJB7tM2kuc3mEp6NFIMKp59mU5sTWfp0SXiEPwvnF9Q5cVOiFTzwLv5Q39s+eLshvzBuJByLalsjtBawgQD0r2jfX0DshO1mtNhjkJ+rIoluz4mY3S2hLlm5tPfkNyH+mbrAcyLwNCdPmA7bJp2JDaxM1LlnD2KJ2PrzUdsLIK/t8XjXMmTaN/KuKa+y8znestcgqxKwsDImEzdJlHkricZUg5vAvgflCCfIncn4SxlbK+0F3M9ksJqRLkR8/8ZS73bOj6mjQ8yShTnK0XskCcC4WiP6JxfwdQDC38wCe7o+99TVoT3hgboduJqKFkxeBNcCeMLELMhyJ21UGiU DnhmHKQc cZFZHoeqIKFANl4Z+tsNsjUko8Ov6auPudOFna2QwT8CaipOcVJbMbAuAKzoWsT1lNAlKMJ/DTu+Ggqo5sWNoU87W1v6yLhkKn7TPEYwvyvdP6OppYdHP4F4Z+M5N0sz+uhckdvOC1g3mzan5fHmwBJ0rahyLu/WkDjQsgqEKJsrbxTHI3vKaaJ6y/tJC1zpl0/Wk0YYM8rqx4jF5YcNhpGeqjr5BuG10XX1T0CRmy3x4oGCZ+YqfA3ebTE49gffPGM6pTmkiSEyc+D017fObFldPOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 31-03-23 12:03:47, Yosry Ahmed wrote: > On Fri, Mar 31, 2023 at 4:02 AM Michal Hocko wrote: > > > > On Thu 30-03-23 01:53:38, Yosry Ahmed wrote: > > [...] > > > Maybe we can add a primitive like might_sleep() for this, just food for thought. > > > > I do not think it is the correct to abuse might_sleep if the function > > itself doesn't sleep. If it does might_sleep is already involved. > > Oh, sorry if I wasn't clear, I did not mean to reuse might_sleep() -- > I meant introducing a new similar debug primitive that shouts if irqs > are disabled. This is circling back to original concerns about arbitrary decision to care about IRQs. Is this really any different from spin locks or preempt disabled critical sections preventing any scheduling and potentially triggereing soft lockups? -- Michal Hocko SUSE Labs