From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3404C7619A for ; Sun, 2 Apr 2023 13:37:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56BC76B0074; Sun, 2 Apr 2023 09:37:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51C3D6B0075; Sun, 2 Apr 2023 09:37:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3975E6B0078; Sun, 2 Apr 2023 09:37:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 27CFD6B0074 for ; Sun, 2 Apr 2023 09:37:30 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EF36014088A for ; Sun, 2 Apr 2023 13:37:29 +0000 (UTC) X-FDA: 80636553018.20.408DED4 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf24.hostedemail.com (Postfix) with ESMTP id 09725180019 for ; Sun, 2 Apr 2023 13:37:27 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FMU7hZhl; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680442648; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yJE4pnnm0VUmz2w+YWBprkOi8rvRZMPtDmxykOoTYl0=; b=SLUcgcrsdnOcjkY7T6MpKdKzpR52ncOqLzYOMamjNd6vatCg4WIIX8lVOw7goKMcIoP87J im8eGVD+vx6xLcok4/HMGzs6XfcKZHBSZHLWJI9P1cdAo+GbxttVGM8LhFoe9E/3o1NyKt qX5mzhm335Gqik4ShRjWZis0QYqWYbg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FMU7hZhl; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680442648; a=rsa-sha256; cv=none; b=1gvuWfxEftOf+yVydypMMue/sZnkb16Op9MLJcrgF7WcK76lHZ9DYyrx6jwqFuHy3SgDSB Hxk9CN0ea8/pHQ9wGASPL60jKy5Y537Vi1eAkvgFavwh9rSZUlOlCdLyzNBDt3yVI1ntZO MrWtpB5FwxpXn9TzeA3QR+MJajgoN8k= Received: by mail-pj1-f46.google.com with SMTP id mp3-20020a17090b190300b0023fcc8ce113so29981731pjb.4 for ; Sun, 02 Apr 2023 06:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680442647; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yJE4pnnm0VUmz2w+YWBprkOi8rvRZMPtDmxykOoTYl0=; b=FMU7hZhlEGokCgTkSlI+CZmrkXTLHUq3462QmDzr5XRKGXHE+wRKAvyF0KjAjp7AzR x5S51/tBKEqm8uzwaDMYmZTbWA0niw5NY8M9V+HOcyCDcT9FugPaiJD1LDkDLHGHbizM 19IIhh95/d30jcBFqPsvYFljT0N+5Q5IKs/34h4iZxqps1srA0b09IgQwZ2mCV02IexC rwIvvHuN0mpWovDft1j8/QR3dkpDSaZu+bF1dJehUk2MRUFSa1KBcz0CvDDNmAOMPJea +bvAOf+M1j2hQCRqSX8m3aTUnVR/9yvheXX5gCGc0E5nX6xYC5K+FZXUddDJsCkW1nkl 8M4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680442647; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yJE4pnnm0VUmz2w+YWBprkOi8rvRZMPtDmxykOoTYl0=; b=ybr312GwscRBcbh+vYBtJDLswDHTV1xPK7aUK/wJyXuUMICf/lqWcAriaIcKfURlbh TVWJEVSxuIwQdCxfhf2NiunZ2opaDk4BiTtBSgUzS0SoAwceXHzoyN1d29Eudbfma5qE 3o44gW+nsQlazoxQvfBeoVWHKpla/3MqzCzx+FHFXcblm0m6Y4Zw7VFBDJREUzI9fu+S DvgI87RM+0WetA1agU3zjCbJts4epVPwW1dvzYPV8owQzyPf1Sm828ITv3YOnQGaM8CB 200PrgmMzrpj1rIVBuQWNeL/4Gdg5H6hDFSztYycaxXWfrRtOqq5BLYPI81TUvCaESio /qhw== X-Gm-Message-State: AAQBX9d76c54O5CXmhwnzzn8eTPWVsR4AJp54sFF2iG5SuynE4PzaIZX +8r5a+NQFc4MGKN9Jzv823PEcoTJ9Yw= X-Google-Smtp-Source: AKy350Yxz2CiSI0uFgBbOpXYxtZGf7jmzV6zy8iqCUmxCu8v3vRH8lvCoUEkqjO2J2gRF+NfjeTDAA== X-Received: by 2002:a17:903:28c5:b0:1a2:9183:a499 with SMTP id kv5-20020a17090328c500b001a29183a499mr9689820plb.34.1680442646834; Sun, 02 Apr 2023 06:37:26 -0700 (PDT) Received: from debian.me (subs28-116-206-12-38.three.co.id. [116.206.12.38]) by smtp.gmail.com with ESMTPSA id jf2-20020a170903268200b001a27e5ee634sm4798774plb.33.2023.04.02.06.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 06:37:26 -0700 (PDT) Received: by debian.me (Postfix, from userid 1000) id 893461066A7; Sun, 2 Apr 2023 20:37:23 +0700 (WIB) Date: Sun, 2 Apr 2023 20:37:23 +0700 From: Bagas Sanjaya To: Rongwei Wang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-stable@vger.kernel.org Subject: Re: [PATCH] mm/swap: fix swap_info_struct race between swapoff and get_swap_pages() Message-ID: References: <20230401221920.57986-1-rongwei.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kZSKbbifSvmxXjNz" Content-Disposition: inline In-Reply-To: <20230401221920.57986-1-rongwei.wang@linux.alibaba.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 09725180019 X-Stat-Signature: q3ps5n7kin5kwimnk61i43o1i9r93wm8 X-HE-Tag: 1680442647-304807 X-HE-Meta: U2FsdGVkX19/lR9kBSS0IqimOiat774mByLrnHYM8adYvlxwZKuloth4VxGUCIirOkXdUre4IY5R2qNeueYGrLhKS2/BatnOCkDQ4cYRVjQOK59O79sGqe9MBB5KQHimHgM1kMTucXeE4fXgQvd6QBgNia3MikPIbMmEue7cuAYYTw5pIxyFczXQPWTAtWZRx3W+wBGEBSnZgj2eWmy78c+rpjWGw3nLUup56pdNEiiDoYYz8jQ3CfGQKLx6WIszfTcSLXONBEAzcE3x2slaMUY0eVO3K2dUS6um/fzEsixA9Spf8guxdWwT2NMLBBFH5N5GlPX5Tx94kfbG9MfpHEixhhNxaZqhDeZsW/jwZ85CH0MVHd2qD0CLVInhru79T6tRW7K2ME4Fm0Ko9QAqESElDYaOUH9gA9fts5978xsrxa6U88fLNjIWQMJT48bTr2BMA6K3pl473GRI671lV94Y118f8Kzxx0chbXP5snMfGI0XLGQ5GsXp0akCcn/WBc6BmIkZfn+UZihynKatoCPQErb06j2TkspM7KqH5YGu2Qul3MgXsJ4Nczz67RPA6ZkiPYbtLzkViQuk1Yrosc8DU97gD9dlNRMTvN9PjkTYod+Vp1h5qKqnzGYNFNy9H44O/cE98sP09jkoBftkrc0yd/id9ic+2mHsMHIsP8C1Mw96rXPXwgDWlBlDN3FEAj+IdevSyc0zgu/VlIZFzO9pC+gYxSJrDg1yrVk740h9MNkclyo6lGEpXXVh/7UT2JgUE/A8qIfBGCS+2kXmSDS9ObmZCj6cckURrOprzs+48qC0rGk1k1pvXLNeNBtduCreR1YbwjdVcyWK0fxxD0givEFsbBbe8xlWVn9aKbNqPetutnbcjh+kul5vOJ4tI9hr8JCbhU3IhxIOZbVe4gxmaJ+FeVoiHSvsy6TumGSeV+mnWkZv+cJYRmzEtq+XFxbRdoA93RuYMSfb5iE qv6aX9gO lfSSMwLLRuun0dNVLa9g4nMcs2k5tvRWCtV+FEFqUj8BXSlivrpQZpQyy5zNDGD1yG8uRF/IMijgpUIs426y8hc0qClQyumN0J+n/4nhXRXcI9SjzIqGtX0uFsAsPnsoFkYYIjUFTwSyGe4gh6ucj4ZiSrbtl18sZoSiIONswCnyG82q7NeLU19OKSVm6L5O+NjbLOmKTBESPqp/1kDJzixHyKHa2WoUHeMCMT9W0ZTuUgHjEiQWbuZkfUiJOL8EAk/XGdNdt9O0fpmB6QQfq1F5fcTxf+C7Qixh/ZxclwFEXWWQaZLDT1YeZb0Ky+ar3Vxjt8u41UrCmRLrT3RvkdTNGe2kVnjsaM7CFMVGnAGM+sARmK6I4MlPSNvXq0dmWAq6l9QRqkKUI+uBbXAHxkV8O09ZYZ9buTf4cqT2iKzDfq6bzztA+yh3nrTZeZ4Cb0l+EbgxUSEmnOy6fww7MgkGG8Ad23d5hBuq/98g7TMSPt0LPZyCaqAw9oKWCsDmlrKhR4ypbG1Mmq+bm6/0nAhL9wf3IaWheHU/Nh9po0ovD5D7Znue0oC6tb3Tnt1JGlGxcNk5S6r9lB2UkH4Hj7uKDyCSuRoM2dg0EoWMJQVdSZTqTr5Yy40DUd1loxFhIbIJ0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.005597, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --kZSKbbifSvmxXjNz Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 02, 2023 at 06:19:20AM +0800, Rongwei Wang wrote: > Without this modification, a core will wait (mostly) "Currently, a core will ..." > But, a worse consequence, panic also can be caused by "However, in the worst case, ..." > In this patch, we lock p->lock before calling "Lock p->lock before calling ..." > We also find this problem exists in stable 5.10. So, you claim that 5.15.y and 6.1.y aren't affected, right? Also, Cc: stable@vger.kernel.org on the SoB area (as pointed by kernel test robot [1]. Thanks. [1]: https://lore.kernel.org/stable/ZCiuGEkyk%2F1Afisk@ec83ac1404bb/ =20 --=20 An old man doll... just what I always wanted! - Clara --kZSKbbifSvmxXjNz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZCmFEwAKCRD2uYlJVVFO o7N9AQD6KAL9B/rP0BIGjyYtOvCZvnVm5e3JKQg+Aoc/W8gKbAD8CecN3SdI0E2k n1uesdLFbR0vE9W8lDWjeZLr3z0cnwU= =P7MJ -----END PGP SIGNATURE----- --kZSKbbifSvmxXjNz--