From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E31D2C76196 for ; Fri, 31 Mar 2023 11:46:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E96E6B0075; Fri, 31 Mar 2023 07:46:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79CB46B007D; Fri, 31 Mar 2023 07:46:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 662D36B007E; Fri, 31 Mar 2023 07:46:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 54CA46B0075 for ; Fri, 31 Mar 2023 07:46:45 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2AA02C0273 for ; Fri, 31 Mar 2023 11:46:45 +0000 (UTC) X-FDA: 80629016370.01.25D6A19 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 2C1024000B for ; Fri, 31 Mar 2023 11:46:42 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SPcJehvz; spf=pass (imf27.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680263202; a=rsa-sha256; cv=none; b=OodZERUjfeINvc2dETlixiFnw35wq+oLgMi6dJisgoRQONrA7cOIAtPuv5bQaAPJ2wnpdn 8tEI7GigPcilRqJp0U3Qz9oX2z9Osmb00M1Uef8A66Fk4HLB8Ha94TY8xWOzhF5HllCtQv tNoiaD60d1X0iMYPTSfGXPtDjVC++3k= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SPcJehvz; spf=pass (imf27.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680263202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xiaD/4tMRyy1IsOsTj3zp03+vuUgB/x5nAQukHMowB8=; b=j1q9OPtXQMyPvBi7m5nb2huZaK3P1JeCZMI1uKqCD+gShvOaVlF2DgaNXSzCJ81kjtvLhw GiJNbDOwAlZ1wJoXF9n8xt/shKUMdLxr0jZ92FqmaFfGj4/Mo7kf+ZQSvxotyDiiFiFfQi YguGgSrAGuJfMG4W5i3hHQIocBMBPWc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680263201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xiaD/4tMRyy1IsOsTj3zp03+vuUgB/x5nAQukHMowB8=; b=SPcJehvzRWxAvpfyZgE693UYTmFYBq9wFrAdWO+O6Kq87cK4nYYhsZrr40HNOdNzJ6jToq y2FNM9OkZGs25MKIlNJ4BZRCqTo55gKBzsUFtnCf96P4BR/3u8tPSwSCo0PYzBK2fW3DjS yWlpYE6Dd8iWJYQyTk2l7hKw1LzGi7Y= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-300-Ecv1FegEOO-NwsaZLNUZVw-1; Fri, 31 Mar 2023 07:46:37 -0400 X-MC-Unique: Ecv1FegEOO-NwsaZLNUZVw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1AEA3811E7C; Fri, 31 Mar 2023 11:46:37 +0000 (UTC) Received: from localhost (ovpn-12-64.pek2.redhat.com [10.72.12.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E9E07492B00; Fri, 31 Mar 2023 11:46:35 +0000 (UTC) Date: Fri, 31 Mar 2023 19:46:32 +0800 From: Baoquan He To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , Dave Chinner , Oleksiy Avramchenko Subject: Re: [PATCH 1/1] mm: vmalloc: Rename addr_to_vb_xarray() function Message-ID: References: <20230331073727.6968-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230331073727.6968-1-urezki@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspam-User: X-Rspamd-Queue-Id: 2C1024000B X-Rspamd-Server: rspam01 X-Stat-Signature: mak5yu9onj1o3owyxt4syhm3678o71s8 X-HE-Tag: 1680263202-337295 X-HE-Meta: U2FsdGVkX19FkuJpS0SS0vM5yXKvUm7dCBv6x+p8SkVCq9TYpKwGL+vPjlM0nUl3V+LXR8Uf1JqrSXiFsv8kAN5nKP2mFxEvGlg3dqNREKkbTyQmaaWBH79C/EDeOV8oPGL3Le042CP96Yq0GR1Fe4EmVCUYo6qrL1yHajo7diMlqG+oOuOCqY2wrJuNRUYuUNf4T+lEShJ/EkxYrj4N7kT7QoWGEdq1OQXXrmaQLvAsOGw5y3ycBL0k2U5sqrlJxRWh9sOAGsLxnrGUT5qJ10Ymr8cFq9fl9lI6u3JF/fpZjV+jqgyEnBpQ0dJ0fZsxZ8P69ILFf3Rk6OEv76FtyDDRv3Sz2bG52YDbGOiKDhnR++ENYNkaYeSr920NWXofuMRGW1wIXF9K3ruWZucksxqoeI027G4SQaQbRWleANUrQVcqlRE44s0AHOqAiw2GoJLgTmS+3oOKTP3ZJd9JzlMuZLiZFAzu1BxikhiwFPjrbpxissTgQrinAVjuC1bu5BJHKUXlFDyntYsNQQ7BUXNP9C2et0qOubzU3pT9QpKPsAYc0pJxfMcYwz1SdWXAWM+3rfEHnXiIgWkbChG+gn9a+ZstrGlznbCC03wVD+e0QmsWyY/vJaqnBHim/XmB/z4aCbTTzmvjcye1mb2MMWtsCa+qVHFeAgzpbLrmA9B42aq3bbfrkk7Go/JO0KvevTbfe2oF7p6/NY95eGETit9DgfYQ6ugO4N0p2xzkshLYBjV2XOPvKyOE8nZUvkhUvH7kBy4o4HRcZGe0rXkcXOanCPNF5fhf2S+iTFJDs48fC9BXJ4rcDolvs0YCNO6KSaM81bbpBPxgzbKqEiWSSc8GpIHIQd5Yp7IhRv0JgoRL4dFAm27beim0HknaMViD1kTKXzVpxotf/33+xBkTU/aGV61jfUyu9bMDXHlzfp+xAfaKHPsRoQiiZSYq3110B9GuViMo5ZiYDy9Se6p TO+c4kTS OLi5oT38e0ugpBrsy7qrHqzub79L5GFTtG+vausOdvmZEmZXqBfzjC1rxpyAJxZMqj01Eaa6cnJK/robu4uldCUNF8HLg8NRd8OGO37lOOJuGBYxr+dq/TFhyP6XGOfJaxRjhDsYyKx5U1yPi71qbSrnzHwfP6WuvA+EcWyn4YBs923hA5yLxqDKDFTPkbNmnpyTEz/MeqUIV8CILjPWYaO/OTnI86L0izg0tRsPtfTQCxoXAUnHiz6lLn7uWOsIWGh0r6myqtwlhZcn0NePZXB3li4zXQDoyZhKpaQbAxOX36QBgurDO4Z0kgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/31/23 at 09:37am, Uladzislau Rezki (Sony) wrote: > Short the name of the addr_to_vb_xarray() function to the > addr_to_vb_xa(). This aligns with other internal function > abbreviations. > > Suggested-by: Baoquan He > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 671d6d5d5b78..b8b646f8a00d 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1945,7 +1945,7 @@ static DEFINE_PER_CPU(struct vmap_block_queue, vmap_block_queue); > * used as a hash table. When used as a hash a 'cpu' passed to > * per_cpu() is not actually a CPU but rather a hash index. > * > - * A hash function is addr_to_vb_xarray() which hashes any address > + * A hash function is addr_to_vb_xa() which hashes any address > * to a specific index(in a hash) it belongs to. This then uses a > * per_cpu() macro to access an array with generated index. > * > @@ -1971,7 +1971,7 @@ static DEFINE_PER_CPU(struct vmap_block_queue, vmap_block_queue); > * however xarray spinlocks protect against any contention that remains. > */ > static struct xarray * > -addr_to_vb_xarray(unsigned long addr) > +addr_to_vb_xa(unsigned long addr) > { > int index = (addr / VMAP_BLOCK_SIZE) % num_possible_cpus(); > > @@ -2048,7 +2048,7 @@ static void *new_vmap_block(unsigned int order, gfp_t gfp_mask) > bitmap_set(vb->used_map, 0, (1UL << order)); > INIT_LIST_HEAD(&vb->free_list); > > - xa = addr_to_vb_xarray(va->va_start); > + xa = addr_to_vb_xa(va->va_start); > vb_idx = addr_to_vb_idx(va->va_start); > err = xa_insert(xa, vb_idx, vb, gfp_mask); > if (err) { > @@ -2070,7 +2070,7 @@ static void free_vmap_block(struct vmap_block *vb) > struct vmap_block *tmp; > struct xarray *xa; > > - xa = addr_to_vb_xarray(vb->va->va_start); > + xa = addr_to_vb_xa(vb->va->va_start); > tmp = xa_erase(xa, addr_to_vb_idx(vb->va->va_start)); > BUG_ON(tmp != vb); > > @@ -2193,7 +2193,7 @@ static void vb_free(unsigned long addr, unsigned long size) > order = get_order(size); > offset = (addr & (VMAP_BLOCK_SIZE - 1)) >> PAGE_SHIFT; > > - xa = addr_to_vb_xarray(addr); > + xa = addr_to_vb_xa(addr); > vb = xa_load(xa, addr_to_vb_idx(addr)); > > spin_lock(&vb->lock); > @@ -3556,7 +3556,7 @@ static void vmap_ram_vread(char *buf, char *addr, int count, unsigned long flags > * Area is split into regions and tracked with vmap_block, read out > * each region and zero fill the hole between regions. > */ > - xa = addr_to_vb_xarray((unsigned long) addr); > + xa = addr_to_vb_xa((unsigned long) addr); > vb = xa_load(xa, addr_to_vb_idx((unsigned long)addr)); > if (!vb) > goto finished; Reviewed-by: Baoquan He