From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF22C761AF for ; Fri, 31 Mar 2023 10:04:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E045A6B0071; Fri, 31 Mar 2023 06:04:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB4636B0072; Fri, 31 Mar 2023 06:04:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7BDA6B0074; Fri, 31 Mar 2023 06:04:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B7AC56B0071 for ; Fri, 31 Mar 2023 06:04:22 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8B53B1201CD for ; Fri, 31 Mar 2023 10:04:22 +0000 (UTC) X-FDA: 80628758364.01.2184F24 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf05.hostedemail.com (Postfix) with ESMTP id 79C4F100019 for ; Fri, 31 Mar 2023 10:04:19 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZfIaVOUZ; spf=pass (imf05.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680257059; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PjavG9MKLZVv3dV4g4hTqEbK+DVu3JkYcu79G0KPCSs=; b=XlxPsJbtxmJj6pbkmVHhqZfXx6lDjLAUdw/YB+hnsCjqf9r4Mxig6dolXijRn3u8Ek2Qqh Mk5HAoETnyIfj6lwNMhORoRAMHtLaO+D0JtCceW4zRcQXUag+NxhysJ7EPQ+lNOi49MLhq oJS4YABsDZyVXfREEXzfMFnFGdcpQ6E= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZfIaVOUZ; spf=pass (imf05.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680257059; a=rsa-sha256; cv=none; b=YuJFqGiccr2cuaj/G3/uQNBGAT1dhOQeTcP7ljj9symJx5/NeV3whe/SkGXTOHDAs6kFtb ZTg/HA5gDBvJahQYBemH2b14FN4Q4qVdt9GEvYpP6APq9MrD/ihw/6R+4Y6mAWE7rxUiDj ZKC8L2mh+LOnOzj6J6sc7X0hQUrEs2Y= Received: by mail-lf1-f54.google.com with SMTP id h11so21221991lfu.8 for ; Fri, 31 Mar 2023 03:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680257057; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=PjavG9MKLZVv3dV4g4hTqEbK+DVu3JkYcu79G0KPCSs=; b=ZfIaVOUZZRPCaRbk9t8JCQ6cmxkuEmo7oDBLzBvZXLDpz3Ld0ELmqnD6N0ol3Qe3zZ XV5iFYdYq0MitzmHSFHkoOiu76DoaLAf2Kb6gd984ud62ulivOyg1UzFZfZx69PLnS5t BvUl7fsylgv5jmHbQWqUsOrXRD5NizPtd8ENLAG5goGayuHVPm452Y/zN8Nj531bXmP+ Ym9N9hESm7fQ4x7KEdjPS2JkVUWqkX/BVBL0Z5XJAvlDyMI21BRmn6oiABMVe2y1RVHg 3ZWHllXbpYNUMxX7IoPpBHWWpNoSK6aOZAzTb1zNczuqyE6b7P/HTaKOEUbeUvY9lCjk 6WcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680257057; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PjavG9MKLZVv3dV4g4hTqEbK+DVu3JkYcu79G0KPCSs=; b=u2EbeLfyhZ6iPpaBY05h/RDLugDmW8//czMYvfN4THxLf3pbYMAQyfuEe2zfBAVne2 qmsqfvmIj7gtLcKWl8dD0m1/VVMY3l6QwNYE2Da+J14ZSaMJ6dTcLTiq0z7PKnXZRb+/ U+UjARwStZDzS1C8uPv1B+G1xypqrYAfpUFYqb2/cfu7hGa886ewPV80mZsl/mjtPXrt il/U6Fw6mTNW+sGG4kdcF5ULVm9Qv7YILjpxxvdhh2um3TsFLvSGpN+HvQKUk0vigVdD dWVHK2Z2Qbh6tNOEAySU8D8cznCiznYeA7JfSQESDKeRqGqF4bT3756Zw8JCJ/d/n32M Y1lw== X-Gm-Message-State: AAQBX9fsdKKOf+85Wo1mdwUZP+ghU/VcVbN6GzWZ6pX8jto8ieLm841r JaO/24I9S5ZIBlaADTQeQsE= X-Google-Smtp-Source: AKy350bozdYquIMupN8R9z3xFxNGqy7WuNnFfeVcPBjRWL7RAsQagwXeLs1UZeNO17Y7Pu2pIb+3tQ== X-Received: by 2002:ac2:5bc9:0:b0:4d8:86c1:4782 with SMTP id u9-20020ac25bc9000000b004d886c14782mr2672689lfn.23.1680257057262; Fri, 31 Mar 2023 03:04:17 -0700 (PDT) Received: from pc636 (host-90-233-209-50.mobileonline.telia.com. [90.233.209.50]) by smtp.gmail.com with ESMTPSA id t8-20020a19ad08000000b004cb23904bd9sm315534lfc.144.2023.03.31.03.04.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 03:04:16 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 31 Mar 2023 12:04:14 +0200 To: Lorenzo Stoakes Cc: "Uladzislau Rezki (Sony)" , Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , Dave Chinner , Oleksiy Avramchenko Subject: Re: [PATCH 1/1] mm: vmalloc: Rename addr_to_vb_xarray() function Message-ID: References: <20230331073727.6968-1-urezki@gmail.com> <65a19f0a-be4d-42c9-a75d-1356996acdda@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65a19f0a-be4d-42c9-a75d-1356996acdda@lucifer.local> X-Stat-Signature: 4uy7y7tt5o86wxnosbxo4cmk9haaokxg X-Rspam-User: X-Rspamd-Queue-Id: 79C4F100019 X-Rspamd-Server: rspam06 X-HE-Tag: 1680257059-15172 X-HE-Meta: U2FsdGVkX19DfNbeK1BBqm8oHpm6chc9eafi+ARwFoBSRa3hn6iCoAa/tNy7ojsfm3OWEiIDhgxAWohq++uy0MYk0J4+ACnjmrSFOxm5H74pf+RbWz2s+Y5xjcibkkeV22myX5Gv6mq0mxanCHCNrQZxN+LsfxqxlgxL5D3RgvHezex90gR4w55xFHblcIt4MnkZjnkmrF2LBxNaDZa/EN3P/GkjgrprJeZQgOCL+LElyCuh2977NYIFqjXFkzdxW4Uu3wzvhgTWgYjhgoA3zwKXPBbrvu8q/uw2YdJ5J5Kr55vYfMbQSxFSkEB7tJBbwJQUyat1nsjGdGBipRu40idCFFDhvhMxW46xD74Do5or3IyqpYY3n4vhqGOKYM7WMQoHmeBiNvxEYgRru1SjZ+s8zNl50tfjJXMazYZW037NxPSk/fLYNQSbgxdflBxUko7aMWhRrshdKv103DSMg5ydDv03Ipl+fXQggIKDM8M3ZauLQISg4sxxZcYM2XyPag/NgDoNUfDMbivonhO0c9ibKEMmwogvI9Ks5uagbWklF5DIwzeNReLPososuzKE0wNNsjSVsyHDPHk76Y+dwmHZLyOctK+PHhw/eUzItwJI8qlN37n2EJ8E7BEHiPyBFUIUxKmQ7oDZQv9497zSJTiALy4MvL8qvBHaOa+xCKcl7Ot2TqURTnYVWm+wAR8rOFiX2FDKSCuqqKD40BbyKnTwtMG+e6oVVowcEBjJ0D54yw/zQeuIEgQ1TGnQZGgZlYIGD9vDclV6DWs8JFcUDf0VDjQ/jwmyiTATTYA9B+m+bv7S8etq6TytxuhDfVD91r50QMYkeSAAKlHKSfEBBpRvTDx95Px4QoTstOS6Qi0Nag3XgtYZX9v99yvrlzvCjuBE/ESNRWpU89aeheaKbk77J6OtS4qHt3exeOtGILeu8OZCeCDyZ5/NIyjpI7sx+YwMLXn67C7cGhv5hWw 51pqfvXE ZTbsaRQ9mpJOkqHx7iXYv6KBFJJ5TJu86Fd6YGcN7NLb2BNzFQhLpIA+Gv1oa9L+SRh+kBuOdFkSE+Dvcvq0ppGgVTbSGDKz1DoHzMKyuBWGQDLnqhSch2pJpIqZLDty3pFHrpBEyauDTlw4Y2Lut6BRQQ9ruci8VtKT5fcPDd1EW+jJR1+ZBrpZsVXOSf1UXJwCqfBeGMoPapfcFy0YqgrHkuYsRRch3vfmFX08xGSsaUtHR4CjWf73IwhmtrcilKwrObfE8bBG5515VyM79Bc38B2yKCE2sQSqfpSDWECGkFMjCgDe5N7yQ8cVYt2satLdb2RpmAsYpPyhEM0LzGWrvPSe0Xk6eRN4WBppta5okPKNS9s1fTuGF0tFQxBDNiq55Wrgaj9xV2uPbd8v0XwBeJ8mzaOh3UlYG8uQD4f8LvmSTotS8WnnHKGBg/sBoRON77CHwQfVNZELxfHQ7+O6/obDtQ5MSJElqf1gXe5F1HwfSctMYWm13QJMVqiacZSnFQDAHa5dvsiB+h5zv/z4CKEb9tWUcHkv7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 31, 2023 at 09:38:49AM +0100, Lorenzo Stoakes wrote: > On Fri, Mar 31, 2023 at 09:37:27AM +0200, Uladzislau Rezki (Sony) wrote: > > Short the name of the addr_to_vb_xarray() function to the > > addr_to_vb_xa(). This aligns with other internal function > > abbreviations. > > > > Suggested-by: Baoquan He > > Signed-off-by: Uladzislau Rezki (Sony) > > --- > > mm/vmalloc.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 671d6d5d5b78..b8b646f8a00d 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -1945,7 +1945,7 @@ static DEFINE_PER_CPU(struct vmap_block_queue, vmap_block_queue); > > * used as a hash table. When used as a hash a 'cpu' passed to > > * per_cpu() is not actually a CPU but rather a hash index. > > * > > - * A hash function is addr_to_vb_xarray() which hashes any address > > + * A hash function is addr_to_vb_xa() which hashes any address > > * to a specific index(in a hash) it belongs to. This then uses a > > * per_cpu() macro to access an array with generated index. > > * > > @@ -1971,7 +1971,7 @@ static DEFINE_PER_CPU(struct vmap_block_queue, vmap_block_queue); > > * however xarray spinlocks protect against any contention that remains. > > */ > > static struct xarray * > > -addr_to_vb_xarray(unsigned long addr) > > +addr_to_vb_xa(unsigned long addr) > > { > > int index = (addr / VMAP_BLOCK_SIZE) % num_possible_cpus(); > > > > @@ -2048,7 +2048,7 @@ static void *new_vmap_block(unsigned int order, gfp_t gfp_mask) > > bitmap_set(vb->used_map, 0, (1UL << order)); > > INIT_LIST_HEAD(&vb->free_list); > > > > - xa = addr_to_vb_xarray(va->va_start); > > + xa = addr_to_vb_xa(va->va_start); > > vb_idx = addr_to_vb_idx(va->va_start); > > err = xa_insert(xa, vb_idx, vb, gfp_mask); > > if (err) { > > @@ -2070,7 +2070,7 @@ static void free_vmap_block(struct vmap_block *vb) > > struct vmap_block *tmp; > > struct xarray *xa; > > > > - xa = addr_to_vb_xarray(vb->va->va_start); > > + xa = addr_to_vb_xa(vb->va->va_start); > > tmp = xa_erase(xa, addr_to_vb_idx(vb->va->va_start)); > > BUG_ON(tmp != vb); > > > > @@ -2193,7 +2193,7 @@ static void vb_free(unsigned long addr, unsigned long size) > > order = get_order(size); > > offset = (addr & (VMAP_BLOCK_SIZE - 1)) >> PAGE_SHIFT; > > > > - xa = addr_to_vb_xarray(addr); > > + xa = addr_to_vb_xa(addr); > > vb = xa_load(xa, addr_to_vb_idx(addr)); > > > > spin_lock(&vb->lock); > > @@ -3556,7 +3556,7 @@ static void vmap_ram_vread(char *buf, char *addr, int count, unsigned long flags > > * Area is split into regions and tracked with vmap_block, read out > > * each region and zero fill the hole between regions. > > */ > > - xa = addr_to_vb_xarray((unsigned long) addr); > > + xa = addr_to_vb_xa((unsigned long) addr); > > vb = xa_load(xa, addr_to_vb_idx((unsigned long)addr)); > > if (!vb) > > goto finished; > > -- > > 2.30.2 > > > > I have no problem with this patch but it's a bit of a pain to apply, as > doesn't apply to mm-unstable or -next as it doesn't take into account my > vread_iter changes, however Andrew can probably figure it out :) > > I checked it manually and it's fine, so:- > > Reviewed-by: Lorenzo Stoakes > Thanks! I based it on next-20230317. If Andrew has some issues with it i will resend it on a latest tip! -- Uladzislau Rezki