From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65FBBC761AF for ; Thu, 30 Mar 2023 23:16:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B816C6B0071; Thu, 30 Mar 2023 19:16:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B31156B0072; Thu, 30 Mar 2023 19:16:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A20BD6B0074; Thu, 30 Mar 2023 19:16:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8FB316B0071 for ; Thu, 30 Mar 2023 19:16:40 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 443111402E2 for ; Thu, 30 Mar 2023 23:16:40 +0000 (UTC) X-FDA: 80627126160.30.A89C7D1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP id 01CF71C0005 for ; Thu, 30 Mar 2023 23:16:37 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ouTsP78z; spf=none (imf18.hostedemail.com: domain of BATV+8e70578520f0e3248efe+7158+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8e70578520f0e3248efe+7158+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680218198; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sNZf8S8tAdiAtHNv7P7z5NGeuKmDoJoQUzbTOv5U604=; b=VTw1geODrxR5hKBc0q1ct3UqO6xActwOk4NBaWE+oAh/Ec7lSm7s0ARfFWn6qDLwFnzI1+ 3rsuK7rlNsNJmO+iJn4rqCAwcykTc36gLnx377kcaq1duHD1QsywtZQ/lkEsm2CDnFEOru K3bGSZoZeHj3A/5M76u2uiLP68jM29U= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ouTsP78z; spf=none (imf18.hostedemail.com: domain of BATV+8e70578520f0e3248efe+7158+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8e70578520f0e3248efe+7158+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680218198; a=rsa-sha256; cv=none; b=aEha+BnTlTObGvLQmWIgVjN3baUfhx2WPeSlRT+I6cVBrodK+YhdRtZ+kdi3ezqFhD0nws 2IkgZO2LPRAlJ5WdQ/8Gm+Ig2QkreZ2es4gsiRl1J0oWXl11/Z5NAsMtsRdqY0epbTAOdU jXpWUjWL5XF6FClplJRuk3t4ZVEyBTE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sNZf8S8tAdiAtHNv7P7z5NGeuKmDoJoQUzbTOv5U604=; b=ouTsP78z3P4it/9JFsVjOojCp+ lY8lKc1N8WpVb+t2H9yNwbWU+MXePFeVQTPkxiC3IOCjsDCbKMcl17ee4yL5JxcYQJfEZdDaYyvpm UeGRYbGn8fZpfnBJmD6LKSYp38a4IGZol7JwFine1zCft3dAA7+0ZYSEdntctnwVmj0VzhE99RhnZ Wo13MsUV8iz4o9/k/FAEKPMB2ycoHyT0R/YxB02dRlSXu+EChuLBdRoiQNgTzcXHRDRqMj8c0WK0F vOgwXs/LnMM4U7G7YqyEdigyfCu35poBGP6FagjrTnY86rnIe4H9WLIGGV8jaI3ZarlX3A/RJaSud R0LXqUqA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pi1VJ-005J6y-26; Thu, 30 Mar 2023 23:16:25 +0000 Date: Thu, 30 Mar 2023 16:16:25 -0700 From: Christoph Hellwig To: Minchan Kim Cc: Pankaj Raghav , martin@omnibond.com, axboe@kernel.dk, akpm@linux-foundation.org, hubcap@omnibond.com, willy@infradead.org, viro@zeniv.linux.org.uk, senozhatsky@chromium.org, brauner@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, linux-block@vger.kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, devel@lists.orangefs.org Subject: Re: [PATCH 1/5] zram: remove the call to page_endio in the bio end_io handler Message-ID: References: <20230328112716.50120-1-p.raghav@samsung.com> <20230328112716.50120-2-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 01CF71C0005 X-Stat-Signature: 3d4mbepwd3kqsfu3zzxiuehtezkh6p3a X-HE-Tag: 1680218197-221662 X-HE-Meta: U2FsdGVkX19QHuhf7tz8q2kkMXEcLPpgUBJBzVPfZL+Xp3V2XUiLBkac+uITVnvHDOn4qsUzDRI3XdZidaZHj3b6f7F3Ww7aPlrZ8d+BPv5x1v1phFBYY9OmI+4EzWNibIoRQuGc3ufT4DopgX2Tspb32N7UliY8IhuDqMs6bWjEi83HiIHjvWL0Dpeq6+xqC4kyWdptHMC45rroTU0xYchj0YT4uWz/PEZj4TdgMoR/lJJK93c7V2pWUNvI/uKwF6XsvOvp2+9WbfsrpOie2gRqOk7r06BUSniY8kGtAIwTbZd6aLfEi1k8lJbdM1pwtWuMn8dHdtOV3iNaHez8UowgUSidBuXtSjlfFcpjm1tWCztC7fDOytL0HK60UXxiCE61K2BAuroeCXkeTMQoVtTFwwIqVdx6amURqLPGpF07dZTQ2R/MuK9VC/Ew4rkRIRl+1j8OBEt3bstgSVzW3ZaCivVR909H2Hlf9cfq/hObCAKfKjSal1N9+BNqOjwQk/+O8V9E8JfvzVKMGTLwH0eMCjXXM4xjb+N4gM88VlY9BcZrFrRPkqfC+FweghZS55VgfMGJxmYnnBlJj8RsbUEGL4mEt75Wb3zc6wGaABo15Vb2H+1iDYvg5N3j1+PFTazqUsMQI2v2KRtSxZ/cbdHTZkyJwx/RxIqR1yR4R1Bbcoo3XYtxc8JkTIvv7vRjlHwSpby+aZY4iBXti4KDHm7q6tkA2PUnP2yillSIj1IvNL6HnOP8o2FFfiQ9vW2g7T3LNQvrta8dSHmaDzmIwSD7Si3HAxdpsJ0o6j4yhXNKinU5UQCVy0GHOc2lad+c4akdBIJj2Q/21r6yykop1ZWm8xZOXhRXle2m4LEqcKk1b/TTY7GzTpzO7LyIv6onHBpyGd67YbFxbJrn6iiM7dpU0Rwsgw35Hym4yXKux28D4i1NDFJJ6DJj6v45LLICLAmVemWeFm04tHnbWXj uYj+o8LO H+bUzuJa65t7nS2sY6mFhh4ESTs4LX1KyLR0RMBlE0JHiaxmIrEIiRgAP4c4XRAsiUZWgGuhK6PEDbuyTgPgI6t+j9n0t/K4Ajim4ti8a2i0ncvxktCMUauLVQnZpoX5JzoAOCbXo+qVcfVSqnwn6LNmwCq8eQ9jc+Q6xTAdepK6akHDajh6ShnLvqagdbV77LjGXU9Qifq5/idoWts17QiCVh5S/BwFaFEZCv5idDwg0A7SvzrCaZS04RAjiHPAo9oVtMQPPE4ZLUAOTQcW9MuwRGCAvfHK/mvth6jVChEaQlM3fp0UBZL1i75YcR5l4CRU1sNXNFOOdFn0B2yxT7gRt9ZFwkI/1TLCn/9SYr0rws01krWEoEo7ks54/CufyXFGie3JjUOxLonZBPFDc4s3N1A2fXkLGBWT9417TlSXAKhOI6OBvETZad1877ZRTWEPXcEAFt2UG6fo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 03:51:54PM -0700, Minchan Kim wrote: > > to remove the call to page_endio() function that unlocks or marks > > writeback end on the page. > > > > Rename the endio handler from zram_page_end_io to zram_read_end_io as > > the call to page_endio() is removed and to associate the callback to the > > operation it is used in. > > Since zram removed the rw_page and IO comes with bio from now on, > IIUC, we are fine since every IO will go with chained-IO. Right? writeback_store callszram_bvec_read with a NULL bio, that is it just fires off an async read without any synchronization.