From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E498CC6FD1D for ; Thu, 30 Mar 2023 22:28:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7874C6B0074; Thu, 30 Mar 2023 18:28:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 737836B0075; Thu, 30 Mar 2023 18:28:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FFD06B0078; Thu, 30 Mar 2023 18:28:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 502166B0074 for ; Thu, 30 Mar 2023 18:28:15 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F2D59A0AB9 for ; Thu, 30 Mar 2023 22:28:13 +0000 (UTC) X-FDA: 80627004066.20.90665E4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id DBEB240004 for ; Thu, 30 Mar 2023 22:28:11 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KPvIU9sg; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680215292; a=rsa-sha256; cv=none; b=rdAjluwDj0ek3MAj0GZbiGWKGs06yST/4YVc/zxd3Mbfxb5ohtNKSCY/jdPTPA7ySG2AFl UTwgOOpHg4npNkgp4Aob6VO8SGaJlXeU6GdHnim23kHnZiVG7+KbboMQtDUKZTeIfo4Gog l4kEVhKmQxjvh1xFhGfi4G0Y+JovnjQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KPvIU9sg; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680215291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ULC/HBV/7CZFRuQfLV54dZLIGK3tnK9UHOG46WhNr2I=; b=KeqUJL39rF8qjxGMLSYCvId9QBh/cULpQujCijJ1GY475WaT8E6hKR+aqVb/x0AnyQLdmz KynGnDPv+oAZFrOL8Kkfvcj3w1QGcC2dycwOWGXVRRO4+n+vP1KgT5GUbezvI2bIfMy/7H K+30sMohbZ4EjmnKG2ymMemGgMmu16M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680215291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ULC/HBV/7CZFRuQfLV54dZLIGK3tnK9UHOG46WhNr2I=; b=KPvIU9sgqGahtvwgGlV3CNDN63OPOyQgw+p/LN5yZ98B7I5QcTihMmkYaR1iyzIuX9ibz0 TG7bAIysj8kuI3BWc16d7cj1Q9sjymczZ3zzZggEMMcb+UiHVvHxtYDZSgyXXwCoUwn+7r Xvwwh/EiZcCOzku9d5gHQTmjEbbFsjw= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47-AaF_GEdCMvGnMKAji7m-Lg-1; Thu, 30 Mar 2023 18:28:09 -0400 X-MC-Unique: AaF_GEdCMvGnMKAji7m-Lg-1 Received: by mail-qv1-f70.google.com with SMTP id v8-20020a0ccd88000000b005c1927d1609so8909105qvm.12 for ; Thu, 30 Mar 2023 15:28:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680215289; x=1682807289; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ULC/HBV/7CZFRuQfLV54dZLIGK3tnK9UHOG46WhNr2I=; b=thiwPfgFi/dgmPJ9s5Xqpfw7+JbErTJABohPY8ffzhUNrblQhDhcpsD53LkzoQ/rhq mlLfJCc98SoCG49wNByNlFGmqvm0OJjyUcd3pKPAZ+4VKtTDdB2SW9c3dRIJOs6CQR4/ ayQIxsUb1R25SMYRlgXJXPiYh2vqfUrnMzBJxB8A48mTTrgrBZtIGhX8366NsRlU8g8v dyo3fyJaZe4UJR6ST5TbXyDX9tq3xW5nyJAwOJyMBXKaUednX+EMJSGR2qxEpJQX++iz OqQuDPYFlFIRt/uYyeoThaycwOGDTa9t8+A7cjWAcEDe/dg2DEmspVRFFOnoy9D2+B/J 7mgg== X-Gm-Message-State: AAQBX9dZQrhomrUeKteFZhPMZINvZVlqxGvVT8uCwMhm78chmfwl5Xgf V9cF4/WAWKSk6wo+kNE9iAJFTj/4vRGAp9fGAzR3JrcRn1U623mMXIoajwhdUkXABqSbvQCHzge JTcGdwkNysf4= X-Received: by 2002:ac8:7d56:0:b0:3e2:ccf9:bf96 with SMTP id h22-20020ac87d56000000b003e2ccf9bf96mr6542355qtb.1.1680215289387; Thu, 30 Mar 2023 15:28:09 -0700 (PDT) X-Google-Smtp-Source: AKy350YKjAMLZAUVJh4CtZ5TZF8rqQt4SfPZZvlrc2tPeFEO2G6SSONhU0BamzMoZ1+Ak6vhWHrDpA== X-Received: by 2002:ac8:7d56:0:b0:3e2:ccf9:bf96 with SMTP id h22-20020ac87d56000000b003e2ccf9bf96mr6542339qtb.1.1680215289166; Thu, 30 Mar 2023 15:28:09 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id q12-20020ac8450c000000b003dd8ad765dcsm169428qtn.76.2023.03.30.15.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Mar 2023 15:28:08 -0700 (PDT) Date: Thu, 30 Mar 2023 18:28:07 -0400 From: Peter Xu To: Axel Rasmussen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Andrew Morton , Andrea Arcangeli , Mike Kravetz , Leonardo Bras Soares Passos , Mike Rapoport , Nadav Amit Subject: Re: [PATCH 03/29] selftests/mm: Dump a summary in run_vmtests.sh Message-ID: References: <20230330155707.3106228-1-peterx@redhat.com> <20230330160646.3106903-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: DBEB240004 X-Rspamd-Server: rspam01 X-Stat-Signature: nzkwwjyfkaifu1hu4yywxfx9w6zqshsc X-HE-Tag: 1680215291-470723 X-HE-Meta: U2FsdGVkX1/yIt87sRfz1uOW7M+Fp04dofOZ9e4+MkN0ems58pRF0GfAm/2DBbJiaotMv/oagf1MUG0yXkeTF55qcBeuUwSnLZUXx79of+OB2i204IFJdLrhT6nhgwR8b1URXFqsN+TmqjRNeLyFaWY4vAnbZLW/LZd4bIdzLgeEhjssfaXGCymBTajhwXlMrhxnEysfTCwqT5moG60GaCW+ogrzDmDfOmtnSmfQQS+7aS6JvHcV8gjJv6tUishXQ4AzUn4KUrH2YLn0r4DR6uI7Pv4KyNBr0Z5StwPEzmd2kSDxrtpBam9qwvWVbylD+XHTUHGa3WaIHN7tfqV10RdNEfY2tpQuqovyM8RBJ2DWa3JPuaSqKIN1OcBc75HfTdDe4aEXDWK57wPp/BUmP11iGNK9/j7FcIIyEIQToWMMwYTxJPpzful/hgOVaInqsUJk9OWQUMyvBvUTZKP75LGqaHor3DWtZVa3N3MB4bb2zZ/rMfVKmUOBLCxIKXfn251Udg8+NdrHEXUDGeghsPsKB7yXCJ1qx/PfSfqNBfbeGbYDjieLVtHcSmD9YBXlpfewQTaxnYUDJXb9TnGEI2hy11mF6aHvXTp8+ZIyKNZOl8zb09EB6uKsZtppxjVLoX3zlrTpXrTi8qCGX30DUlyU/DOiO3oTRgHHCl7wpbwJKL+Kxa6iweCx9tLOh5EatdqRKVQlo+BFbdn+HTKT2vPfgv4AE56NWijqAZN9CX7wHg5GjDt3chf93s7UC0JFEwRFBSCZ6UDk6jo8k1ByEoEqHi7DqfOYxzU3AIMkxVrZ7Wz/J/SBrikKYGxzxpr8wD7llfi8ilx1Z0ue64cpbUNXVaWBjV/MOTCgwRuPYwUnrEnRdXH8AoMBLqvWcjscf46JUDBepgGRWIdfW+TTxegUuj1QwtXUAdrESXEbOLR/QSOQvzSJ0mjnbzD74dYgU+WHNJmetg0YxDYxb2M RPcEBL1b tOmsGuNzsH3cv/pGwDzxPdhM4DDzsFSTM1t+ygG1uoe/T0QW82lcHP4v8/GKhSCns9nlXJHDl5RmsYdpTIsp772iUF9TnEFskjTABhUHSiqjV5wRHlxKMrEPFVm5RBp2ySJydjJWJtG2h4ZQQRVQ0YoXPAZIPLL5FhUn52gH42aporGVRu+SDwT/yTfJZb546t54q+LANhzSJx7bTVi5UXGKjBH5/6hw0rqimkjjTAg5qKCvHo7b27W6dYBHCJrfRk+UIrRvwT6PlplqNLf8WNBQBSRPXogDVIwmyigfcZngFELt6nr54bZiA2EMHWRP4qqklz/bvWHVg7uLTKh6+Fet0COhUHoqfH5Of+V7NS63lmXD+ttAf0siSc00p0d/4Ef4XL6SRtHvLbNbzxQmGbPqauHhI8Tlx3yD8KYFo5rrJRBlS8be/i9onmjmtxs5vuKMdbnkpMLJE00+Fu7Plr/uaFAiykZcU+90gxTbZQce/XWrTBHB9n0j3+bpot6RfZbq+jgqbWM+z/r9Sj2CSFEir2jj5Fgw7ZzIG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 12:07:24PM -0700, Axel Rasmussen wrote: > On Thu, Mar 30, 2023 at 9:06 AM Peter Xu wrote: > > > > Dump a summary after running whatever test specified. Useful for human > > runners to identify any kind of failures (besides exit code). > > > > Signed-off-by: Peter Xu > > --- > > tools/testing/selftests/mm/run_vmtests.sh | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > > index c0f93b668c0c..9cc33984aa9f 100644 > > --- a/tools/testing/selftests/mm/run_vmtests.sh > > +++ b/tools/testing/selftests/mm/run_vmtests.sh > > @@ -5,6 +5,9 @@ > > # Kselftest framework requirement - SKIP code is 4. > > ksft_skip=4 > > > > +count_pass=0 > > +count_fail=0 > > +count_skip=0 > > exitcode=0 > > > > usage() { > > @@ -149,11 +152,14 @@ run_test() { > > "$@" > > local ret=$? > > if [ $ret -eq 0 ]; then > > + count_pass=$(( $count_pass + 1 )) > > Actually, inside $(( )) there's no need to prefix variable names with > $ too. Running "shellcheck" over the script written this way will > generate a warning. > > Same applies below. Sure, I'll fix. > > > echo "[PASS]" > > elif [ $ret -eq $ksft_skip ]; then > > + count_skip=$(( $count_skip + 1 )) > > echo "[SKIP]" > > exitcode=$ksft_skip > > else > > + count_fail=$(( $count_fail + 1 )) > > echo "[FAIL]" > > exitcode=1 > > fi > > @@ -279,4 +285,6 @@ CATEGORY="soft_dirty" run_test ./soft-dirty > > # COW tests > > CATEGORY="cow" run_test ./cow > > > > +echo "SUMMARY: PASS=${count_pass} SKIP=${count_skip} FAIL=${count_fail}" > > + > > exit $exitcode > > -- > > 2.39.1 > > > > Besides the nitpick: > > Reviewed-by: Axel Rasmussen Thanks! -- Peter Xu