From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1D3CC7619A for ; Fri, 31 Mar 2023 01:42:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A2736B0071; Thu, 30 Mar 2023 21:42:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 253026B0072; Thu, 30 Mar 2023 21:42:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11C846B0074; Thu, 30 Mar 2023 21:42:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F2AAD6B0071 for ; Thu, 30 Mar 2023 21:42:44 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BAE4BA06EB for ; Fri, 31 Mar 2023 01:42:44 +0000 (UTC) X-FDA: 80627494248.13.C1C4F13 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf28.hostedemail.com (Postfix) with ESMTP id E555EC000A for ; Fri, 31 Mar 2023 01:42:42 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TrpXzdzR; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf28.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680226963; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tfm+hbs/jl6LALmLyvo0+JGmZiFpCrqmfVmO3EjPG/U=; b=zzBTtT3uF/jMRolxRMaCH1QZBHCK8djBm0jia1soOyQsVNBvUyMPCRlGN2kytr6nq2KkTS PYj3zOHjA4UWUuyRO2tYeumTnotJXHb3ub15DeuCJBrsD8msKhG8rgM4G8Bl3ta5bmO3Km 3f6rzZLGOY+1X65t28DXmHFiZlLMteQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TrpXzdzR; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf28.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680226963; a=rsa-sha256; cv=none; b=hqNmirnsLFeNq3GRMmzE+DBqfOBD5Wm71eLToPDL4gJYPvx5tCRhjv3yt+zKAzn43ylojw xW+kA5GPUQ4Up+ZhwzEMFAuKq0/LLEQj5xVOqemN9Cw5N/nhfVib4o4SHWyTtgA6g8QdNU DSCN1fmxOYmsnMeMwYJhMsgvWZ1JTWQ= Received: by mail-pl1-f177.google.com with SMTP id o2so19867461plg.4 for ; Thu, 30 Mar 2023 18:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680226962; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=Tfm+hbs/jl6LALmLyvo0+JGmZiFpCrqmfVmO3EjPG/U=; b=TrpXzdzRu5jUI7LHqyu7stpCOlAN1ukTs0SqCkuDb7kbwhuIxqEh99BpwSYfmOtpcO SS5Tz4Aycr0UvccPQmjXBZlZRxxQps7hY11C90XxQPmDUaEAxcTa//PbYqRi6BH24jmz ap4WFQ+oxxdcNAkU8BuS8lj1iiIBB+dXRUxWYdYi1vawR89cMTYj7dQuROR9lfMskADY srkspqNZBuFQM6TZt4QIVTAGAfzhRmejGbwZfLF2PpkvxQxwDM0++PButpMJW5GorX6D gq6gPUhURDbB7jlw0jFwvblAxzjAdEFxNRe5L8ox/WEJruXEcOWqM/l6N4mfjbhQ7TVq 4g/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680226962; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tfm+hbs/jl6LALmLyvo0+JGmZiFpCrqmfVmO3EjPG/U=; b=gDtzmiWtt9K044od8/Q+cmc4nGW4S330RdrCn3Cq4JRJbBkc70E4ptML/TtVp3OEzj lHGYIxtaxMj/HlTTn4oHjTkHed2CWDaM1oUEZKyjZvOmzEMOqqmR8lDt86VeWM0Xc4Nx se1pe2FOiBN8PgPr2STn4Gn6USujm9ZdbNJiN7G4RBvIsoZVkOX6lnsfFAxu6sIXA2ER AU3vEeY+Uh0iPkHpUJ4bWx716IuRRA7Kj/r+19DsTCJItLSO/0lsH1BI/g7TrlG+PvxW B5Q7OiiP8FjtD3wudeaqAXIg3mFHN2/wpaq1c+ytnSNgnQIb018Suj+pij2rlAicX4hl pMFQ== X-Gm-Message-State: AAQBX9cPT6YtkIhYgIVTAbZBQT9S9Bu6RvQkntcHMYNoCJJ9GiTr2k8x Xy5azniaO0oWY3JicT3MtGE= X-Google-Smtp-Source: AKy350buo2Zzy4xjvCuquW12XdoWy6na2heI1Y3+soPRp1dbwTzaLnv9aqUFtI85XkcfPJ1kEr73fA== X-Received: by 2002:a17:902:d48f:b0:1a1:af64:380c with SMTP id c15-20020a170902d48f00b001a1af64380cmr29599940plg.27.1680226961690; Thu, 30 Mar 2023 18:42:41 -0700 (PDT) Received: from google.com ([2620:15c:211:201:93aa:8e39:c08b:8c2c]) by smtp.gmail.com with ESMTPSA id bf5-20020a170902b90500b001a2574813b8sm307862plb.278.2023.03.30.18.42.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Mar 2023 18:42:40 -0700 (PDT) Date: Thu, 30 Mar 2023 18:42:38 -0700 From: Minchan Kim To: Christoph Hellwig Cc: Pankaj Raghav , martin@omnibond.com, axboe@kernel.dk, akpm@linux-foundation.org, hubcap@omnibond.com, willy@infradead.org, viro@zeniv.linux.org.uk, senozhatsky@chromium.org, brauner@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, linux-block@vger.kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, devel@lists.orangefs.org Subject: Re: [PATCH 1/5] zram: remove the call to page_endio in the bio end_io handler Message-ID: References: <20230328112716.50120-1-p.raghav@samsung.com> <20230328112716.50120-2-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E555EC000A X-Stat-Signature: o9wc38g5bayw64gk53chbjoaon3yurid X-HE-Tag: 1680226962-347017 X-HE-Meta: U2FsdGVkX19i8PmVtzMLP0H+3s2NzLsR4x7ufh9Kc5vIhIna8j0UjOmVfsGuPit1yFXdTAGnaaSwHamt0WIXxWRDo+Qzlc7yjcNYc43fyq200nnzS8xObRfbE2RX4etTRAZQQk3hI3Dx838bCiErDs9qq4m4QbKhqWNzSkXtpW56Rx1JZxTiHyDHPSYBwdrdMMyyjy4PMvkvVX+dVCoNs6TZqI7za5r9tp/P7RKYakAOWMi1w3xn8Hcgl50fFgo0Rc/iM8X9JwUHCu5KG/pk8jOxaWouOgdLQrIKWYb0iTEqbGjgvwy20NkZlWhZz7h4LLgr6q5M4+JZGTQ3dEYLbcWubWzEyfVC4S81zu+3PoOTQLVdaZQVdt5DTuncYaruzHBfE80/h4h5pkBbyqdgF5kb/OgEY6A7dIp+axVRCUpsSOQjr59TsCaLPwXIu+hOf05/pK+xKAkyJ+cMs9pcDC3KRP0kGrSipCz0j4xVQt4/1mNI2mXnCisFS93sZl/pesPmE64yMZi49nr4ozQBnSHcAjVDobxkAe4fYXwmDkoabWueRX8x6ds4+mglzz4cnYqnTYu+jZJzPloNQnoSNhijoptg4YT9oR7vYkZ2HI38ZO6eFtQ/3mWA+5kRF8gfSv2+zZ8COc4hrPlXIZgsRsn7dB1KkEbrjxWp79HYC2fgrSmAl1M1dZ4dJK2cWxdPv53HWBzljXCOyOAgzzQIxaw5rUwLt0E5Gk4MRE/XXFmA9TXzguPMV5pZ2xZfqBh7E5Tjlcx1Ay8obvPyjpgHVoOoD6/E7OxbAxBlFHiwX4HKnalaMxP/K4kQkl/jBi+J087CO1LVlOmr3HVgcQKKSQmsbOHRvQtiSbmXLGx/6eoMINE0esTPGLHOjwdxGoCf8jRjMZzJrmZ5laC0ULijgVnV+IeyLwWOlB2sdURedCp6ZNkh/NgfZvgsiKTPlrDkfFfADTadouqi3MIBghQ iSxdESTc aGAyQJzVkyYTMIZPyHyUIJZd6565FWBlr/drgQN4NDe9hcsOWNKgrPdhssJQA9HsVrokaJSKiH5iR32IrzSHmciwBXy4x8iR3ysZL5d9GwdRy8/G82LfaJbfjMsHu06c3T1P20X+ja1je11XbrJW9xZ+tQ+GXmblmILuOnq2WrMv0x89M9buvJElMo6QW3VWse7hlkDEma0sYkVuCY/Pyt5F9/HqP2xxAjxqMuZ0CfYTw14A9OkRbnNbluYWpKTpJJUb1XgI1roYl0nJHYGED3ZevtFiN1kRMz9xjFlNkdMPy7aJjQhRSXXzbaOkf7LbiCZIoPqgckJFfNwhLBE3My7aexwnfbF/xPiL02c0DhrJnRj4yUcJDQxg1c0LIbFl1HPQnbPjq/TwG+EMf355P1rV2Qv2Qpk1Pcdp9eIzoM6LmIQdGF3Qo4Ft3yb70ovS6Q/h6hS2r1VdWUbaHyM0aRXA9Kv6bmVY0F5oXxwkeDoILmLL1J10oasVExUMvnktZcyFjPdqAjgTpeQVEHXpg1BtWN8syG/QR+Zv9K3G8fZd87BF/VTRtlAnfkaTnh2dnGVkUqY5kHrta/YO2kUwPtLNx44qcrU4WfGx5szPD7zEvY5L4x6sKIUYz0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 04:16:25PM -0700, Christoph Hellwig wrote: > On Thu, Mar 30, 2023 at 03:51:54PM -0700, Minchan Kim wrote: > > > to remove the call to page_endio() function that unlocks or marks > > > writeback end on the page. > > > > > > Rename the endio handler from zram_page_end_io to zram_read_end_io as > > > the call to page_endio() is removed and to associate the callback to the > > > operation it is used in. > > > > Since zram removed the rw_page and IO comes with bio from now on, > > IIUC, we are fine since every IO will go with chained-IO. Right? > > writeback_store callszram_bvec_read with a NULL bio, that is it just > fires off an async read without any synchronization. It should go under zram_read_from_zspool, not zram_bvec_read_from_bdev. The ZRAM_UNDER_WB and ZRAM_WB under zram_slot_lock should synchronize.