From: Matthew Wilcox <willy@infradead.org>
To: Peng Zhang <zhangpeng362@huawei.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, mike.kravetz@oracle.com,
vishal.moola@gmail.com, muchun.song@linux.dev,
sidhartha.kumar@oracle.com, wangkefeng.wang@huawei.com,
sunnanyong@huawei.com
Subject: Re: [PATCH v4 5/6] mm: convert copy_user_huge_page() to copy_user_folio()
Date: Thu, 30 Mar 2023 19:15:41 +0100 [thread overview]
Message-ID: <ZCXRzfUKZUgPiscf@casper.infradead.org> (raw)
In-Reply-To: <20230330134045.375163-6-zhangpeng362@huawei.com>
On Thu, Mar 30, 2023 at 09:40:44PM +0800, Peng Zhang wrote:
> +void copy_user_folio(struct folio *dst, struct folio *src,
> + unsigned long addr_hint,
> + struct vm_area_struct *vma,
> + unsigned int pages_per_huge_page);
Do we really want to pass in pages_per_huge_page here? We can get
that from folio_nr_pages(dst).
> +++ b/mm/hugetlb.c
> @@ -5097,8 +5097,8 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src,
> ret = PTR_ERR(new_folio);
> break;
> }
> - copy_user_huge_page(&new_folio->page, ptepage, addr, dst_vma,
> - npages);
> + copy_user_folio(new_folio, page_folio(ptepage), addr, dst_vma,
> + npages);
> put_page(ptepage);
This function should be converted to s/ptepage/pte_folio/, but that's
not for this patch series.
> - copy_user_huge_page(&new_folio->page, old_page, address, vma,
> - pages_per_huge_page(h));
> + copy_user_folio(new_folio, page_folio(old_page), address, vma,
> + pages_per_huge_page(h));
Likewise for s/old_page/old_folio/
next prev parent reply other threads:[~2023-03-30 18:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 13:40 [PATCH v4 0/6] userfaultfd: convert userfaultfd functions to use folios Peng Zhang
2023-03-30 13:40 ` [PATCH v4 1/6] userfaultfd: convert mfill_atomic_pte_copy() to use a folio Peng Zhang
2023-03-30 17:02 ` Sidhartha Kumar
2023-03-30 18:02 ` Matthew Wilcox
2023-03-31 9:38 ` zhangpeng (AS)
2023-04-06 21:28 ` Mike Kravetz
2023-03-30 13:40 ` [PATCH v4 2/6] userfaultfd: use kmap_local_page() in copy_huge_page_from_user() Peng Zhang
2023-03-30 13:40 ` [PATCH v4 3/6] userfaultfd: convert copy_huge_page_from_user() to copy_folio_from_user() Peng Zhang
2023-03-30 17:18 ` Sidhartha Kumar
2023-03-30 13:40 ` [PATCH v4 4/6] userfaultfd: convert mfill_atomic_hugetlb() to use a folio Peng Zhang
2023-03-30 17:29 ` Sidhartha Kumar
2023-03-30 13:40 ` [PATCH v4 5/6] mm: convert copy_user_huge_page() to copy_user_folio() Peng Zhang
2023-03-30 18:15 ` Matthew Wilcox [this message]
2023-03-31 9:38 ` zhangpeng (AS)
2023-03-30 13:40 ` [PATCH v4 6/6] userfaultfd: convert mfill_atomic() to use a folio Peng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCXRzfUKZUgPiscf@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=sidhartha.kumar@oracle.com \
--cc=sunnanyong@huawei.com \
--cc=vishal.moola@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=zhangpeng362@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox