From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AC85C6FD1D for ; Thu, 30 Mar 2023 18:02:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D84AB6B0074; Thu, 30 Mar 2023 14:02:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D34296B0078; Thu, 30 Mar 2023 14:02:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C22886B007B; Thu, 30 Mar 2023 14:02:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B14ED6B0074 for ; Thu, 30 Mar 2023 14:02:56 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7FAC01A0A35 for ; Thu, 30 Mar 2023 18:02:56 +0000 (UTC) X-FDA: 80626335552.30.59B90C5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id EE8D918002B for ; Thu, 30 Mar 2023 18:02:52 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZmZhfNUm; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680199373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1Aa7UYbp3NZ+5Vx0LEPR8MqsdlgGFeZ4MOxoVkSDaxY=; b=1CGr+uBWDe7xW2WZjZKnWGoabo4E/vEReMVfnpFrtpdYvD8PS+PN2wMkevWXAyXH0NPeKU 3O9pWl5Qy5RUZTLu7o0vsD9ryREu11RDtmgqhKeKO77BOT1DumiLBHbnwHm72/wTZr1LEw 0JJl0JamPbFVAsoPlqkPLlz35i3/43Y= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZmZhfNUm; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680199373; a=rsa-sha256; cv=none; b=Tt1fOeGLoJT2TdakqwFw0d0fszfttg/NmMimsrEArTZCwX/BnREGZ7r2Jc5/KGXoIFcKF5 Cwv+PfuDgfGOZ91eMy88Y5+OWeanmJff3ZUI2wBMLsUrNI7149vwyqOuiL1aKgxOa2mPgy vPoVhmFdb8aTZciEsS1p8vF3HstMCTM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1Aa7UYbp3NZ+5Vx0LEPR8MqsdlgGFeZ4MOxoVkSDaxY=; b=ZmZhfNUm4wQbR8zStejmdtqI3P O3Bl/BlqUbMGfIaar03ALiOL4NtAwTF3Dk5QjbsmMgYucNmufEB4bKVVUO7ngPAXfj8itxj1dG4Qz N2NHsoSxEbFObLnwzsx4oXmS8X5uNnrIHNF7n/3IUMB6TtJRcOcJM/MgpU6hu3Bqc5n1ylHUJPMUD n938UPYykb/muMv+CVr52UVX/WjwTpC1juSHVgOYXsIDzXTN9itl7XUyl4tfBpJXuheH2LXrFHyY4 bUNCsu0MiqEep+0V0IVf/3qOSCcmcF/dQxAFLAJhjm9RG7BPUNskE8KBuMlAg6S9o2XbcXc0/pHVI t3OrDFyw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1phwbf-00AdP9-JM; Thu, 30 Mar 2023 18:02:39 +0000 Date: Thu, 30 Mar 2023 19:02:39 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: Peng Zhang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, vishal.moola@gmail.com, muchun.song@linux.dev, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Subject: Re: [PATCH v4 1/6] userfaultfd: convert mfill_atomic_pte_copy() to use a folio Message-ID: References: <20230330134045.375163-1-zhangpeng362@huawei.com> <20230330134045.375163-2-zhangpeng362@huawei.com> <765d450c-2ff6-1420-b94f-528d56bffee4@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <765d450c-2ff6-1420-b94f-528d56bffee4@oracle.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EE8D918002B X-Stat-Signature: 64jm8uqm811o7sjrjkgonnkb6btqm6mo X-Rspam-User: X-HE-Tag: 1680199372-828104 X-HE-Meta: U2FsdGVkX1+YFfi35hYJU7Nap96KHpDhAcx9C8a2jY2tnjLNTtoLjF8gttmqUJDdV/gmA9om6a4r/gJfDwnnmnbW4THFMiIPNfH8AQl6W0MJPDJJdxpkdLxdU0fsr/oZWwjUmZJrTlhKoUeJCKUe2Y1xPUqAw3M8bdUlngeKXdJu7iqW35SGm1QOVsEUp8+P4hZNKvOqPYp8U3REX8OsyiDxFXJkAcZbXR1jM8gecvgwVMmrfWoZNUfIOxXWB7PbcOIlGnFdCIfL+BVfUAs8+ysKZGIdrI5NV/XUnCVz0xGVEoM24kdNI0twRA1XkJmZQPqld/8yElYL8jxB9io1E58r4mrmwL+b4z/qvXGWfo+lTTcwAMh9arErABDzbKoQikT1NNI7x6x7fqLZPJGwn2LDnbMrOOnL/7n7KBPwZazTE41FNAHVKKHjveAUduSPV40SogVFU+EE9/ALv27sHnJ98wFRrjBPS7JUzvKgVpLZ/h0sHbZUCbh/47ZlUtspHx8MFyUKgqCqS3o65QdmrlKeEZSr4N6eKrj+lTh5DxNOE8kizzdvkqcIRd2G6QkYPNNRJKpU/V44unSoDoUVIKXPLVqI90xxu2TjLEYdHuydjJIRok02YVWGH2p4VJWywgr7c9Lmpee5ZigOTFt5quh2eATCbXYVBedky7m9og0lX5lcu2s7/U3zi0aZo1BlbbuHIaF3vRMwE199ZkSJIIIgYgXZI9ihPNxAwgFvHr+p2OWLfLSq4vjvSI+j2pV2GJ45yRLsBoJjepjj62zwDZUOGa577UvgQZrg/zZxIpYjoBNr8NXw8zhCvhSaxzl2mU1AB60xMiN6oZXJWVSWODTrSCDGXwCt8BChlP76QrEcpSufTqUerH2Ffz3Dr5JpRcjAmShj13LuIsza3cGwOqCcC/EwY31WI4QKDyCzc21LMBGQpQ3OStVnoIBWd40TK8d1K3nmSJC9Ga4lXcw zAZsD8rd D/V1NbQtS5Mgl47qeTpvmondKt4J78fpx/cwxISFGzrR0KUVCbPOfNsUq7nOYo1Q868Xw8wMEv6f9dCrp5+/kQdJ2f5AR2C0Vh9RAkCJDhpe8L2kcRAyoKpa0Eow3BMr+OEY4DFftJsqUPhOiKsBjt6WfFPrO9HmV9o3+vWtxYG6qtLTEqc+DLv+igg9oAOv1tYkZFn1tEpK87sGy+NAUHJ4Vpq4b+3OxoOjc86w3+NGWpCXtLyaJkSEMSkcdvUcWmAJqmbVnC5EpPX4urBA6JiG/59LOX66MEjqKWKrlWAFx61A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 10:02:52AM -0700, Sidhartha Kumar wrote: > On 3/30/23 6:40 AM, Peng Zhang wrote: > > From: ZhangPeng > > > > Call vma_alloc_folio() directly instead of alloc_page_vma(). Add an > > assertion that this is a single-page folio and removes several calls to > > compound_head(). There's no added assertion in this patch any more, so I'd drop that part of the description. > > if (!*pagep) { > > ret = -ENOMEM; > > - page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, dst_vma, dst_addr); > > - if (!page) > > + folio = vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0, dst_vma, dst_addr, false); > > + if (!folio) > > goto out; > > - page_kaddr = kmap_local_page(page); > > + page_kaddr = kmap_local_folio(folio, 0); > > Should this variable name be kept as page_kaddr or should it be changed to > something like folio_kaddr? kmap_local_folio() returns page_address(), so > maybe page_kaddr is better. I'd just call it 'kaddr'. Or 'addr'.