From: Matthew Wilcox <willy@infradead.org>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: Peng Zhang <zhangpeng362@huawei.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, mike.kravetz@oracle.com,
vishal.moola@gmail.com, muchun.song@linux.dev,
wangkefeng.wang@huawei.com, sunnanyong@huawei.com
Subject: Re: [PATCH v4 1/6] userfaultfd: convert mfill_atomic_pte_copy() to use a folio
Date: Thu, 30 Mar 2023 19:02:39 +0100 [thread overview]
Message-ID: <ZCXOv9rz8GCrpbMk@casper.infradead.org> (raw)
In-Reply-To: <765d450c-2ff6-1420-b94f-528d56bffee4@oracle.com>
On Thu, Mar 30, 2023 at 10:02:52AM -0700, Sidhartha Kumar wrote:
> On 3/30/23 6:40 AM, Peng Zhang wrote:
> > From: ZhangPeng <zhangpeng362@huawei.com>
> >
> > Call vma_alloc_folio() directly instead of alloc_page_vma(). Add an
> > assertion that this is a single-page folio and removes several calls to
> > compound_head().
There's no added assertion in this patch any more, so I'd drop that
part of the description.
> > if (!*pagep) {
> > ret = -ENOMEM;
> > - page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, dst_vma, dst_addr);
> > - if (!page)
> > + folio = vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0, dst_vma, dst_addr, false);
> > + if (!folio)
> > goto out;
> > - page_kaddr = kmap_local_page(page);
> > + page_kaddr = kmap_local_folio(folio, 0);
>
> Should this variable name be kept as page_kaddr or should it be changed to
> something like folio_kaddr? kmap_local_folio() returns page_address(), so
> maybe page_kaddr is better.
I'd just call it 'kaddr'. Or 'addr'.
next prev parent reply other threads:[~2023-03-30 18:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 13:40 [PATCH v4 0/6] userfaultfd: convert userfaultfd functions to use folios Peng Zhang
2023-03-30 13:40 ` [PATCH v4 1/6] userfaultfd: convert mfill_atomic_pte_copy() to use a folio Peng Zhang
2023-03-30 17:02 ` Sidhartha Kumar
2023-03-30 18:02 ` Matthew Wilcox [this message]
2023-03-31 9:38 ` zhangpeng (AS)
2023-04-06 21:28 ` Mike Kravetz
2023-03-30 13:40 ` [PATCH v4 2/6] userfaultfd: use kmap_local_page() in copy_huge_page_from_user() Peng Zhang
2023-03-30 13:40 ` [PATCH v4 3/6] userfaultfd: convert copy_huge_page_from_user() to copy_folio_from_user() Peng Zhang
2023-03-30 17:18 ` Sidhartha Kumar
2023-03-30 13:40 ` [PATCH v4 4/6] userfaultfd: convert mfill_atomic_hugetlb() to use a folio Peng Zhang
2023-03-30 17:29 ` Sidhartha Kumar
2023-03-30 13:40 ` [PATCH v4 5/6] mm: convert copy_user_huge_page() to copy_user_folio() Peng Zhang
2023-03-30 18:15 ` Matthew Wilcox
2023-03-31 9:38 ` zhangpeng (AS)
2023-03-30 13:40 ` [PATCH v4 6/6] userfaultfd: convert mfill_atomic() to use a folio Peng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCXOv9rz8GCrpbMk@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=sidhartha.kumar@oracle.com \
--cc=sunnanyong@huawei.com \
--cc=vishal.moola@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=zhangpeng362@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox