From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC0DAC761A6 for ; Thu, 30 Mar 2023 09:32:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D5856B0072; Thu, 30 Mar 2023 05:32:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55E2D6B0074; Thu, 30 Mar 2023 05:32:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D7516B0075; Thu, 30 Mar 2023 05:32:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2AC786B0072 for ; Thu, 30 Mar 2023 05:32:11 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E6D80140E66 for ; Thu, 30 Mar 2023 09:32:10 +0000 (UTC) X-FDA: 80625048420.29.43D0104 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf01.hostedemail.com (Postfix) with ESMTP id D3B4E4000E for ; Thu, 30 Mar 2023 09:32:07 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=vc4nJO23; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf01.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.208.53 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680168729; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dhY9/3aNsTwYD8JARE0vudUjZ+1QcHbCGg2fnRM4sRI=; b=e5V3hqwJTR6xqXPFtH2lXXdoa9pPlp1K5oG6OoQLHvPh3ad7PTxzOl/heQkL3HmZ42r1/s 4sAUubS6G8gJmIFoz8pKW9e5zbQDU9s+mo4k4BO9v564O0NCOXT90SzdxOmWykmbOtowZP B7k88p08pAs6g9emUBAmE7u9N1nG+ok= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=vc4nJO23; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf01.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.208.53 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680168729; a=rsa-sha256; cv=none; b=2N17RmXEmu5Y6dQupQAlCjmSnbGsrzfcszdC7YNIUI93kRo2jhqD7KZHHJm0AhS4unw3a+ kagmP+jfk/WdFR6Csjr43L0635AtP/D65vaL3wPkzw6f8IJapqgKxkPDMSpNEvjspS4hxz N0NFb04z+T1gOuwDKDyxnfR85OJl7WU= Received: by mail-ed1-f53.google.com with SMTP id i5so74176577eda.0 for ; Thu, 30 Mar 2023 02:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; t=1680168726; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=dhY9/3aNsTwYD8JARE0vudUjZ+1QcHbCGg2fnRM4sRI=; b=vc4nJO23T2Q2lm2HKPBkW1KZABzY9+vE8sCq1qfaQlT9LzrfpSEHyhy/fblPbrusvi 5ljMIY9ieK6OqfgZk9k31oF8z11eSj3mLin6FflkRZPD91D7euhQdWvbhBF2kNU9paEm EEUw9SRQy1MrHtrfb12j5CE1ElgR/ONERAchYFL1H/hMTAyYkOodcbvjut+H0Gt1yVTG ++/e2sNL9VSlMmfrCRFE5e3GT+zR1Dv20Kq5ZwQZ/sTOOR9IsqnFOD8Z2F9n2VBuwrsZ 1m31fck8eJr9WqAg9xYNfCyv+/rXVkQZsaGeEeFh+VjMriQKGe31laXefWKbC5BA+oOn vvWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680168726; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dhY9/3aNsTwYD8JARE0vudUjZ+1QcHbCGg2fnRM4sRI=; b=wj9bZFb4pafKVn4di7mStXjKOpAQldlRmfhTeZotdlPoc+y95kutBVCxNrDNeAvy9P pPj8cYsR9+GDqj19JQBMtvkfj4RZBFRjnlAUTqUaCA1wnnrOlO/oCxxuEplxW2UBzBNf oozCDCMyNnZlsPfdncTGW5NSCXelisciNbw7UfWsZ/0MDV2NlXfffsskVmjF1krQVNMC oOUBH+NO6JdhLqr2qI8VYP6xVEo4OMGrVUvsGJibaOfZfn8sukH0Pd+d67gFjgrbio2w 3l06SRjHUYu4L9URc9xBuzPbbMA+ikpINJjb+CoG3itzL3+ceycefdbxybuwgtwc2/V5 uhbA== X-Gm-Message-State: AAQBX9cQrqunTFNTUcwKzo0wF+MmBzPtyykKfUw1WycEDz1OhiLiNvd6 R3OdwjDd/qFuphAoNfnGtR1fRsXXRJd3X0Qd28PDhA== X-Google-Smtp-Source: AKy350alAnOUxE/5fQm9gWe+KOGNktqREfVXP71vAIxmMmmyVwTNOpQG2cmV3p42xTFkgZJDZEhUKg== X-Received: by 2002:a17:907:25cb:b0:946:f79b:e785 with SMTP id ae11-20020a17090725cb00b00946f79be785mr6532593ejc.2.1680168726200; Thu, 30 Mar 2023 02:32:06 -0700 (PDT) Received: from localhost ([2a02:8070:6387:ab20:5139:4abd:1194:8f0e]) by smtp.gmail.com with ESMTPSA id lt11-20020a170906fa8b00b008e54ac90de1sm17437256ejb.74.2023.03.30.02.32.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Mar 2023 02:32:06 -0700 (PDT) Date: Thu, 30 Mar 2023 05:32:04 -0400 From: Johannes Weiner To: Zhaoyang Huang Cc: "zhaoyang.huang" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Subject: Re: [PATCH] mm: mark folio as workingset in lru_deactivate_fn Message-ID: References: <1680086855-7989-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: D3B4E4000E X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: i6utehbxthtyzobgbe1n3py4pnrks769 X-HE-Tag: 1680168727-249514 X-HE-Meta: U2FsdGVkX18JAoQtYmHD/aFUVIelBMh5EuCnkHduw2VoMFbIJRKq/3WYWS/w9TmyV4l/V64e8yOy3gjiO3DQLxPgeIDx5z0TKUhwjISym50bvATA1aLPGWEPQ6sG4okLgrhYDmkbTNPrZ+e8KhewaXImlU+ptpntcnIpqs3Lx2jgvQ6sQ/yDTdTq5rsi8mRiAJ/V9vsgho0dLTJD+9TTYThsL3l1scbFwDGRo3x1ba0LaguOtgwRHVGJMccTDR1C1KK4IMbGINPY25QCS4XcnY4KsjbtZh34rtOjzLjiw1MYIRXHVahglpul5ElOn5kUo68hWJnT33pvriHFsbOspgPN7FgcdQKcKQduws1RbkBssbq06+jX57j9PHvlhiZxaz7tcJVDfGM0yosc+kbHMu76kZG1SiEzS6bOV80qEQo+s4mEnJVpYOz8E0JBAfnu+HLbW9/H6JhDAwVPHNlB9trB0PDsfgDFL8Xolj+F+gIDmtZNIMK+TR+go6H3K6EQmE0VWjRar8VuaXk+v63UEeNFGTvA6qKyog3UqFN2QYvxeIKIt47mLvLmEq3ed6JAJc7vPQOmgBW6hChxe7l6F8t6Ue4h2jjccpywtJzmB0ebkRAkvoc54boI7JPLvnZIlgKlMKVMEI2ilrtxIKP9COKU6VHXzUqc8Tw5FT4IwxFESDDvitIazY8/vkrJsLjJVw6dkmgF9hiKmoP5tc8R2uwL5p7rBbcwLWskFzrD267Hj2jiw4ZvdhNzPIeq0xZb3sbNO1i9ag2J6KPeNU1ZCHCoIaZtFc88PWNQcPJoXZ3IfYAZRvabn2EFe2wSMPO2tLBLnWYzHZ9n07zVqBA6ufEuk7fjJ21GLQfQyy5Zex29cQq0XueNeI70frf/9c9utfI5Y2MGpGy+RnJ01THEg4W1N37XuglZiT2BlmMjD4CV9zoEhbc95m3EEZ2mhFKAd++ojD3vsVuWeeOPLSh cq9Rfiyn QRl68a7pksROkFtKCS7Ts1Z8kUbFgrVdf487ZFAE/OwmeG9RLEKo9UUVZB8N/VnqpqI3Bmby6lTudms6cachP6saewX5+M7VSjbhUX4Abia0QwZsZ731uixSzOiSZrmm8XaZrrnSte9w3bBL/ewHyWUSqAx/adAKZWUEktjupadz/ucNoh4w+46f3NhEHt+ejIEt0jQXNrFs6j3CPkKeKU8cd7gdtemnDD8A184lUROAv0DC6VJ2zQZyYTYn+MuA5bZdvnlFxb9C0BktbhkbKyBL06SEgxc6WYxezjtI2wYvVDwvb+xcwzmZpOf2K2imYSfF5h9nxrfVH7F4dbcBY+3t04+nnqvqcSca3ikA+UkLclNz0TsmpwK3y+KYzBwbcuP9kjlYVEWybrnbEpyLOqvMlXbDdMclYXezkhhm5MWe1xCuG1mVzKm8QB8BcAJJL2cI/41rgttIaHuivzWUj3fO5GHduxcZE/HE8+QCXxHLSl6yPaRvflcZUKIq2GXpTVIVv7tJRoeJ/O0R6jBmxZRML3K1s4TtPND/SjQd7HaKsO1Soj0wH8gWHePIMlsJYGNKRHNmm3bdyU4KdSxOy9x1e4J8imsGd1RXF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 09:38:48AM +0800, Zhaoyang Huang wrote: > On Wed, Mar 29, 2023 at 10:55 PM Johannes Weiner wrote: > > > > On Wed, Mar 29, 2023 at 06:47:35PM +0800, zhaoyang.huang wrote: > > > From: Zhaoyang Huang > > > > > > folio will skip of being set as workingset in lru_deactivate_fn. > > > > Can you please elaborate why that's undesirable? What's the problem > > you're fixing? > If I am correct, folio will skip being set as workingset when moving > from active lru to inactive lru, which is performed on every folio in > shrink_active_list during normal reclaim. shrink_active_list directly calls folio_set_workingset(). The function you're editing is used for things like MADV_COLD and truncate(). It sounds like there is just a misunderstanding of the code, not an actual problem.