From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FB8CC6FD1D for ; Thu, 30 Mar 2023 08:39:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D75746B0075; Thu, 30 Mar 2023 04:39:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D25436B0078; Thu, 30 Mar 2023 04:39:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEE2F6B007B; Thu, 30 Mar 2023 04:39:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B0D0A6B0075 for ; Thu, 30 Mar 2023 04:39:09 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7E94F160F19 for ; Thu, 30 Mar 2023 08:39:09 +0000 (UTC) X-FDA: 80624914818.16.5D595D4 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf20.hostedemail.com (Postfix) with ESMTP id 73E631C000F for ; Thu, 30 Mar 2023 08:39:07 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=ZgNg5Gon; spf=pass (imf20.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680165547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l77j8HdtGUHY1DMGytaSmxCL2KwdNyQtcXi/v8k1LPw=; b=BMVg3aHnuGXAIHLaPqbv5IpA8EqEQi5UdCvtZ4FAy7t0HuBkDrZEotLqYE8mS7YT7ckbs7 TCZR/YzBBAxLkDMSrHNpQoWgGoASSEmLrkG6eCc52n6ZOoD/akniFPtTAIMzZzQbg/vvSO mNgfGiiI3q4Gf/qIq7Rw7QQaA8yNWU8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=ZgNg5Gon; spf=pass (imf20.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680165547; a=rsa-sha256; cv=none; b=Om7E+Sj/EMj5UuQc/oB1Y94JICHlnjvZsXo8Y8VeqV/VQEwgFgE0NlCw2SljQ++AV/HlKo wyL6h0dS8kM4kSzmzZCEpy6XhS0YBkDrqbSX0rryPQzTlglw1FWhLzPzsSuSGSsunbAr1Z vS3f3gj0DL90agB4AVtzRwEsuombwBo= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1AB851FE3F; Thu, 30 Mar 2023 08:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680165546; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l77j8HdtGUHY1DMGytaSmxCL2KwdNyQtcXi/v8k1LPw=; b=ZgNg5GontEAiDlgn92dJ6MtfZud/Zqf+VjcX9eEi4gTi2tHmEQ33ugODl7Ly+X0ZWtEsA+ p3AZ19J4aHB5KoT4BR/c1glf2Ls0e6ZF0/gGE1sQoKTvQeCB+cmYH2J59mXyjUNEtHGGaB aZDvQcyHUI3flpOOeXADbKoneVeUCeA= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EC0D1138FF; Thu, 30 Mar 2023 08:39:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6e0lN6lKJWRCHQAAMHmgww (envelope-from ); Thu, 30 Mar 2023 08:39:05 +0000 Date: Thu, 30 Mar 2023 10:39:04 +0200 From: Michal Hocko To: Yosry Ahmed Cc: Johannes Weiner , Shakeel Butt , Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Roman Gushchin , Muchun Song , Andrew Morton , Michal =?iso-8859-1?Q?Koutn=FD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 4/9] cgroup: rstat: add WARN_ON_ONCE() if flushing outside task context Message-ID: References: <20230328221644.803272-5-yosryahmed@google.com> <20230329192059.2nlme5ubshzdbpg6@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 73E631C000F X-Stat-Signature: tz9jn5t99e8p4naagzj5zwak6mk9xwyo X-Rspam-User: X-HE-Tag: 1680165547-69412 X-HE-Meta: U2FsdGVkX1/Gc/crLHYl12f0TFX0W9yuREBtgeA+pWgvsDY25ifcQln7xyptvDHudVCHo5j2XD269PtWWjV6KJ7fUNTs2bMS/nCm/Ksw09ozFMrrNJ+8JOoG6bD1H0nnSY0SZ2pzEX3dVOmpWdAgr8BewhujdOGsWQ2Dmz/2+xaPbhVcy/RYJzpa0GR54xdzuspxiluOhhWCVLvbkZ29Z7R8HQ9udOPQP9UCOxDU289imT7NSJ9sfQoA/XIwzoOjWjm4sBRNHeOEpgDNYGtmJkNx+cRFFi3K+8N2xZ+rEv/7q+ug5ilrDFcPkYzWCFJ8RjS6Wc5OdSinr61OTyEwJ0ZQ0HQa92xM/rIKfaXf+5aDpzUMtopZbfZHan2jZpWYPxEnxLueQXKksk04afzhuwpRfbK4JdaHqQaf2BpbUuko63wVfB1xB99835uq3Gscl31Ln6xhySt3CIICNSg33NV/VWRUXVlCXHcXTn5pTdiLeWjGQaa5vv3hKcEehb2CFPJAgD6gbcSjKfJM+tBIgZw0/5i2rNbPWKoRp3z6zO7DUHwjnKqY1pxRw2eliZ2twP4a10PW0WfFv1S8QnSriJf2JWuNKq3MYNFd6UnO0vckaMHVDAtefDVuku3KXypqCb5c2n+jI1c685Xpqz69uZ2FtsbHk8cqgGv+1Ywz6+mrlZt/9pubjOTYqwm0DDLMDpbhkXuMvHm9wtrTdG9YpEXnZNQCT5eAGQYpoZr/Zeqybig8IKkVGOFVCTUQ6fXrzydH9/4bCEOUI1NkTOzbYcvcI/XHDkMyLgzArWie7u7IvXGCRa0U0jPT7l0L2nNEJWhYklvWHQuDDd6I7F0EJhxWbaZ9KFyHUeuEr0G4asc7pCppACS5CRsbD0dhb2V9khatalZ2/0pcckSQxF2imhw8LDGq1fV0aKf9GY6M0958OR1bXbJFkFiHwT9w4Nw5yIoOwlz+n53X7j8H9en s6JVMO67 r/cU1ScIDZECyz/+cmde3cCKcHfe3xGZpytXJ8YXu4VMrr0oEMWNrSE8cXKF0jvoSK5vNSGHns8sL3MDefrZpCd4VlFX9THNlFvomKN54gq/MKCAPGw7TQhfqCLrJqc2waFtkPIbK8rJH8J6QTwvS28PS8AEot2oirWWd6yNAUYVtBjOhi7ri46gBJWbJtllQ0bquBm1o/n1VZAY8Hz/0yv6g7QeyDzpalFS/740ahjIMCDmLoF0Y9nIU51LoqWuEaBCjZzKt1qW0rZ4z8Rco6oWlDw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 30-03-23 01:19:29, Yosry Ahmed wrote: > On Thu, Mar 30, 2023 at 1:15 AM Michal Hocko wrote: > > > > On Thu 30-03-23 01:06:26, Yosry Ahmed wrote: > > [...] > > > If we achieve that, do you think it makes sense to add > > > WARN_ON_ONCE(irqs_disabled()) instead to prevent future users from > > > flushing while disabling irqs or in irq context? > > > > WARN_ON (similar to BUG_ON) will not prevent anybody from doing bad > > things. We already have means to shout about sleepable code being > > invoked from an atomic context and there is no reason to duplicate that. > > As I've said earlier WARN_ON might panic the system in some > > configurations (and yes they are used also in production systems - do > > not ask me why...). So please be careful about that and use that only > > when something really bad (yet recoverable) is going on. > > Thanks for the information (I was about to ask why about production > systems, but okay..). I will avoid WARN_ON completely. For the > purposes of this series I will drop this patch anyway. Thanks! People do strange things sometimes... > Any idea how to shout about "hey this may take too long, why are you > doing it with irqs disabled?!"? Well we have a hard lockup detector. It hits at a much higher stall by default but if you care about IRQ latencies in general then you likely want to lower. Another thing would be IRQ tracing. In any case this code path shouldn't be any special. Sure it can take long on large systems but I bet there are more of those. -- Michal Hocko SUSE Labs