From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8147C6FD1D for ; Thu, 30 Mar 2023 08:15:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34E636B0072; Thu, 30 Mar 2023 04:15:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3090A6B0074; Thu, 30 Mar 2023 04:15:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19E5A6B0075; Thu, 30 Mar 2023 04:15:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 067716B0072 for ; Thu, 30 Mar 2023 04:15:04 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BDEC9120956 for ; Thu, 30 Mar 2023 08:15:03 +0000 (UTC) X-FDA: 80624854086.14.78E23FD Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf06.hostedemail.com (Postfix) with ESMTP id E23CF180003 for ; Thu, 30 Mar 2023 08:15:01 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Zkm382Du; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680164102; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L+5wWM9KaM83E2/8g4jR2hxUBs15iqyGGbyguGgqv6E=; b=18vDSqLPb911pox4PQGNPYQ3WCzxGif87PeHeYa0UXLP44/CBvUSXzo4ELwfE6Jn2Anh4t tghFIZ7PUs71bufJkpbSBatQFNq3mF/QgMe+83nI3IRkgm2SQR6IyjUdODfG1BCg2CRDaJ 3yZuaPLwrp+WQnndYgy/xnez9IaWv5w= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Zkm382Du; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680164102; a=rsa-sha256; cv=none; b=zjIhwLlKF+uckIAkVf/wvRdt66rnCBYBVETvhxI9wtynp7q/Iw9efFuVzUxY7MuhEtQNUz KaMwnGPX++xtczo1gFGNmkkdHFDpy7+7g+rG+w5RORWAX15xDFoBXYcPl8cTb7gQpoifIo gBwNG2qiprBh0cRm/YCCFB9kZaKKzq0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 617961FEA1; Thu, 30 Mar 2023 08:15:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680164100; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L+5wWM9KaM83E2/8g4jR2hxUBs15iqyGGbyguGgqv6E=; b=Zkm382DuV3cURAzt/IiQ9KAhrZxaXTxTdveLwdBMtYHpoE8u1K6ciaYaQMSNkGJ/omClUo iIcdekBvIAUYIuqAzCDRW3IXFkKXanegH0ZMMprE+/Z1xVDp1l90YBKnyajEOetGF/rKfL 5FdD/y8rIiefom+dXeppIrIHiFQKcfg= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3EC03138FF; Thu, 30 Mar 2023 08:15:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Ip3yDARFJWTAEAAAMHmgww (envelope-from ); Thu, 30 Mar 2023 08:15:00 +0000 Date: Thu, 30 Mar 2023 10:14:59 +0200 From: Michal Hocko To: Yosry Ahmed Cc: Johannes Weiner , Shakeel Butt , Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Roman Gushchin , Muchun Song , Andrew Morton , Michal =?iso-8859-1?Q?Koutn=FD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 4/9] cgroup: rstat: add WARN_ON_ONCE() if flushing outside task context Message-ID: References: <20230328221644.803272-1-yosryahmed@google.com> <20230328221644.803272-5-yosryahmed@google.com> <20230329192059.2nlme5ubshzdbpg6@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E23CF180003 X-Rspam-User: X-Stat-Signature: ofw3yn3otb8dngtqxrii9ti6ga8aj91m X-HE-Tag: 1680164101-967737 X-HE-Meta: U2FsdGVkX19MaxrwH3mfJquECe9my4FJiUNvTpQfyQ9+sXm+z21rbG8ASyhygYG2YMdGvMCOjuLFb4xF2FkJIQ9e0R8dHnHNMlQI2BCE5dNoTsYAdQaL3GMILsP47znLxGProb9orzJ9CpjFZjFed76ugXbPtoSfw3p+aL8hDmh12Je2My41rSKpDrjnK+LF30FOUU+btFHXnpSXE+O2gZcqztzV7Io2+w+p0gRJWJ5HuAGWLdCFN5bpHdwbN/OgvTMJM8MtKzU8slfnCOK8Nr+MuHFgpyMyI3psOys8N/FJddrA9KjQ0HvWu+gD+BoGrBluQl6dj94pHqbbEksfl4Q1yHA/OqLKvURKesGfQZSrg9RYardPRbXf4uume6wA82PzanlWWjtHoE+uucyofa70cqWvYUubNwfEma8p3XlsQakdH/Fg4GNAHT1qcIszGDB5PdJPOyg7PnRpLsl9kNmDMwM0Ci3oCLST4uelU5SqvgIQfHiDJF2pHr+ibmtv/1JdaI6GgwasapOZO6kV8Z2AaYc8DzWWMnvzhn73kRXSXF1vn/TYSiMJ1TAeE5MxLbfUUN+2d543byrtlwJDsXEOl/quS8a+JuIRW2GXpZpdraRi5NRFky1JZQ7hP4l9/UNRHxA1Ir8HACvC80Ag5/bziaCBMEqYS+KPeYAI+HG7dMxkEGoxPiPkHXf9HRNxHy+ziKyMirAM/jGvrBxpWWsDRaboJHVAmlDCrMre0kPu4P1HtYVkjnE6DnRPojV2I3TY8L5AXwoDKyOtwlSjeWpxXHjzBzJxlcCl4+o1+2uvKMox9Gkl2IcAgkHwI1t2bDQWUw6O+OhD9V7R4OfOhq7qBHZK7hM+yCuy6Ttn2TTBPkeS3Nx1TP/ErYoBNMKB9g6p1ak1K9+vYnLtkESt0ONvsmcft6dkVcqF8a0d9V5W9l8CxNIYljkN0oMPKgDrdR7lQVG6B76BT/lJxqp vyTj+Elu aCmtk4pe4j4V7o2HOmmImB+qHK3wUj3D+1F/hv16Kz3pB5kdmdArK1knpMggd7PnOEgjI+Squw15JuJVjEc7pLv3SlUEEY2XFF/W5ElGrhL11KPPlBN8h2YiamnT3xnOlIMnGgPBtQco+Dy2k++OTJ8pW+3hBcNcF4hZ8hbmqDAxBshfjiV/fgKjeysRkNhwhAW89Hz0DGF92Lnyfy5/pRyR7JA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 30-03-23 01:06:26, Yosry Ahmed wrote: [...] > If we achieve that, do you think it makes sense to add > WARN_ON_ONCE(irqs_disabled()) instead to prevent future users from > flushing while disabling irqs or in irq context? WARN_ON (similar to BUG_ON) will not prevent anybody from doing bad things. We already have means to shout about sleepable code being invoked from an atomic context and there is no reason to duplicate that. As I've said earlier WARN_ON might panic the system in some configurations (and yes they are used also in production systems - do not ask me why...). So please be careful about that and use that only when something really bad (yet recoverable) is going on. -- Michal Hocko SUSE Labs