From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DC96C761AF for ; Thu, 30 Mar 2023 07:39:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3E6E6B0072; Thu, 30 Mar 2023 03:39:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC6DA6B0074; Thu, 30 Mar 2023 03:39:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C408C6B0075; Thu, 30 Mar 2023 03:39:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B04426B0072 for ; Thu, 30 Mar 2023 03:39:38 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 747B8AC60A for ; Thu, 30 Mar 2023 07:39:38 +0000 (UTC) X-FDA: 80624764836.04.4D225DB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf30.hostedemail.com (Postfix) with ESMTP id 976D88001A for ; Thu, 30 Mar 2023 07:39:36 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=ET0uIz8S; spf=pass (imf30.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680161976; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g18B/GLg5ItJpD8zvJQQFzAO1axtsluF41GXm3XAUWQ=; b=qFEE9AFG6vFtKx3irjCBMbfOhzeQn5clyXiRgbAqJ1r+jwkKjZVbcPjvtddAQOu7iQJPgB v8l2eCcCbXwzX6TNy/zCvC7SU3UhcXHmeaMjxycIHSeo1tVLxOmi1LLPHdhv2l/GrD2DQq yJKqUviJ8PdW5lQg+vfBZQUJL/Cnom0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=ET0uIz8S; spf=pass (imf30.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680161976; a=rsa-sha256; cv=none; b=FWU0ydrOG8ax780cdvtiNIQUqIo+GkQ7C0f38nUaPfwsxB8o6s8TlM7q6aBuVvgKhlKm9z 7sH4eVBTI7bxGc49vp3TupI+bF5zLQTw4R6e/B+Q5LnoAV4pCCD872DChCLxbrTUvhADjb 3YBMxVkvvZIL79ILliut28VSsBXHHQg= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 26AA121B00; Thu, 30 Mar 2023 07:39:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680161975; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g18B/GLg5ItJpD8zvJQQFzAO1axtsluF41GXm3XAUWQ=; b=ET0uIz8SFpap4Z0OGPb9kwXXtyHW/o/NGozAbd+0d3gbFzcP0A1LuFuJJJfq/l87AkaSbV PgKMOzdr17x6a4N6mNu8/3S0yq7fyz8szN2RSGvlRHH+6oHlgPx7hTfNDt5u9aESoovany 8D/iM3t2ToRiYsbtSkzNzWdUvaSrkg0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 06E591348E; Thu, 30 Mar 2023 07:39:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5x/vOrY8JWRyfAAAMHmgww (envelope-from ); Thu, 30 Mar 2023 07:39:34 +0000 Date: Thu, 30 Mar 2023 09:39:34 +0200 From: Michal Hocko To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Michal =?iso-8859-1?Q?Koutn=FD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 7/9] workingset: memcg: sleep when flushing stats in workingset_refault() Message-ID: References: <20230328221644.803272-1-yosryahmed@google.com> <20230328221644.803272-8-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230328221644.803272-8-yosryahmed@google.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 976D88001A X-Stat-Signature: si5a93hu7r3pjn4j665yr1xczx11nwm5 X-HE-Tag: 1680161976-288977 X-HE-Meta: U2FsdGVkX18UR54hBp/kZfTaoFICZk64MItDQTqdFVbd7AqHyuzvmI126gEE7pE8BVH70lckivR/L20abHi5ZwMXEpzoUzRvvlRFg3P1s1nwD/rWKF5DDZK0+Yq9GiKwmqoya9P9hxKtcwUDpJMQdGiNKtcKGcksz0OemHIZc4plv9f+vIzqZgDtw09RNVwqIqGjMWCoX0zrzp+OXlGQiiM0dvd0+fX/TkmzMVXHZFc7tORucQeqOy+OKlubjxjyFGB2kseo7CLjltumQMfNVNJ1h9eBni6hXr8Bs3vovbKucfNJFtwb9CnXa2bbolOsqaBKzc2rBsOHtYI2c3nHD5ngGGAGmkHLCIoTv03v9HblC89gzLEnLMCLAibSHNTZZ0/xVf8nuwL5n3yMsYx+/mTDSz4nc6X4GYAcIlIuVicKBsA6gjy8wkFOkUhIYJ3Nvb0rSrvaoeQUAYgb+6X2Pb2N0nW1S4TLauM+OzlsIOdMi2iR884PVQ71EgAvFoQfe4Tz2efmL1EeL/RgpirXsPSoymSwrNX4bYZDHMQdFJ1yUFnHtNJ5kwUi32ZyIctyTJa7kQ+eIBB4E8yg/4dXdkN66kEtYWJXZKsua5uJVQYSkHKKyZmhTeMFD2ddQ7MvvhqfI042Fntrzz0EaQSV61UBDUQ2DJHVfGrSc3/J2Pg52sWVOkEns06QkpTT5a9nwpzjBE9xxmbROlQkkzy0nG80DsZjjgi03CWyjABIx0WctvxO2bONpCTWVgsyY4gFUt1PccwMNCSXkuY+XkwmdZ/i74LzqgGdwPrz/kXGRiJp2OYkPjG6AcE4ivbGDXp8yMxUroGhU6zrIHzu3gXNv9QfWEtkjGo8wRZJ+3/J/inMBOEDk4Nfczi9sHbCMEQDYkAiQW0MghYDp2zDjy6yLlb7dPzoRbyuiQBgU8balEIXrf/78WWUsUTy971uBfaFvwl3hrbKDQGjcJmnEJf YstmcOEX Whom5CTgJmqab3nhZoFvyKYZuHDAZgnsF/QWQM2HWKCKuCviueL7tIhYd911rKwMal900PiM5D/kvz2jZ+jW/OKYwVD9UpIzUVW1P6J4t7Urh4lK/tpZQscjg1b7YpE5/ljhz0exPcxpX+d1a8VghbJSbEaN9q3pN0z3bRR1wSDMT/x/ucPuUf5OCeanPQh6ElCnUcADfHBmsvOqV/oEAtMOCXg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 28-03-23 22:16:42, Yosry Ahmed wrote: > In workingset_refault(), we call > mem_cgroup_flush_stats_atomic_ratelimited() to flush stats within an > RCU read section and with sleeping disallowed. Move the call above > the RCU read section and allow sleeping to avoid unnecessarily > performing a lot of work without sleeping. Could you say few words why the flushing is done before counters are updated rather than after (the RCU section)? -- Michal Hocko SUSE Labs