From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54607C6FD18 for ; Wed, 29 Mar 2023 15:01:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC60F900004; Wed, 29 Mar 2023 11:01:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E76BA900002; Wed, 29 Mar 2023 11:01:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3DE0900004; Wed, 29 Mar 2023 11:01:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C6FE0900002 for ; Wed, 29 Mar 2023 11:01:39 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7E958120686 for ; Wed, 29 Mar 2023 15:01:39 +0000 (UTC) X-FDA: 80622249918.26.CE88E10 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf11.hostedemail.com (Postfix) with ESMTP id 254784002B for ; Wed, 29 Mar 2023 15:01:36 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b="ge5V2/eJ"; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.128.54 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680102097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ult/ejLsoGkxOcm1OAQ4n/1DUPXwVhbqifVVNbYHzAE=; b=e2BbuvZ5RVAvLax9KZuNgo3JpUR0lokeABx9ESVwLfHBaKmXQgvEvxgmEPNt+vYyGVdYM1 niJ/dn6ruzXNsIGgDb9y7Ih2H93+11Bledc29DP5Edcn7UUhIZPg6TJ6W/gAraIbbBl/VZ d2Ln6S5q/GGPtstyPh/ssvAtaUT47bU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b="ge5V2/eJ"; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.128.54 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680102097; a=rsa-sha256; cv=none; b=ukixNv0Rf5/eOQdZoz6hHv1vZa9f9KQpnGfbCVznT8zANTZHEPJvxHYIUZVAYQjExQPMOq oQsqwiAxJXSDMMTd5TAoorXLUEF37g1/DBtQyoR4LUQkFsudy6kTxmGHVwguXg04wZOcI8 NplstJ5z7HhlIKRXBueFLpRUX5dGXSk= Received: by mail-wm1-f54.google.com with SMTP id j18-20020a05600c1c1200b003ee5157346cso11653912wms.1 for ; Wed, 29 Mar 2023 08:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; t=1680102095; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ult/ejLsoGkxOcm1OAQ4n/1DUPXwVhbqifVVNbYHzAE=; b=ge5V2/eJt15E380KnNgeMHlR4FiwITr0tWRgBnilL0WW+DMFUYTGE++ED5dChvrYoW Miz35dOO8JhB1pyXIId5jE4L8/za+MCtOPL9+041fzN+Ml6o01Ql7XdTAvcpuPCIMTL0 98HHBrEv9zOfdn0n+mIoWcfVnYbjGOAMB9y6MGLUF+jBoLrcg4Ql9wwhx8jKB0Vlpz6C GRZXlM+ykwZwNIXl91zbPW6/WoDr9ItLYNsVv62KAHzdcXhhPygDHV4VUqFeNvNc1+9H /Vt3CQqOftwFhlVfHxkiocs6ns3k7fC5n/o3eYqJtbZJP66SQQTJ417H2V2pN7ieAb3u 67Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680102095; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ult/ejLsoGkxOcm1OAQ4n/1DUPXwVhbqifVVNbYHzAE=; b=Z6aUjXMJPcdHMCkDQaQzfT1wFBzMtINK5SKXMjgEttP7FVcj0D0MI+mCI2+Y+Mz8+Z euhNE7bOnDeey/hGB0OwNDFpvMvzRyJUmbCWrxe538UvvFx2s9qhwbt6wMCKqoSX8SgT o7XHfwTkKOea64990v7BThS9VPtbtT8y/P07dCst35tH4QPHiIr38nJjiv+WERNaaS5Q 7XwatS6pr4z/1dlACgNANtUyxJKRCHri2eNJUXTMGZCeJoP9iBWicr4lUHpxXHhF6ZiH /fyuoEMjlu+SIGc5h60e+4eVvcNR44ngsnCQg96fQHOSrZhUj/+S/WTk27T8bjkuM7ak m4Rg== X-Gm-Message-State: AO0yUKWoH2U6BzwXfHG756eR605OiGJUQpt7k/G+0pG6RIwEeZKBQtgK ATapILsuPBQgaJHhm/MUNcB8VEtbwXt9Pi1jNKMQwg== X-Google-Smtp-Source: AKy350YSvV//7Yt4IYbsf+hnXMJZpyjvQSaofY/td/PLeqSzvwzLYBpC+/O7+M+kwHfDQ7YfiCB/TQ== X-Received: by 2002:a17:906:6a13:b0:92e:3944:716d with SMTP id qw19-20020a1709066a1300b0092e3944716dmr24968402ejc.3.1680101738533; Wed, 29 Mar 2023 07:55:38 -0700 (PDT) Received: from localhost ([2620:10d:c092:400::5:e994]) by smtp.gmail.com with ESMTPSA id t23-20020a1709063e5700b00930b13f6abdsm16685578eji.98.2023.03.29.07.55.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Mar 2023 07:55:38 -0700 (PDT) Date: Wed, 29 Mar 2023 10:55:36 -0400 From: Johannes Weiner To: "zhaoyang.huang" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , ke.wang@unisoc.com Subject: Re: [PATCH] mm: mark folio as workingset in lru_deactivate_fn Message-ID: References: <1680086855-7989-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1680086855-7989-1-git-send-email-zhaoyang.huang@unisoc.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 254784002B X-Rspam-User: X-Stat-Signature: 41trsiq54ap3e6dugf8u31zaafierxiq X-HE-Tag: 1680102096-730250 X-HE-Meta: U2FsdGVkX18KjVppGBK+zu5X4YwL8U8tlKIC/Njw8WccOAyDwAFGdkEkCT9ej9GDvBvaTcTjo6K1KwNmmP3BgehNXiU1MsxookfemM+kRTGNBTzGh8WANDorgJI//NYGlJToceDxkgqsqrnfKEfdNOIDQODH/adxZrz+QHZSzqSswOrZq0/ZiTdTiknOlasWKnAOMghyuK6CqRaBEA6nsoE/9+syTUAXR4Tw7L02kmZvPq4DR6bhtxc46Vfb9LFUR8dXxpH0nZyWwQz0bKPZCU5rCQt7zKVQQ2MH8vx4+02rRc5oBWSY/t974/hvDvTSS+F/juPFc1Ki2b/wkEJC9bozoxK04lnrsGaf2z7S/XZiLTu4/dLAQUO3ZosE4MPBk/NmODGJ1pY4+k2dNnV1KbL4q4iIW0IJ46fBKIDxFdyd1vMNUFunJEr3k82pqEs5zmi9Svmtkfo0X1xrziq5o7+NO9kvJ8AIf0cdh4vY49LWacMH2fhr+yhjZCdDgEhBMt14TtkCT9r6sSBBPzPvrU61AGIqXC1yv1lH6td2W33a3rCfwqhe4q9IcjsXSCcTLH+n7J1so7k1szOgzeP8wbXUU22LkyN3N7V1eUPd9URN/Ebm3/1u/pVYGjAsG/1+BNntTsf0HLJNTIZPNQ2eUWu2af7FI6fqxKPAb0JhFJg7BpxNlMWvKPqVMW67qIjKfl9WAFz+tfvJNvyg5Xq+jfdAipEvSsgef4DQL2ynPq+rXOCUGBXci2Ecio5NkLU9azh7LM/qXxohRsXy4dJNdahVlsmQ35eB+uNjuidhjEG4MORlmc7KxkcKPE0NxJoWXVpu61PBZlkwD3PXAnb4NijWpZaJJzFey44WfotFVTpYJa3oo9bXYIdHZFfU4GpdDTnaOWN/l8bQlNDaGY6cXEinRxgxilI3bZpGNnyBd6DPKFl9ZpYLTwD+j5lsJNfTA1p3pj+he9RirfY5Wmh UTl9R+Yr JivkZQUp+OJM8Cso8FV9yh7ii9yxIytVn/YWurFcoubTAjlJFRgZb3Q4W4Lms/NDLbXf+wokhHrNX+w4uYxrBa0esbPjJHj/pdy/MVaIgoBMSLbVBcnnLmy2IBox5zZSCmLqUnpkiG6M6kuORDp897lYZrtRvSvkHyJI675EO1XCYlQYvh47xsZ7EtKLt+izHtG+e0o8ZdwCkDOnd2ROCekd0r/RPt+c6UVgm8MhGpoizGTtKqEc664xPKdrTlJlyKrrkJKsVeWovPB7UnrpLgptUa5VZICsmpGrK2n5fEd41IEXFye+aICTxV5ZK+qBlxaocqr4lsCcPT+PIkSyzzxffr9+/Gat9wR3iSQd+COdUjuBazZRXB6HSh+n2ei5hTabHQoa9zSyUiJo/YeXZWGQiE+P2EdGnOVeBRO8ba2h+9NMUgwIChXw5p2AIclvxfmfQKhoIvwWvA24TpMdNG8SIweqzeCyfAJlyKbqCXrlU/2mZVZMF3j40rQAUSQJ/2xSqJpB46Jv2nGNStnfiYfpSKchfu0oM7URwI6KvRKGYpGTMvgMhy+SX+G0c8DPJ5MU0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.068391, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 29, 2023 at 06:47:35PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > folio will skip of being set as workingset in lru_deactivate_fn. Can you please elaborate why that's undesirable? What's the problem you're fixing?