From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BDCEC6FD18 for ; Wed, 29 Mar 2023 17:48:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A6136B0072; Wed, 29 Mar 2023 13:48:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 256046B0074; Wed, 29 Mar 2023 13:48:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16BD06B0075; Wed, 29 Mar 2023 13:48:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0B0336B0072 for ; Wed, 29 Mar 2023 13:48:37 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CC1561A06EB for ; Wed, 29 Mar 2023 17:48:36 +0000 (UTC) X-FDA: 80622670632.12.1055797 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 4B01140019 for ; Wed, 29 Mar 2023 17:48:34 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KzrLO9+y; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680112115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iJ/vola4H8cgViEzEkBXlY8ssW/mXMKcLaixwmisg/8=; b=5h6dbiBripAAcID7jZQEL+Dw0c+1Hm4g/kCQZbZt1HDwoSfeNdKDe5NOHJZIwGJYJP9X8Q 0OcYyJXx2Kc/BCEsT54X04xi+cd47YODmG/QVnoXsWIq8nJEGGXmsj816ryVuyiP2mAE/x p6s4TXjDcSZUQ+L86jilKGcHTGSuLQs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KzrLO9+y; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680112115; a=rsa-sha256; cv=none; b=ruVusCEYoavheCO9VFIgyx8DXlDg7W0vs4r+BiauO1kE6SOrnUG2L4RwpC+TmdxqsG1iMN kLcQxtIGXZUfdfBv1SNWVa9dQw/JM4ElXDe6Fsmq1YzH4QZvb0S2d3vYwA8+oGnjbi6/Dd qy9mRl4u+YjdOcgtoduBrL9Y0vG7YlQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iJ/vola4H8cgViEzEkBXlY8ssW/mXMKcLaixwmisg/8=; b=KzrLO9+ytx3PbWRmiLMufLNeIF uDOJXsmUYrUM1RWImI0Q6RZjfNc59DlaoUlO9FYruvV9zL6gp/6N8Ug10m9lq1fW6H4NVD/orTF3L UC22t2bbOh5slkLr32VRltg5atVlsd5nnPGmg+lSz88Pc2EuESTc5Z7LxUO9mbIq1l/uDb1uMyTLZ lLgUTqa4ZM52QW2KhPUgaxaIa9oitnfFZKC5nbMu3w+qsJg+Nhvy8Osq4w45CGu4TT3zT/bf/fRQy UoicfczStNRwCnW3SVVki5SWWM7i0XVCyJkhaCupv57+kOz/v7+3xTJlGG+mzQ2roOdv5F5YXJAQA /G6qJtWw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1phZu2-009drW-11; Wed, 29 Mar 2023 17:48:06 +0000 Date: Wed, 29 Mar 2023 18:48:05 +0100 From: Matthew Wilcox To: Johannes Thumshirn Cc: Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org Subject: Re: [PATCH 02/19] drbd: use __bio_add_page to add page to bio Message-ID: References: <87d0bf7d65cb7c64a0010524e5b39466f2b79870.1680108414.git.johannes.thumshirn@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d0bf7d65cb7c64a0010524e5b39466f2b79870.1680108414.git.johannes.thumshirn@wdc.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4B01140019 X-Stat-Signature: et4n6enxga5m1fuynwnom755dixbto93 X-Rspam-User: X-HE-Tag: 1680112114-301194 X-HE-Meta: U2FsdGVkX19NPbZaYm4RM6+k5Ns7Fa45OfQlkxbb2BEqzTv2/bQ8RGn6D852LfSA1YaEFXmU2ceE6A8Uc/4VmPYZ7+J1DCqpwjZxFrGGhJP8cAs/MqrjGYIXcO38svgLuh4Y96+7DfkPskDsPrAajy7A27qgosimouMTArMZ+/xszgOedECyqwkPqxS0oV+7wHCcg6QNflgRQhQRD4mzedFRnoxSgKfaFo0TaDQOc25p3RFBDTVdymL42qNHE627obfAb8XmfRZ5MMKProkapgEwe3VcHfFNWF4Z9FoSKwR3NltNjVwsTXimbGXk3fEBayxiWmVu1c3iZ/CHFiZjoAJ0LWUDpXVLlnftrKQNCNRptm/9uSyxeYzbK3rpFLS64Xyk0Ky+d3dmiHZrh8b457nmMLzSBgLyaaxeokjkUhXR452md6IG+zRFlre7Xb4vVGA3nZ89fWobq6qdNchuj0m5uvpnYnfq0oObaGe+v4r3fs/AaEnVYxh2NR3wlZX2/GpJ51CVQD41vP/15PMOZPsTUJrgYAcsFSke+ZCurfxWoSUBCuhp3CRxb3PZMY9ySPTlhxLCE3LloxhS+OlXL5lULRTJgTvDhLqfAqcwWCCWbDHEmPNWRC8464biRD5hgPNNclLzTr+EdxIsMKQiBm6dlqbf01ObdVdZsmQ7P7FmvfgJ97GYfexftpsCniMBPGuF4j5eVPI4CiqpNtl+LqABKVaVW4q/j4JLBeq7np9iMhy73jv7yNU2pQ0enPi+OkPnkYGZJQJIRFZGazHw68ppNRK9azZPyfvyJbBeHKefmRaNd1DXC84Q3A5SPaYUZnECXskuQX6sJDBInuAZ5Si4vl4d+xXJmY7Z4clHBhQlE1iLs8rJyXDja9CZO8HcTcRTBuyT/SMVup44y9Eg1n/GoqPW8dfXM+l0Grj1RnizQ/GMl63bZ2+0G0eksFEjBxzV3M2J/v585NedyRM E+N0G0u2 Y0YkLy6I3ItbUsOQW9bo9S77AnMPaHCBb4ClZoP6i+PDHaYqw/SzSV2nIrdhmp4JdlYI/rXM/5Qeta1FCHvAVpupc10fFL2xaFR//330aX96hfEUC9DfdV5kBIXQc5/qbaYGWBt32YhANkF89ZuYXbreleDyiE7tY8VnofKQcbvqBfxEgr5+RwhnhogmSNMk4USz5fPJk+8tXcbc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 29, 2023 at 10:05:48AM -0700, Johannes Thumshirn wrote: > +++ b/drivers/block/drbd/drbd_bitmap.c > @@ -1043,9 +1043,11 @@ static void bm_page_io_async(struct drbd_bm_aio_ctx *ctx, int page_nr) __must_ho > bio = bio_alloc_bioset(device->ldev->md_bdev, 1, op, GFP_NOIO, > &drbd_md_io_bio_set); > bio->bi_iter.bi_sector = on_disk_sector; > - /* bio_add_page of a single page to an empty bio will always succeed, > - * according to api. Do we want to assert that? */ > - bio_add_page(bio, page, len, 0); > + /* > + * __bio_add_page of a single page to an empty bio will always succeed, > + * according to api. Do we want to assert that? > + */ > + __bio_add_page(bio, page, len, 0); Surely the comment should just be deleted? With no return value to check, what would you assert?