From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFA53C74A5B for ; Wed, 29 Mar 2023 11:56:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 274636B0075; Wed, 29 Mar 2023 07:56:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 224136B0078; Wed, 29 Mar 2023 07:56:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EC476B007B; Wed, 29 Mar 2023 07:56:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EF3F06B0075 for ; Wed, 29 Mar 2023 07:56:09 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 89AC6A05C8 for ; Wed, 29 Mar 2023 11:56:09 +0000 (UTC) X-FDA: 80621782458.13.E054258 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf19.hostedemail.com (Postfix) with ESMTP id 9B19E1A0019 for ; Wed, 29 Mar 2023 11:56:06 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=gPDY7Zoa; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680090966; a=rsa-sha256; cv=none; b=huAwJSmqnFqcnFiivXRsoxNvxX7uPHocXCR4OJiTjcke3Pc+8QWjGnLhh73n3jq3cjjRVc 7pqi+h1MzV/02PPO1aYa+AZdAEd0JcSn03S+M1J3cjgxZQ8KFdY7gbDXe4UHt9ROXaAxKs BqsGenhbnPPDlwP9U4g3AzXo3qTlmBQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=gPDY7Zoa; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680090966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MgoqW9i5PP+a88cpUieall/Y5VXNVR+ZmdLSTwQcCUk=; b=1Yt+uBPV/GTgZ4MwQfovgFoVOsctVRvkUiJ5JpUdj0m4IElbOnARgdo3cw6ywBP5qyzHAk t1cfjbd8doh4ZMA11k26FxBV6goJWWJYmBe823Cwu5pyq26B3HQXWiKU8faI2qGPxPaXTH IQC54ppkUe/mZM1L3MlfEruRUtQNEtQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3DF99219D6; Wed, 29 Mar 2023 11:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680090965; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MgoqW9i5PP+a88cpUieall/Y5VXNVR+ZmdLSTwQcCUk=; b=gPDY7Zoa+PX03ws7DqJY76AlRsJnW8njixlmMYQFSry0Sm7LYXBffaSrEiEddrRh93lQ4b ta0+tMP2rFqm3q5t+9Dfe+XUHMrnimp8Y7siBb2qRrh+CyK+th4RsUG//OZ8FQ4e5R54q8 ObR9oKGkhhZrGoyU+nMqPxNH4q//bhU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2CAA5138FF; Wed, 29 Mar 2023 11:56:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KZZ/ClUnJGSOXQAAMHmgww (envelope-from ); Wed, 29 Mar 2023 11:56:05 +0000 Date: Wed, 29 Mar 2023 13:56:04 +0200 From: Michal Hocko To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Michal =?iso-8859-1?Q?Koutn=FD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 2/9] memcg: rename mem_cgroup_flush_stats_"delayed" to "ratelimited" Message-ID: References: <20230328221644.803272-1-yosryahmed@google.com> <20230328221644.803272-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230328221644.803272-3-yosryahmed@google.com> X-Rspam-User: X-Rspamd-Queue-Id: 9B19E1A0019 X-Rspamd-Server: rspam01 X-Stat-Signature: bxqspo4wq439z4uaku3x31e5ga34qahb X-HE-Tag: 1680090966-579798 X-HE-Meta: U2FsdGVkX192S9EgiDTC4MAIo9Ip2IGhNGoSMZJmcl2Azs3rJCoCvso6J2RVhGolmYVW16jNsux19HpwVhmD1fkmuIuBy4MAbg2peXGyDF73Lj7LH/hgmrc4fYDtzjM9GwsRRLZtABc3F+IkYzVmGGjQ1A+LrOSi02D6aIC2NXaU563/CgMrbBDGqh4Vubs3AKZV2ecn0rMsyiTqitDfttjAQJ9STupCOiTFHMARlIbTbBCxXkC26IcTYfR1Wa48z6CqdBhhiZg0m7WJNuDPigvT75N4nNlopPWJZaB9+GVDiMJ77uP0bcRqiKp5CuVKPUiO0JiMfwiXCiVrfg/NDCsY2ytCjIg+Mf8v4uKRjHfP0swvelc2q9sbKgVSbi+GvI6RLdyG49/9bdpzH2hKdxRnJADXCDywQ/cu40m89GQ0jXbUofTw+/vBA9gS3mIM6I9jFOyiKtLV4cA6l5puSEMRkI2ZcLOCkTAi3oWEpQxxPISPi7dUNUY6jUTxyBq1tdt3jS6fYvGGXm87Txjai6QD1ZrtVnhWsxwHFHxLuHY9hx51lFqdOkmn4O7ubQ3FGnLDNFGtIlcFAs5lhce0CZCN6rNPH1q8+CIn9R3TNbyLXBbeOVTLRW+9GCB0OxDZ5833WpxrJahQBZKI2t6LVxvozm7DSolP4GqFsxqTioL3WWME6zkaGxAKzfCoM3aQu66Kd3zs8Xl3fQeYJoJGddnbdesKm9KvgdZ04MvS857S6baMrLbe6GOk4ayCx8UejMk6YdZw7m8IEC3DpyV/O+OeyR5AZLiJQAyIX6YYbCsCNEot/nWPkX+6wKexx+pbld0W9SrXI+k7wmdEjUhckzmqA3RFkd3FXA5HrEwPZwkSA8oKnPjuQ4FjF+p2+u78m5dLKkRLpcexMGaw9mlrs3oaP7STkeB/3M/XGJEEqVFRsE6QSW7GiPpneQvIL3qTJUKSLN/xoDPeEZ06Sre VepkPkox hp32n6UVJTmwaeAIi2vvX0aHQ0ffNyuPlXJ/O+XdxEyU33/gnfQ/xpelv5KKrKPwSqAyQiURVxv+2tE5KtqKikVLxXwIF7L+A4SWD9DlrmlQRd6liSysk5hWwB5weaJ9Asb7/7GQkmtPft3puzOLn60SAPyj4hbZi80VAHZjd/oncRXH39p7aT7cOJS9ljh9dqiy1z0hI/RSqFtdMfre1IO1pE0MsCe4mnwLweBvsohrPRvX+yoUfpbSxVxcmL3gZpcKKI1OynV9oKAFae/Q2AYah34t21hovDalrC3PyaT90JR6+GkDIew7AF70gabUTfMNqjIHVW2bWFI4qV1T4tuZQPUXPYmLxLksX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 28-03-23 22:16:37, Yosry Ahmed wrote: > mem_cgroup_flush_stats_delayed() suggests his is using a delayed_work, > but this is actually sometimes flushing directly from the callsite. > > What it's doing is ratelimited calls. A better name would be > mem_cgroup_flush_stats_ratelimited(). > > Suggested-by: Johannes Weiner > Signed-off-by: Yosry Ahmed > Acked-by: Shakeel Butt > Acked-by: Johannes Weiner Acked-by: Michal Hocko > --- > include/linux/memcontrol.h | 4 ++-- > mm/memcontrol.c | 2 +- > mm/workingset.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index b6eda2ab205d..ac3f3b3a45e2 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -1037,7 +1037,7 @@ static inline unsigned long lruvec_page_state_local(struct lruvec *lruvec, > } > > void mem_cgroup_flush_stats(void); > -void mem_cgroup_flush_stats_delayed(void); > +void mem_cgroup_flush_stats_ratelimited(void); > > void __mod_memcg_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx, > int val); > @@ -1535,7 +1535,7 @@ static inline void mem_cgroup_flush_stats(void) > { > } > > -static inline void mem_cgroup_flush_stats_delayed(void) > +static inline void mem_cgroup_flush_stats_ratelimited(void) > { > } > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 0205e58ea430..c3b6aae78901 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -653,7 +653,7 @@ void mem_cgroup_flush_stats(void) > __mem_cgroup_flush_stats(); > } > > -void mem_cgroup_flush_stats_delayed(void) > +void mem_cgroup_flush_stats_ratelimited(void) > { > if (time_after64(jiffies_64, flush_next_time)) > mem_cgroup_flush_stats(); > diff --git a/mm/workingset.c b/mm/workingset.c > index 00c6f4d9d9be..af862c6738c3 100644 > --- a/mm/workingset.c > +++ b/mm/workingset.c > @@ -462,7 +462,7 @@ void workingset_refault(struct folio *folio, void *shadow) > > mod_lruvec_state(lruvec, WORKINGSET_REFAULT_BASE + file, nr); > > - mem_cgroup_flush_stats_delayed(); > + mem_cgroup_flush_stats_ratelimited(); > /* > * Compare the distance to the existing workingset size. We > * don't activate pages that couldn't stay resident even if > -- > 2.40.0.348.gf938b09366-goog -- Michal Hocko SUSE Labs