From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A3EDC74A5B for ; Wed, 29 Mar 2023 04:53:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81C566B0075; Wed, 29 Mar 2023 00:53:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A5896B0078; Wed, 29 Mar 2023 00:53:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 645246B007B; Wed, 29 Mar 2023 00:53:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 516026B0075 for ; Wed, 29 Mar 2023 00:53:57 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1DB5B1A0461 for ; Wed, 29 Mar 2023 04:53:57 +0000 (UTC) X-FDA: 80620718514.24.10392B7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 553B14000A for ; Wed, 29 Mar 2023 04:53:54 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VN8RSeU1; spf=pass (imf11.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680065635; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S01Y/zhEA4qaJvTIo0c2m8xjYqU32cqDPsOeaeS0mgQ=; b=kZNfTpU+WpAG+fU8Plus5Pc8o1ZHDQpHCMchVjWTu3vPOhSIcvNgimba5nJuSGqSB3UteP wcl8TLuBbQNITRl8BFAe57DaJtT24DzgaEEyeuygALCCPTdYmT8WkmOBqOXkg/zZD0oSxc uR1bsnMgPacDEkEssID16ywBeq8b4dc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VN8RSeU1; spf=pass (imf11.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680065635; a=rsa-sha256; cv=none; b=ZemHI8U0sc2LmFV8/Bfk9DhqSuvCNXa+AwTED51ADN/jI2R/k6uxkgY0rEksP38fNjmgXN uzSvoRFLLdDjR4jivVsblhmAQYQ6AmTIFkTQ1Mzb7YK/3d0DWhVIm8/VLOpz8v9wFNq1RW HsvHg+eBwQ/HvTZkR1h5K1t4oXKkcv8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680065633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S01Y/zhEA4qaJvTIo0c2m8xjYqU32cqDPsOeaeS0mgQ=; b=VN8RSeU1m2u2IXd36Idhjio0ZJmk5FM0ysvBTKtA6T9ri03CeopGAe1fCWEOTvKGp1OqVI 8hWe1+7XZpOwmBFiK0XbHbw1cYP2r7WlPREYYstPp/QG7XQTQc5xBTZjSajYjAFH5iKD01 W0H3NmOOL4Z2bqhdsrO5IE8INF/c/1Y= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-271-Ii-LZ0zMOzmqRxZZOA6_Ig-1; Wed, 29 Mar 2023 00:53:50 -0400 X-MC-Unique: Ii-LZ0zMOzmqRxZZOA6_Ig-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 418F6101A531; Wed, 29 Mar 2023 04:53:49 +0000 (UTC) Received: from localhost (ovpn-12-137.pek2.redhat.com [10.72.12.137]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D181B1121331; Wed, 29 Mar 2023 04:53:36 +0000 (UTC) Date: Wed, 29 Mar 2023 12:53:33 +0800 From: Baoquan He To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Uladzislau Rezki , Matthew Wilcox , David Hildenbrand , Liu Shixin , Jiri Olsa , Jens Axboe , Alexander Viro Subject: Re: [PATCH v8 0/4] convert read_kcore(), vread() to use iterators Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Stat-Signature: b143kh7p7rctgqxzes1zktkwd1161eks X-Rspam-User: X-Rspamd-Queue-Id: 553B14000A X-Rspamd-Server: rspam06 X-HE-Tag: 1680065634-842320 X-HE-Meta: U2FsdGVkX1/DRowZ6gJfNAw3Ws/MOQ3MLfGmmhUTeK0ec5I/0K+3e/ChMyuCgfqsEVMcUf7ZG+FydhKAfSdIGZRwQCVCoWX85GfpZRbEpORnu1AUDYXNXv6QZQDRig7tJopvJ7PkTRYpO+rhPi0psDcOIqF2yllrbjz7mowmX3bl/pq5oIbncNR+b84RkSkKJOdEnZYwqAUkzTHOu4iG8InWf5400Fg7Wy1v3BAETgRGRyND+UBfongjR3vu6LRo6hsmpA7Mn2IENTEmToe+2MmTY4jjv1GjBf1402tvwSl6HYOQUMYz85ybZFnysOI3yWoU6LHY8LEpOJARaE4SOJkXLN2Ub9Crg6+8b8U98+gRvYPyRmBLfhZm/J024iwjUWiYD/oUqrfrv8DvkhYASlh3/KDojkUYLoXq7RQOPXqHKrQ54SfN2cc5QBmVgAroiNMbzzMGfNlLsNWS/KVC0o/DaL/2eV1Kv7vxN0/YyhxMwO3dzihYzGatuXPRGCVujkS1dum68sfyD4StdZLMsXsBZLVg3KuAc2CSfaNDf76zDJAEpFMoDZ8TYTEpLzK+ggXzrfdIAp7KIL8vDBojl4EqhTTwXA6amSA2wVsL0MYcFO6SCdTaFX8ksMU/lkje9JGAU7lMibpGy6/TfRxpethoLWyK6LHUdTDbsn7xAIDqKnJ4Tn85RWfdAEuZZrDKg3CWhvN2hjYSRXZHanrV4K/VuPtu29I7K+/zvovpVs55mWZPDCNkHpxMTDOnQzb7Q7l34cSKhOYG3naeAYbT1M8aUZ2A6hcQUDieAQ+ot4nIf/aHSAD1Og6hchtFziR9tOKJs6iz+3P8551VkS0wP26rFRHLvPPkMj+YogIQ3GGURrPXdUTcR0gs64nDcdAFj55nziRvzNDlg8JN6K5beGL3lbGMSJYr8H+j+BmB0W1jcTv4uHeoD1A7FfhBB4l2CjoutlSTAuZYWouZH0R BvPMHdBS bB32+yfBTIjniUOLASENPSCnPSX1w9VnfgV4aTEsBeNux20jFcO0c7O+iA7A1n7BLh8J/cQr7Z3kwYxaUJZAw/VLxZZHlc77fHb15RggH4khb59hJP6z6Kw644HfJ+t63tGjoIqNIMxkbD+dyEux4N74ONIdLvMpq1AUbBf7rC7ZSQKO5GuXIqo+v5Nq6e9UYOYoJa1Tgko1RQ7Xvu1r5ox9gQX3T+FhYs0JziuUCJLGyuD1aW0gl3KJZHY+JyDivUxEgn5PII5+hd/ncOefbJON34oENiiQb4/NrAaJl5LpVhM9dVWmr9AuVXkmu5gtNlug4RHt8++wE00x4/QX041SndAYQLl5on+9X1DeMA6zsKCand+CVzHMB9UfQSncdJrT16Z/H3gnaW58g2GCIHpWsl92DKdTtze/cD3rDsJidYgziYwS7CH4EAX38Qk+RGifEX/rjj6PVVQPMu4iFIuU01BJMZ94l5g5+4WntA+ng35xNmqxs2z/RKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/23/23 at 10:15am, Lorenzo Stoakes wrote: > While reviewing Baoquan's recent changes to permit vread() access to > vm_map_ram regions of vmalloc allocations, Willy pointed out [1] that it > would be nice to refactor vread() as a whole, since its only user is > read_kcore() and the existing form of vread() necessitates the use of a > bounce buffer. > > This patch series does exactly that, as well as adjusting how we read the > kernel text section to avoid the use of a bounce buffer in this case as > well. > > This has been tested against the test case which motivated Baoquan's > changes in the first place [2] which continues to function correctly, as do > the vmalloc self tests. > > [1] https://lore.kernel.org/all/Y8WfDSRkc%2FOHP3oD@casper.infradead.org/ > [2] https://lore.kernel.org/all/87ilk6gos2.fsf@oracle.com/T/#u The whole series looks good to me. Reviewed-by: Baoquan He